From patchwork Thu Aug 31 17:52:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 9932669 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9E0CF602F0 for ; Thu, 31 Aug 2017 17:53:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B4F02891F for ; Thu, 31 Aug 2017 17:53:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8034F28A12; Thu, 31 Aug 2017 17:53:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C63428A47 for ; Thu, 31 Aug 2017 17:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751040AbdHaRwz (ORCPT ); Thu, 31 Aug 2017 13:52:55 -0400 Received: from mail-dm3nam03on0057.outbound.protection.outlook.com ([104.47.41.57]:63776 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751410AbdHaRws (ORCPT ); Thu, 31 Aug 2017 13:52:48 -0400 Received: from BN6PR03CA0014.namprd03.prod.outlook.com (10.168.230.152) by CY1PR03MB2265.namprd03.prod.outlook.com (10.166.207.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Thu, 31 Aug 2017 17:52:46 +0000 Received: from BN1BFFO11FD021.protection.gbl (2a01:111:f400:7c10::1:131) by BN6PR03CA0014.outlook.office365.com (2603:10b6:404:23::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via Frontend Transport; Thu, 31 Aug 2017 17:52:46 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; altera.com; dkim=none (message not signed) header.d=none; altera.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD021.mail.protection.outlook.com (10.58.144.84) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11 via Frontend Transport; Thu, 31 Aug 2017 17:52:46 +0000 Received: from r49496.am.freescale.net (r49496.am.freescale.net [10.29.244.202]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v7VHqajO026181; Thu, 31 Aug 2017 10:52:44 -0700 From: Fabio Estevam To: CC: , Fabio Estevam , Ley Foon Tan Subject: [PATCH 07/10] PCI: altera-msi: Fix platform_get_irq() error handling Date: Thu, 31 Aug 2017 14:52:07 -0300 Message-ID: <1504201930-3617-7-git-send-email-fabio.estevam@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504201930-3617-1-git-send-email-fabio.estevam@nxp.com> References: <1504201930-3617-1-git-send-email-fabio.estevam@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131486755662344334; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(498600001)(626005)(356003)(305945005)(33646002)(105606002)(2351001)(106466001)(189998001)(8676002)(76176999)(50986999)(50226002)(104016004)(81166006)(81156014)(2906002)(77096006)(8936002)(68736007)(8656003)(53936002)(8666007)(54906002)(97736004)(36756003)(2950100002)(6916009)(6666003)(5003940100001)(4326008)(47776003)(50466002)(86362001)(85426001)(48376002)(5660300001)(110136004); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2265; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD021; 1:OjjCKFfvQdx3yN+ODEIQFPvaLdVVq+5qRGDi6anWqOq3fkEMGlWuwurhmcJ11BMeC4dz2h6Y3HFQw7QxiYEPPAByB7xJ9GYDcc0b3vFMW4lDtPf2ByGk7gHinJJIJ+ll MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae015f6f-36c8-49b7-cf2f-08d4f0991660 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR03MB2265; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2265; 3:eZ+GGIEZRhrEppJnFOgKleZwXvYyqxr5HIPZx/CCFC3SFw0ZZmfjwtqQLBcWI62lNzsv1QoMXqNI5zNGpoRAhby1ENG0EhzfDayDvzclHW692Dww9BDZJ4PPbv+08hBJVegt4tRnecXxAVbXe4mUskCj6Ovufhvga0SqeC9Ri+Q9brPJMEU6h/3t4D7b5mAh/Kdl56I/3AVsP+dINT8hfcWqQlBwUSRm4eOmLCs8C2TIcEMMeUUwpa4LOPh4WMQf3NZcwfEa2wIMH4X9nSxBioCltrhhcjvByJaJg0EjBZYrnmxD2PxyKk0kyiaCLOP22IMF3FUPK2tJojt14lPWc6LUB+VCrmdjFCZ8N/plwjY=; 25:Eu/QGsxtkpaiZVkMt9MAo+CXecF/WBipJDtEANbCChoUZPAjYki2xuH8VvdU8r4BkK/PXSCHgPfBWLI13muxettvN3w4+teNZ0ilsiKzGAdxMUkkq1v0zvIwuDytKGnllmHSitlF9owYVB8krx/JzKSaOFLWNjuUZDMB/8nsMl4dRDXAOjhmSOw0DFFGWOOD3Qz1ro5dJkzl/azENzhMIxMdMNhcvQEpfiuBFVn4z/vsx/4GpywxAL2jheJ6hB1++8wRqARGji0QmmhMEHEtAXZubB3ipG7dk8owIHuvuAfqQyUUrPKg4LiEANqqPN649/xmFvrUBX4Bytzh37c9fA== X-MS-TrafficTypeDiagnostic: CY1PR03MB2265: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2265; 31:9b80MrhdZxqmKb5oO83VRM3hIxrXgEppR65ZmRoChUWUeIB1ee056XkPDCkRK4NNmJtuWsw2xWxrc47PaXLViJXdpfzD3IH9PMAE5Xe7xAByQhv6435xsTqNTjkEzS05Fbbcfn2o0tOHrXoqHBK4zekzhz5w9qTm7a8OyPKgAe0htqg6jBPN3mSHpd/RH/QsZLo+vgY/4/ONKQidkPo7qNs6hYzaSjXIrztRokVAR68=; 4:4F+UoqchJsaOnXP8uSXRv6V90pe+mgs03xfPgc9YAah6w6QpUQGF28FC64gdPvef31nhEVSjKkpJFSi1khgRWH9hcATvY35+83B6XvRJFQgpqpMVPT21Rlv0KHxqfq9LON3Io+i+w9UjFl+Sc31XsJXZFFvfigHqB9QsqLyCKr1crs5wv6xIxEdNC58tpOdky8Zd/3VtOwRe5r0F9wZAB5taU9uobWJsxmK1nKI+cWWxVXMpsyFeYb4lWt3RLl9rYLTxy7lAXdYT1Jd2M6hcq783ytLyHcNE7Dj+l6uhnWao3m5+pRMHRf7rUpcEn1bQEm2ggRKwC+KjDpBDHfukNg== X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(80048183373757); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(5005006)(13018025)(13016025)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6096035)(20161123561025)(20161123563025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123565025)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR03MB2265; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR03MB2265; X-Forefront-PRVS: 04163EF38A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR03MB2265; 23:t10jf7Jx9zBW7dmr9YxQnZGFKkX/EmrZgYUtL/uHn?= =?us-ascii?Q?g0aJ/iznWHkZpbmHM0jl4mtfq4S1YC1njaTT38NOe8wHn+zZzp44sI5bDod2?= =?us-ascii?Q?q0j+4BRLoSmAiX+TxUXPzfTuXyCo1W1foCoq2/FYrp35B+lqxDtwAPaDe0+Y?= =?us-ascii?Q?DAuVV+SUvG7XzTL1k8UjXKX43+aQogWwS//Ri7xbFtR7U8p+1eTtGfEYK4gn?= =?us-ascii?Q?5wTXiOffVSAALOorW5mo56IKWP4sluGuMUXJl2vU82toSBMT4N5PafpPMQwZ?= =?us-ascii?Q?B8BC2XqqZlZ8FbD9oPHBvgAnF1PfLRj2CTNoVO4CR4Rp+cU5LOy2z0a+7CqB?= =?us-ascii?Q?IG5rFEBJhTUa5YPAL0JonMwDQ8M8hzrE883bo41b9vCnfnnAutkeZFCXdaS/?= =?us-ascii?Q?1v8pAusKTIz+90OXeGHoEVDBK75VQwn9XXp5ej2EuzZkva3ZtEcJ7I6B8/oe?= =?us-ascii?Q?Wn+GSDR+wBjUh6RpBl/qjWkMhnR3oc8QwTg8b0Gwyg128ksk5j/k9fvxFVnl?= =?us-ascii?Q?q1m/PYRJyeDxwbc6cysMqNMJ6vBjgZpE2hw7oUwWKpLv6CQBKTzXCw+5ZK7j?= =?us-ascii?Q?YX62p4MKytElZvvvRy0uH+IR52yXbI7Io5G8HPCWwKZQKOIGcy9bzPBwHUz2?= =?us-ascii?Q?F0NN/QRzuUilO5nBYKyBKnoB0M9P8rSfbua08G70chtqdkY9C863m9cBR5v+?= =?us-ascii?Q?TREqA+fv0ArHmpz3aAK5VBdQdW2ICfx+T41i4PircdhLwbQ62HFwXK+pLOwr?= =?us-ascii?Q?c7yTIrH10A3/7gyhG843mb3IER7fM6B3SSdDb+U4qsGrLFVwwgyerB9CRMbZ?= =?us-ascii?Q?C3YXEPP0z1NFzbzOxdB/1il8rpAMQTvHfwooommNiX8Ytqn70fJYgNh8xq8Q?= =?us-ascii?Q?hgnjgrN80F4Yvwtcsj4YnyY+KoLPJlvS+VGs8zkti0vAvVKAeg6YUMhDzGQZ?= =?us-ascii?Q?0jlMxJpo1oCc2dFaxZKaFoZHNP9GSKdKn6b6lsSNEWiKNkyt/4qseuyHz67c?= =?us-ascii?Q?dc8PT7hx1dXN8T0N6Br1UJLggFuSrxQyfEcGk5AJ+JvdrPumsns8Unga/YAo?= =?us-ascii?Q?mfGVmJyNLdetpFOv+I46QaTEmVekXFEvIO3gtX+OHv1x7JX32EP2HaAHICZf?= =?us-ascii?Q?IfTyZxMJ9ilS7PuxMg2pLI22XCbdxfn?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2265; 6:IwP+EqVOWi79NLBlHqcpGs9LhrzDQL6a1rO6fz+b4UkdbyH2vLNwXggDLq3lfXPrJB5ZmUI3I/3z9eSBLSVbkjrWzdt3XuCdFVD2OnfAR9r/TfYW05OCd+qCZ3LvAqTL4mM/YGn/LGjW6Su3VKlFRruQT3AvwyI/jU0lfUEaYXFyEqvk3aNQ7rZ+OHTLCb2NV7m8ylstgHqPriTRFKxayI0XetcMQeFB49Ar18lUsC4C3xiWWg7Bd1SnEwd1Ok82ZbqQQpn4ZVchJSdODS+auJlsLT0xgbFaW/vh0xXXR+s8Dm5jFNMoPPrSGHwhyrVuBX87RneYLjeDsfOtHU0AZA==; 5:KkqaOSVtmLc8c3A8sAX4o+HHKCmz2bTpMPUgnslQCm2HWticHrhzRdsSWyVvTYeGpbJxo++6KCXOvhPsz9VtCjlEMttiLUsGVaZGXsMWU40+lrhkoUiwrrbEAglSF4vxRMhOe9SpFiW5v7R6iGF9ig==; 24:YGdIypaEONw+fZm3BtXLjIFS6mDrSZCnHtMH26nl0mDfSLQ6KLkVcxdtQGL19yG0TrQ5Dgfz2nbucGO9KrAVr2tOnK+mcPdTfQhMUBsh5ac=; 7:JeCUhfMthw+gIJskdd9Tkv6ApAo2ujudOcOqwRyqvP5jALZx6ci1v8UcgF8bd4/y62Rw050uzPS+/u0a3oPNj8/dW+e4MPkq2kilrzE/otvHTUdIzLZKkKw7NlKd68Nw5fn9EzwnnOP8vBhiA5/+U9HnQGJtux+zTRHc2LgrJWpM2qYKW5U9IyZkb6QxSwfkldoiMByQUdZu8torrfsoqWTynEnfqxEamQSX2a4P79I= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2017 17:52:46.0316 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2265 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP platform_get_irq() returns a negative number on failure, so adjust the logic to detect such condition and propagate the real error value on failure. Cc: Ley Foon Tan Signed-off-by: Fabio Estevam --- drivers/pci/host/pcie-altera-msi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/host/pcie-altera-msi.c b/drivers/pci/host/pcie-altera-msi.c index 2864030..d8141f4 100644 --- a/drivers/pci/host/pcie-altera-msi.c +++ b/drivers/pci/host/pcie-altera-msi.c @@ -265,9 +265,9 @@ static int altera_msi_probe(struct platform_device *pdev) return ret; msi->irq = platform_get_irq(pdev, 0); - if (msi->irq <= 0) { + if (msi->irq < 0) { dev_err(&pdev->dev, "failed to map IRQ: %d\n", msi->irq); - ret = -ENODEV; + ret = msi->irq; goto err; }