From patchwork Wed Nov 22 22:49:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sinan Kaya X-Patchwork-Id: 10071781 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5F1E860353 for ; Wed, 22 Nov 2017 22:57:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5024E29E2F for ; Wed, 22 Nov 2017 22:57:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 42C8329E20; Wed, 22 Nov 2017 22:57:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE86329C16 for ; Wed, 22 Nov 2017 22:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752906AbdKVW5L (ORCPT ); Wed, 22 Nov 2017 17:57:11 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42014 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753310AbdKVWtu (ORCPT ); Wed, 22 Nov 2017 17:49:50 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B5E0460819; Wed, 22 Nov 2017 22:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1511390989; bh=vzRk/vFUyKIwR9RbnrMjGqKKmLzdxl5LPLKu0CSEh9s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D2ZDzoOVXA6xiL6r/Gt/SGGwgv+Gxu+KjQiHBIHB6kCcQZ8atkIbPNBeYGD8XLlCV X0rnt2hjVDGj7QoJsNRbpw+Gz4Z1z2nuZDdP5xb1bfp9f6nTz4tgIoHsoC2fOnV7dI pxaUjWoYDXpxV9gcLJWWLf8RVThtZVzKn3chL6MA= Received: from drakthul.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8DCB960886; Wed, 22 Nov 2017 22:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1511390986; bh=vzRk/vFUyKIwR9RbnrMjGqKKmLzdxl5LPLKu0CSEh9s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HgQlaj7FUZLceD4TZSPOW0f8jmXZwfXcoHj/oYXxd4MJYod54FXgA7N+f7sUqBkvF I7lLMMDTwQJ3T8NVr+TLPiHlXvSybj+gz2h3snFQlOaovCDkngyn48CUtA7m4GKQOz hs+bkRdWEK4awFWdiya10gO2W8dwwZ4fDqLi8xbM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8DCB960886 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org From: Sinan Kaya To: linux-pci@vger.kernel.org, timur@codeaurora.org Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sinan Kaya , Peter Jones , Konrad Rzeszutek Wilk , linux-kernel@vger.kernel.org (open list) Subject: [PATCH V2 07/29] ibft: deprecate pci_get_bus_and_slot() Date: Wed, 22 Nov 2017 17:49:02 -0500 Message-Id: <1511390964-9979-8-git-send-email-okaya@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1511390964-9979-1-git-send-email-okaya@codeaurora.org> References: <1511390964-9979-1-git-send-email-okaya@codeaurora.org> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). We don't search for the device in other domains than zero. This is because on x86 platforms the BIOS executes only devices which are in domain 0. Furthermore, the iBFT spec doesn't have a domain id field. Signed-off-by: Sinan Kaya Acked-by: Konrad Rzeszutek Wilk --- drivers/firmware/iscsi_ibft.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index 14042a6..6bc8e66 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -719,8 +719,9 @@ static int __init ibft_create_kobject(struct acpi_table_ibft *header, * executes only devices which are in domain 0. Furthermore, the * iBFT spec doesn't have a domain id field :-( */ - pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8, - (nic->pci_bdf & 0xff)); + pci_dev = pci_get_domain_bus_and_slot(0, + (nic->pci_bdf & 0xff00) >> 8, + (nic->pci_bdf & 0xff)); if (pci_dev) { rc = sysfs_create_link(&boot_kobj->kobj, &pci_dev->dev.kobj, "device");