From patchwork Wed Jan 17 18:30:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: KarimAllah Ahmed X-Patchwork-Id: 10170419 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0FB3B603ED for ; Wed, 17 Jan 2018 18:31:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F403A1FF29 for ; Wed, 17 Jan 2018 18:31:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E731320408; Wed, 17 Jan 2018 18:31:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6C4220134 for ; Wed, 17 Jan 2018 18:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754406AbeAQSbm (ORCPT ); Wed, 17 Jan 2018 13:31:42 -0500 Received: from smtp-fw-6002.amazon.com ([52.95.49.90]:32378 "EHLO smtp-fw-6002.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754372AbeAQSbm (ORCPT ); Wed, 17 Jan 2018 13:31:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1516213901; x=1547749901; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nrcaNgzvwALWQAUkFBlWKa/PLTMbknbCEemddoQzgfg=; b=fiE4AHkCjVW4CcxL9XPQdg55CAmJTU5jKe0Ng2lQQpatj5n4rPxyGZZn ziUHX6hoPO0mJ1XY0t09YHwe/NXYC7MorrCbTqmhPAIjfQe/uFDNyc+cd DiH7htz+KCtSV6m5lTY65WyIcLSznyRzKEqvDHJ+GHOOB2IMG0SJECHud g=; X-IronPort-AV: E=Sophos;i="5.46,372,1511827200"; d="scan'208";a="327707695" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Jan 2018 18:30:48 +0000 Received: from u54e1ad5160425a4b64ea.ant.amazon.com (iad1-ws-svc-lb91-vlan3.amazon.com [10.0.103.150]) by email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com (8.14.7/8.14.7) with ESMTP id w0HIUhib071530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 17 Jan 2018 18:30:46 GMT Received: from u54e1ad5160425a4b64ea.ant.amazon.com (localhost [127.0.0.1]) by u54e1ad5160425a4b64ea.ant.amazon.com (8.15.2/8.15.2/Debian-3) with ESMTP id w0HIUgZV014915; Wed, 17 Jan 2018 19:30:42 +0100 Received: (from karahmed@localhost) by u54e1ad5160425a4b64ea.ant.amazon.com (8.15.2/8.15.2/Submit) id w0HIUgRk014912; Wed, 17 Jan 2018 19:30:42 +0100 From: KarimAllah Ahmed To: linux-pci@vger.kernel.org Cc: KarimAllah Ahmed , Bjorn Helgaas , linux-kernel@vger.kernel.org, =?UTF-8?q?Jan=20H=20=2E=20Sch=C3=B6nherr?= Subject: [PATCH] pci: Do not read INTx PIN and LINE registers for virtual functions Date: Wed, 17 Jan 2018 19:30:29 +0100 Message-Id: <1516213829-14844-1-git-send-email-karahmed@amazon.de> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP ... since INTx is not supported by-spec for virtual functions. Cc: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: KarimAllah Ahmed Signed-off-by: Jan H. Schönherr --- drivers/pci/probe.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 65099d0..61002fb 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1232,6 +1232,13 @@ static void pci_read_irq(struct pci_dev *dev) { unsigned char irq; + /* Virtual functions do not have INTx support */ + if (dev->is_virtfn) { + dev->pin = 0; + dev->irq = 0; + return; + } + pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &irq); dev->pin = irq; if (irq)