From patchwork Tue Apr 3 09:19:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loic Poulain X-Patchwork-Id: 10320855 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3E03E60318 for ; Tue, 3 Apr 2018 09:19:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3722528883 for ; Tue, 3 Apr 2018 09:19:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2BD9128948; Tue, 3 Apr 2018 09:19:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9AFA228883 for ; Tue, 3 Apr 2018 09:19:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755354AbeDCJTI (ORCPT ); Tue, 3 Apr 2018 05:19:08 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:51699 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755253AbeDCJTF (ORCPT ); Tue, 3 Apr 2018 05:19:05 -0400 Received: by mail-wm0-f65.google.com with SMTP id v21so32074861wmc.1 for ; Tue, 03 Apr 2018 02:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=YqAVQt+zhGsYu4zNGQ3cJMG0TIHKZm713y5FAPHbwYw=; b=LZPfQTsetao0TnNSajUtH0j2QGFU0vc835b63zEkBIxFFx0ewGBGhezaK6VLimhftG c1KXvq1+KCztx6TMFN+vf8FGTZIGbmWY+pCYtqYDiYQDyEkzR+wdAwqb5Oz/lXqy/mkD 6dWwQaeBthXpjIsyO5f1b5wVfB5g28r3q5ZNo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YqAVQt+zhGsYu4zNGQ3cJMG0TIHKZm713y5FAPHbwYw=; b=BHPksCWCUG/0WV4SoC1kMCADtLgxrdNzTeyww4CTqwwt7LMqCqawYsuW6rlNygldY9 lNRak6/JZdzikdIywV0gye1+ihI5GlP2uDMN/4mQ/lNc0QsYK23nb6ly6EG9zlUu7un+ NJkuu6usEP6pErhwhUa6/KP4LWxuGwSYrmBLnWQrQd1e1SxFao4QH2bZmiottJgO/4+A KyQ8PKwNK4Xknd2JNkTJO0lqh12Vjlt1Ii+so+zZLXZ30n5J63l31uAIxL9VPSGrAVy9 KCidIIqgRsQdJerqTUyMVBb2qRFGUW/l6i+Eb/S18yS8z3u0YsuQ2eWGYdRZ1EytngwO dTTQ== X-Gm-Message-State: ALQs6tDZmVherj90yaB7v8W/pHTw14w2xvTCc/N3L2ECdkSGjarOoSVX piPe+2iurKbwUo20208Q+asmhg== X-Google-Smtp-Source: AIpwx48hl80a0FFxCeilhZuDqnJ+s8mfJSwniHBzkgUMR++gQq7+ZrbEVOOr93fKHYg1QgOl1+DANA== X-Received: by 10.28.144.146 with SMTP id s140mr3066937wmd.74.1522747144430; Tue, 03 Apr 2018 02:19:04 -0700 (PDT) Received: from lpoulain-ThinkPad-T470p.home ([2a01:cb19:8349:a800:6cf4:43ae:6905:b036]) by smtp.gmail.com with ESMTPSA id g38sm3861234wra.77.2018.04.03.02.19.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 03 Apr 2018 02:19:03 -0700 (PDT) From: Loic Poulain To: songxiaowei@hisilicon.com, wangbinghui@hisilicon.com Cc: linux-pci@vger.kernel.org, bhelgaas@google.com, lorenzo.pieralisi@arm.com, Loic Poulain Subject: [PATCH] PCI: kirin: Fix reset gpio name Date: Tue, 3 Apr 2018 11:19:01 +0200 Message-Id: <1522747141-8299-1-git-send-email-loic.poulain@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As documented in the device-tree bindings (pci/kirin-pcie.txt) and defined in existing device-tree (hi3660.dtsi), the reset gpio name is 'reset-gpios'. However, driver looks for a 'reset-gpio' resource which makes the driver probe fail. Fix this. Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe controller driver") Signed-off-by: Loic Poulain Acked-by: Xiaowei Song --- drivers/pci/dwc/pcie-kirin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c index dc3033c..efc317e 100644 --- a/drivers/pci/dwc/pcie-kirin.c +++ b/drivers/pci/dwc/pcie-kirin.c @@ -490,7 +490,7 @@ static int kirin_pcie_probe(struct platform_device *pdev) return ret; kirin_pcie->gpio_id_reset = of_get_named_gpio(dev->of_node, - "reset-gpio", 0); + "reset-gpios", 0); if (kirin_pcie->gpio_id_reset < 0) return -ENODEV;