From patchwork Sun Mar 29 16:54:44 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Chiang X-Patchwork-Id: 15022 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2TGuEqp005591 for ; Sun, 29 Mar 2009 16:56:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758927AbZC2Qyr (ORCPT ); Sun, 29 Mar 2009 12:54:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758475AbZC2Qyq (ORCPT ); Sun, 29 Mar 2009 12:54:46 -0400 Received: from g1t0026.austin.hp.com ([15.216.28.33]:37439 "EHLO g1t0026.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758877AbZC2Qyp (ORCPT ); Sun, 29 Mar 2009 12:54:45 -0400 Received: from smtp1.fc.hp.com (smtp1.fc.hp.com [15.15.136.127]) by g1t0026.austin.hp.com (Postfix) with ESMTP id 47338C07C; Sun, 29 Mar 2009 16:54:44 +0000 (UTC) Received: from localhost.localdomain (lart.fc.hp.com [15.11.146.31]) by smtp1.fc.hp.com (Postfix) with ESMTP id 46EA32365B7; Sun, 29 Mar 2009 16:25:24 +0000 (UTC) Received: from bob.kio (localhost [127.0.0.1]) by localhost.localdomain (Postfix) with ESMTP id 140B726145; Sun, 29 Mar 2009 10:54:44 -0600 (MDT) Subject: [PATCH 1/3] PCI: allow PCI core hotplug to remove PCI root bus To: jbarnes@virtuousgeek.org From: Alex Chiang Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 29 Mar 2009 10:54:44 -0600 Message-ID: <20090329165444.29073.36246.stgit@bob.kio> In-Reply-To: <20090329165352.29073.5159.stgit@bob.kio> References: <20090329165352.29073.5159.stgit@bob.kio> User-Agent: StGit/0.14.3.347.g594a MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org There is no reason to prevent root bus removal. We never actually remove the node from the pci_root_buses list, so a rescan will correctly rediscover the root bus. Signed-off-by: Alex Chiang --- drivers/pci/pci-sysfs.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index e9a8706..7b2cb27 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -277,14 +277,10 @@ remove_store(struct device *dev, struct device_attribute *dummy, { int ret = 0; unsigned long val; - struct pci_dev *pdev = to_pci_dev(dev); if (strict_strtoul(buf, 0, &val) < 0) return -EINVAL; - if (pci_is_root_bus(pdev->bus)) - return -EBUSY; - /* An attribute cannot be unregistered by one of its own methods, * so we have to use this roundabout approach. */