From patchwork Thu Apr 30 22:20:11 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 21256 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3UMVaNM010551 for ; Thu, 30 Apr 2009 22:31:36 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762928AbZD3WaA (ORCPT ); Thu, 30 Apr 2009 18:30:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757103AbZD3W3i (ORCPT ); Thu, 30 Apr 2009 18:29:38 -0400 Received: from kroah.org ([198.145.64.141]:55447 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755498AbZD3W3h (ORCPT ); Thu, 30 Apr 2009 18:29:37 -0400 Received: from localhost (c-76-105-230-205.hsd1.or.comcast.net [76.105.230.205]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by coco.kroah.org (Postfix) with ESMTPSA id E26F3490F5; Thu, 30 Apr 2009 15:29:37 -0700 (PDT) Date: Thu, 30 Apr 2009 15:20:11 -0700 From: Greg Kroah-Hartman To: Jesse Barnes Cc: linux-pci@vger.kernel.org, Greg KH Subject: [PATCH] PCIE: remove driver_data direct access of struct device Message-ID: <20090430222011.GA18572@kroah.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Greg Kroah-Hartman In the near future, the driver core is going to not allow direct access to the driver_data pointer in struct device. Instead, the functions dev_get_drvdata() and dev_set_drvdata() should be used. These functions have been around since the beginning, so are backwards compatible with all older kernel versions. Cc: linux-pci@vger.kernel.org Cc: Jesse Barnes Signed-off-by: Greg Kroah-Hartman --- drivers/pci/pcie/portdrv_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/pci/pcie/portdrv_core.c +++ b/drivers/pci/pcie/portdrv_core.c @@ -275,7 +275,7 @@ static void pcie_device_init(struct pci_ memset(device, 0, sizeof(struct device)); device->bus = &pcie_port_bus_type; device->driver = NULL; - device->driver_data = NULL; + dev_set_drvdata(device, NULL); device->release = release_pcie_device; /* callback to free pcie dev */ dev_set_name(device, "%s:pcie%02x", pci_name(parent), get_descriptor_id(port_type, service_type));