From patchwork Wed Aug 26 23:20:41 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 44143 X-Patchwork-Delegate: bhelgaas@google.com Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n7QNKYZH005558 for ; Wed, 26 Aug 2009 23:20:39 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753498AbZHZXUg (ORCPT ); Wed, 26 Aug 2009 19:20:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753426AbZHZXUg (ORCPT ); Wed, 26 Aug 2009 19:20:36 -0400 Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:43892 "EHLO g5t0006.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753498AbZHZXUf (ORCPT ); Wed, 26 Aug 2009 19:20:35 -0400 Received: from g1t0039.austin.hp.com (g1t0039.austin.hp.com [16.236.32.45]) by g5t0006.atlanta.hp.com (Postfix) with ESMTP id CBBCDC162; Wed, 26 Aug 2009 23:20:37 +0000 (UTC) Received: from ldl (linux.corp.hp.com [15.11.146.101]) by g1t0039.austin.hp.com (Postfix) with ESMTP id 8F77A340AF; Wed, 26 Aug 2009 23:20:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ldl (Postfix) with ESMTP id 72EF9CF001B; Wed, 26 Aug 2009 17:20:37 -0600 (MDT) Received: from ldl ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zibwChlxG3ru; Wed, 26 Aug 2009 17:20:37 -0600 (MDT) Received: from eh.fc.hp.com (eh.fc.hp.com [15.11.146.105]) by ldl (Postfix) with ESMTP id 5F09ACF000E; Wed, 26 Aug 2009 17:20:37 -0600 (MDT) Received: from bob.kio (localhost [127.0.0.1]) by eh.fc.hp.com (Postfix) with ESMTP id 3654426142; Wed, 26 Aug 2009 17:20:41 -0600 (MDT) Subject: [PATCH 1/8] PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation To: Kristen Carlson Accardi From: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, Gary Hade , Kenji Kaneshige Date: Wed, 26 Aug 2009 17:20:41 -0600 Message-ID: <20090826232041.20840.71666.stgit@bob.kio> In-Reply-To: <20090826231949.20840.99949.stgit@bob.kio> References: <20090826231949.20840.99949.stgit@bob.kio> User-Agent: StGit/0.14.3.386.gb02d MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org decode_hpp() looks up hotplug PCI parameters from ACPI and saves them in the acpiphp_bridge structure. These parameters (in bridge->hpp) are only used by the acpiphp_set_hpp_values() -> program_hpp() path. In that path, we always call decode_hpp() before program_hpp(), so there's no need to do it in init_bridge_misc(). Signed-off-by: Bjorn Helgaas Reviewed-by: Alex Chiang --- drivers/pci/hotplug/acpiphp_glue.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 0cb0f83..d2f4ce1 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c @@ -303,9 +303,6 @@ static void init_bridge_misc(struct acpiphp_bridge *bridge) { acpi_status status; - /* decode ACPI 2.0 _HPP (hot plug parameters) */ - decode_hpp(bridge); - /* must be added to the list prior to calling register_slot */ list_add(&bridge->list, &bridge_list);