diff mbox

[v4,1/8] PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation

Message ID 20090914223505.29102.94744.stgit@bob.kio
State Accepted, archived
Headers show

Commit Message

Bjorn Helgaas Sept. 14, 2009, 10:35 p.m. UTC
decode_hpp() looks up hotplug PCI parameters from ACPI and saves them
in the acpiphp_bridge structure.  These parameters (in bridge->hpp) are
only used by the acpiphp_set_hpp_values() -> program_hpp() path.  In
that path, we always call decode_hpp() before program_hpp(), so there's
no need to do it in init_bridge_misc().

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Reviewed-by: Alex Chiang <achiang@hp.com>
Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Acked-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
 drivers/pci/hotplug/acpiphp_glue.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox


diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
index 680c336..e062337 100644
--- a/drivers/pci/hotplug/acpiphp_glue.c
+++ b/drivers/pci/hotplug/acpiphp_glue.c
@@ -300,9 +300,6 @@  static void init_bridge_misc(struct acpiphp_bridge *bridge)
 	acpi_status status;
-	/* decode ACPI 2.0 _HPP (hot plug parameters) */
-	decode_hpp(bridge);
 	/* must be added to the list prior to calling register_slot */
 	list_add(&bridge->list, &bridge_list);