From patchwork Mon Sep 14 22:35:05 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 47527 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n8EMYuNI005846 for ; Mon, 14 Sep 2009 22:35:00 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757426AbZINWe4 (ORCPT ); Mon, 14 Sep 2009 18:34:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757441AbZINWe4 (ORCPT ); Mon, 14 Sep 2009 18:34:56 -0400 Received: from g5t0009.atlanta.hp.com ([15.192.0.46]:28015 "EHLO g5t0009.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757426AbZINWez (ORCPT ); Mon, 14 Sep 2009 18:34:55 -0400 Received: from g5t0029.atlanta.hp.com (g5t0029.atlanta.hp.com [16.228.8.141]) by g5t0009.atlanta.hp.com (Postfix) with ESMTP id 3704630057; Mon, 14 Sep 2009 22:34:59 +0000 (UTC) Received: from ldl (linux.corp.hp.com [15.11.146.101]) by g5t0029.atlanta.hp.com (Postfix) with ESMTP id 0B688103BA; Mon, 14 Sep 2009 22:34:59 +0000 (UTC) Received: from localhost (ldl.fc.hp.com [127.0.0.1]) by ldl (Postfix) with ESMTP id CCC20CF0012; Mon, 14 Sep 2009 16:34:58 -0600 (MDT) Received: from ldl ([127.0.0.1]) by localhost (ldl.fc.hp.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YInYTiLjSOoZ; Mon, 14 Sep 2009 16:34:58 -0600 (MDT) Received: from eh.fc.hp.com (eh.fc.hp.com [15.11.146.105]) by ldl (Postfix) with ESMTP id B666BCF0010; Mon, 14 Sep 2009 16:34:58 -0600 (MDT) Received: from bob.kio (localhost [127.0.0.1]) by eh.fc.hp.com (Postfix) with ESMTP id 3352026157; Mon, 14 Sep 2009 16:35:05 -0600 (MDT) Subject: [PATCH v4 1/8] PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation To: Jesse Barnes From: Bjorn Helgaas Cc: Alex Chiang , linux-pci@vger.kernel.org, Gary Hade , Kenji Kaneshige , Rolf Eike Beer , Kristen Carlson Accardi Date: Mon, 14 Sep 2009 16:35:05 -0600 Message-ID: <20090914223505.29102.94744.stgit@bob.kio> In-Reply-To: <20090914223304.29102.85232.stgit@bob.kio> References: <20090914223304.29102.85232.stgit@bob.kio> User-Agent: StGit/0.14.3.386.gb02d MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org decode_hpp() looks up hotplug PCI parameters from ACPI and saves them in the acpiphp_bridge structure. These parameters (in bridge->hpp) are only used by the acpiphp_set_hpp_values() -> program_hpp() path. In that path, we always call decode_hpp() before program_hpp(), so there's no need to do it in init_bridge_misc(). Signed-off-by: Bjorn Helgaas Reviewed-by: Alex Chiang Reviewed-by: Kenji Kaneshige Acked-by: Kenji Kaneshige --- drivers/pci/hotplug/acpiphp_glue.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 680c336..e062337 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c @@ -300,9 +300,6 @@ static void init_bridge_misc(struct acpiphp_bridge *bridge) { acpi_status status; - /* decode ACPI 2.0 _HPP (hot plug parameters) */ - decode_hpp(bridge); - /* must be added to the list prior to calling register_slot */ list_add(&bridge->list, &bridge_list);