From patchwork Fri Sep 17 22:32:12 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 189182 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o8HMWD92002873 for ; Fri, 17 Sep 2010 22:32:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755131Ab0IQWcP (ORCPT ); Fri, 17 Sep 2010 18:32:15 -0400 Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:43401 "EHLO g5t0006.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754272Ab0IQWcO (ORCPT ); Fri, 17 Sep 2010 18:32:14 -0400 Received: from g5t0029.atlanta.hp.com (g5t0029.atlanta.hp.com [16.228.8.141]) by g5t0006.atlanta.hp.com (Postfix) with ESMTP id 9DCCDC1A1; Fri, 17 Sep 2010 22:32:13 +0000 (UTC) Received: from ldl (ldl.fc.hp.com [15.11.146.30]) by g5t0029.atlanta.hp.com (Postfix) with ESMTP id 023C020076; Fri, 17 Sep 2010 22:32:13 +0000 (UTC) Received: from localhost (ldl.fc.hp.com [127.0.0.1]) by ldl (Postfix) with ESMTP id C7782CF004E; Fri, 17 Sep 2010 16:32:12 -0600 (MDT) Received: from ldl ([127.0.0.1]) by localhost (ldl.fc.hp.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vz-+iwNWJC7K; Fri, 17 Sep 2010 16:32:12 -0600 (MDT) Received: from eh.fc.hp.com (eh.fc.hp.com [15.11.146.105]) by ldl (Postfix) with ESMTP id AE388CF004A; Fri, 17 Sep 2010 16:32:12 -0600 (MDT) Received: from bob.kio (localhost [127.0.0.1]) by eh.fc.hp.com (Postfix) with ESMTP id 3D14B2618A; Fri, 17 Sep 2010 16:32:12 -0600 (MDT) Subject: [PATCH v2 1/4] resources: ensure alignment callback doesn't allocate below available start To: Jesse Barnes From: Bjorn Helgaas Cc: Brian Bloniarz , Charles Butterfield , Denys Vlasenko , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Becker , "H. Peter Anvin" , Yinghai Lu , Thomas Gleixner , Linus Torvalds , Ingo Molnar Date: Fri, 17 Sep 2010 16:32:12 -0600 Message-ID: <20100917223212.24687.3519.stgit@bob.kio> In-Reply-To: <20100917223109.24687.17697.stgit@bob.kio> References: <20100917223109.24687.17697.stgit@bob.kio> User-Agent: StGit/0.15 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Fri, 17 Sep 2010 22:32:15 +0000 (UTC) diff --git a/kernel/resource.c b/kernel/resource.c index 7b36976..ace2269 100644 --- a/kernel/resource.c +++ b/kernel/resource.c @@ -371,6 +371,7 @@ static int find_resource(struct resource *root, struct resource *new, { struct resource *this = root->child; struct resource tmp = *new; + resource_size_t start; tmp.start = root->start; /* @@ -391,8 +392,13 @@ static int find_resource(struct resource *root, struct resource *new, if (tmp.end > max) tmp.end = max; tmp.start = ALIGN(tmp.start, align); - if (alignf) - tmp.start = alignf(alignf_data, &tmp, size, align); + if (alignf) { + start = alignf(alignf_data, &tmp, size, align); + if (tmp.start <= start && start <= tmp.end) + tmp.start = start; + else + tmp.start = tmp.end; + } if (tmp.start < tmp.end && tmp.end - tmp.start >= size - 1) { new->start = tmp.start; new->end = tmp.start + size - 1;