From patchwork Thu Sep 1 20:09:30 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesse Barnes X-Patchwork-Id: 1120492 X-Patchwork-Delegate: bhelgaas@google.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p81K5ixu015273 for ; Thu, 1 Sep 2011 20:09:47 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756110Ab1IAUJq (ORCPT ); Thu, 1 Sep 2011 16:09:46 -0400 Received: from oproxy6-pub.bluehost.com ([67.222.54.6]:58099 "HELO oproxy6-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752695Ab1IAUJp (ORCPT ); Thu, 1 Sep 2011 16:09:45 -0400 Received: (qmail 24637 invoked by uid 0); 1 Sep 2011 20:09:44 -0000 Received: from unknown (HELO box514.bluehost.com) (74.220.219.114) by cpoproxy3.bluehost.com with SMTP; 1 Sep 2011 20:09:44 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuousgeek.org; s=default; h=Content-Type:Mime-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=tWd4TlLb+2GKqEG5KbNV5a4B4s8RmACWn7jQYV7fTW8=; b=lYHdEsZdAO/fwbQR56nMHCTOMkQu2JElfZVLo9woI+cDYfgSJrcG9urqx2wHHaPSEnML7meeP3mTi4xZ4VnmnSHP+PZ9S8hvNiWW7CzbdSoFrtugACA/K9BorUjcTMhH; Received: from c-67-161-37-189.hsd1.ca.comcast.net ([67.161.37.189] helo=jbarnes-desktop) by box514.bluehost.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1QzDa0-0003LX-QU; Thu, 01 Sep 2011 14:09:41 -0600 Date: Thu, 1 Sep 2011 13:09:30 -0700 From: Jesse Barnes To: scameron@beardog.cce.hp.com Cc: Eric Dumazet , scameron@beardog.cce.hp.com, Jon Mason , Jesse Barnes , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, stephenmcameron@gmail.com, thenzl@redhat.com, akpm@linux-foundation.org, mikem@beardog.cce.hp.com, linux-pci@vger.kernel.org, Roland Dreier , James Bottomley Subject: Re: [BUG] scsi: hpsa: how to destroy your files Message-ID: <20110901130930.5caec2d4@jbarnes-desktop> In-Reply-To: <20110901200349.GO9189@beardog.cce.hp.com> References: <20110721181605.31672.36250.stgit@beardog.cce.hp.com> <1314890642.2823.27.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20110901160724.GN9189@beardog.cce.hp.com> <1314898815.2823.33.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <1314903038.3067.27.camel@dabdike> <20110901125938.7cb1da85@jbarnes-desktop> <20110901200349.GO9189@beardog.cce.hp.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.0; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Identified-User: {10642:box514.bluehost.com:virtuous:virtuousgeek.org} {sentby:smtp auth 67.161.37.189 authed with jbarnes@virtuousgeek.org} Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 01 Sep 2011 20:09:47 +0000 (UTC) On Thu, 1 Sep 2011 15:03:49 -0500 scameron@beardog.cce.hp.com wrote: > On Thu, Sep 01, 2011 at 12:59:38PM -0700, Jesse Barnes wrote: > > On Thu, 01 Sep 2011 11:50:38 -0700 > > James Bottomley wrote: > > > > > On Thu, 2011-09-01 at 10:58 -0700, Roland Dreier wrote: > > > > > OK I found the bad commit,I got lucky... I lost some files but my > > > > > machine was able to complete the bisection. CC involved people > > > > > > > > > # bad: [b03e7495a862b028294f59fc87286d6d78ee7fa1] PCI: Set PCI-E Max Payload Size on fabric > > > > > > > > Hi Eric, > > > > > > > > I guess it would be useful to see "lspci -vv" output with a "good" kernel > > > > and with that bad patch applied. Most likely we should see some difference > > > > somewhere in the MaxPayload fields in the PCI Express capability of > > > > some device. > > > > > > > > Either the RAID controller or something else lies, and puts a value > > > > in the DevCap that it can't actually support, or else the patch is > > > > buggy and puts something out of range in a DevCtl somewhere. > > > > > > > > > While we investigate, I think the problems produced by the patch (data > > > corruption) are serious enough to warrant reverting it, please Jesse. > > > > Hm I haven't been paying attention to the compromise thread; how should > > I share these changes? Is master.kernel.org down indefinitely? Is > > there a new server at kernel.org I can use? > > I can't answer that question, but I would like a copy of your revert > patch(es) to test (as a simple patch --reverse of the original commit on the 3.1-rc4 > tree didn't go in cleanly). Attached is the series. Applies on top of my for-linus branch. From 7ec72e08c43fbf698e62eac1d509cfe8238c0b25 Mon Sep 17 00:00:00 2001 From: Jesse Barnes Date: Thu, 1 Sep 2011 12:32:55 -0700 Subject: [PATCH 1/3] PCI: Revert "pci: fix new kernel-doc warning in pci.c" This reverts commit 47c08f3107270e5a439bc0106a308f7c48c9621d, a comment fix up for the next revert. Signed-off-by: Jesse Barnes --- drivers/pci/pci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 0ce6742..466fad6 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3250,7 +3250,7 @@ int pcie_get_mps(struct pci_dev *dev) /** * pcie_set_mps - set PCI Express maximum payload size * @dev: PCI device to query - * @mps: maximum payload size in bytes + * @rq: maximum payload size in bytes * valid values are 128, 256, 512, 1024, 2048, 4096 * * If possible sets maximum payload size -- 1.7.1