diff mbox

[-v2,5/8] MIPS/PCI: Move final fixup quirks from __init to __devinit

Message ID 20120709213627.8975.4902.stgit@amt.stowe (mailing list archive)
State New, archived
Headers show

Commit Message

Myron Stowe July 9, 2012, 9:36 p.m. UTC
The PCI subsystem's final fixups are executed once during boot, after the
pci-device is found.  As long as the system does not support hot-plug,
specifying __init is fine.

With hot-plug, either physically based hot-plug events or pseudo hot-plug
events such as "echo 1 > /sys/bus/pci/rescan", it is possible to remove a
PCI bus during run time and have it rediscovered which will require the
call of the fixups again in order for the device to function properly.

This patch prepares specific quirk(s) for use with hot-plug events.

Signed-off-by: Myron Stowe <myron.stowe@redhat.com>

 arch/mips/mti-malta/malta-pci.c |    2 +-
 arch/mips/pci/ops-tx4927.c      |    2 +-
 arch/mips/txx9/generic/pci.c    |    4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox


diff --git a/arch/mips/mti-malta/malta-pci.c b/arch/mips/mti-malta/malta-pci.c
index bf80921..b663402 100644
--- a/arch/mips/mti-malta/malta-pci.c
+++ b/arch/mips/mti-malta/malta-pci.c
@@ -253,7 +253,7 @@  void __init mips_pcibios_init(void)
 /* Enable PCI 2.1 compatibility in PIIX4 */
-static void __init quirk_dlcsetup(struct pci_dev *dev)
+static void __devinit quirk_dlcsetup(struct pci_dev *dev)
 	u8 odlc, ndlc;
 	(void) pci_read_config_byte(dev, 0x82, &odlc);
diff --git a/arch/mips/pci/ops-tx4927.c b/arch/mips/pci/ops-tx4927.c
index a1e7e6d..bc13e29 100644
--- a/arch/mips/pci/ops-tx4927.c
+++ b/arch/mips/pci/ops-tx4927.c
@@ -495,7 +495,7 @@  irqreturn_t tx4927_pcierr_interrupt(int irq, void *dev_id)
-static void __init tx4927_quirk_slc90e66_bridge(struct pci_dev *dev)
+static void __devinit tx4927_quirk_slc90e66_bridge(struct pci_dev *dev)
 	struct tx4927_pcic_reg __iomem *pcicptr = pci_bus_to_pcicptr(dev->bus);
diff --git a/arch/mips/txx9/generic/pci.c b/arch/mips/txx9/generic/pci.c
index 682efb0..ce1ee50 100644
--- a/arch/mips/txx9/generic/pci.c
+++ b/arch/mips/txx9/generic/pci.c
@@ -256,7 +256,7 @@  static irqreturn_t i8259_interrupt(int irq, void *dev_id)
 	return IRQ_HANDLED;
-static int __init
+static int __devinit
 txx9_i8259_irq_setup(int irq)
 	int err;
@@ -269,7 +269,7 @@  txx9_i8259_irq_setup(int irq)
 	return err;
-static void __init quirk_slc90e66_bridge(struct pci_dev *dev)
+static void __devinit quirk_slc90e66_bridge(struct pci_dev *dev)
 	int irq;	/* PCI/ISA Bridge interrupt */
 	u8 reg_64;