From patchwork Mon Apr 22 23:12:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 2474951 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id DAB683FD40 for ; Mon, 22 Apr 2013 23:12:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752708Ab3DVXMY (ORCPT ); Mon, 22 Apr 2013 19:12:24 -0400 Received: from mail-ia0-f178.google.com ([209.85.210.178]:34486 "EHLO mail-ia0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753761Ab3DVXMX (ORCPT ); Mon, 22 Apr 2013 19:12:23 -0400 Received: by mail-ia0-f178.google.com with SMTP id j38so8986iad.37 for ; Mon, 22 Apr 2013 16:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=VL1PsEoZtSX1X3ybDiAzvU6xQGWVd5dWi3FOB5UyAjg=; b=JSvXZ7Gxe1NQev6i5ivtt0rP7VLLvjwo/ZJ/Pj2dAYqxhbCh/GAaHftBj54o+UZ7Dt fH6wa4wiBde1x08yAvBHR8nWrV5IJTSVwJi3JS+ZPuXqlWMExtuyldFP+to8UWqb1f2Q EqfpohSsFD3v5KNzpYgPESbHHOi0f2MDDlloqD+SNefW206XQCaofD5+u3E3zVS3qqmi KvUxe8+ffevNsszevFuLVIYmeTYDOdWHCr/gpZHzpymQ45hnMROMLqtwQQ8MV9/4hjhA IsRxCswhDbF7vCJclw5bP22G7Em5hKiOHN9WhHJpydMFwiw0L5GKgJHb8M2v94voZaLs AW8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding:x-gm-message-state; bh=VL1PsEoZtSX1X3ybDiAzvU6xQGWVd5dWi3FOB5UyAjg=; b=nDSSZoPk5XnYWonY+3Ms2tArUXzNXV2UMQkxmeyU8yK1i0Fp37EP6tEJyxy8vXOK8v wKxMJWgNuFAvPlyx2M8mEnINpDygw2hv5A7SY+UycExwCX9nA5urD/FMwK3qKq+/jy1d 2xtk0l6I53EPDxGR2FeAoQG4vQPgh1zotikz6bzj7dcRyJLuWePXHQt5Mor10mM6kC3L c9AKKLadf1INTr+sRo6jfqWH24ZW5Mw9Q9Y/nu6UiVw1hDaqJ2XHOJ131sFJmQGPLCSV OgPX7uzQFY8obaVEtX/mJcZKkPcidiRPGlGjQQxcms8fiR4wEp7gK5VHsgtCOhe1IcwS ezvQ== X-Received: by 10.42.159.70 with SMTP id k6mr13830994icx.28.1366672343497; Mon, 22 Apr 2013 16:12:23 -0700 (PDT) Received: from localhost ([172.29.120.215]) by mx.google.com with ESMTPSA id w8sm17864437igl.9.2013.04.22.16.12.22 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 22 Apr 2013 16:12:23 -0700 (PDT) Subject: [PATCH v4 19/22] xen/pci: Use PCI_MSIX_TABLE_BIR, not PCI_MSIX_FLAGS_BIRMASK To: linux-pci@vger.kernel.org From: Bjorn Helgaas Cc: Gavin Shan , Konrad Rzeszutek Wilk Date: Mon, 22 Apr 2013 17:12:21 -0600 Message-ID: <20130422231221.32621.95466.stgit@bhelgaas-glaptop> In-Reply-To: <20130422230012.32621.15224.stgit@bhelgaas-glaptop> References: <20130422230012.32621.15224.stgit@bhelgaas-glaptop> User-Agent: StGit/0.15 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQn3Aj5OhY2Mt7vmCViouy+pS2uom+/B7wQjk3QDu3IWDUN3uMvmk3bqFIxcR0qgDtIbZWd460yinE/AYTfjBbiazgrbWRGfv8Shysl5iOjvvYZ5bazPXhMfDKQv5MhkIZIOMQZi9ZJBKlW/miklTgiI43WDIFsHPPaFmEnoCqrNI83wNN+OW2BYY8wGxuE5VOtytU5OMLC29ScnYIqU5WChDF8K4Mi/PA6dAoeEyCHp0etp0TI= Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org PCI_MSIX_FLAGS_BIRMASK is mis-named because the BIR mask is in the Table Offset register, not the flags ("Message Control" per spec) register. Signed-off-by: Bjorn Helgaas CC: Konrad Rzeszutek Wilk --- arch/x86/pci/xen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index 0e8a196..b9d1ff2 100644 --- a/arch/x86/pci/xen.c +++ b/arch/x86/pci/xen.c @@ -299,7 +299,7 @@ static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) pci_read_config_dword(dev, pos + PCI_MSIX_TABLE, &table_offset); - bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK); + bir = (u8)(table_offset & PCI_MSIX_TABLE_BIR); table_offset &= PCI_MSIX_TABLE_OFFSET; map_irq.table_base = pci_resource_start(dev, bir) +