From patchwork Mon Aug 5 08:39:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Marek X-Patchwork-Id: 2838588 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 706609F3B9 for ; Mon, 5 Aug 2013 08:39:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 71EE82017C for ; Mon, 5 Aug 2013 08:39:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 630322018D for ; Mon, 5 Aug 2013 08:39:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754751Ab3HEIjs (ORCPT ); Mon, 5 Aug 2013 04:39:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43344 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754541Ab3HEIjr (ORCPT ); Mon, 5 Aug 2013 04:39:47 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D4DBAA5388; Mon, 5 Aug 2013 10:39:45 +0200 (CEST) Received: by sepie.suse.cz (Postfix, from userid 10020) id AF4DA7640B; Mon, 5 Aug 2013 10:39:43 +0200 (CEST) Date: Mon, 5 Aug 2013 10:39:43 +0200 From: Michal Marek To: Linus Torvalds Cc: Bjorn Helgaas , "linux-pci@vger.kernel.org" , Linux Kernel Mailing List , Yinghai Lu , Thomas Petazzoni , Benjamin Herrenschmidt , "Yann E. MORIN" , linux-kbuild Subject: Warnings from silentoldconfig (Re: [GIT PULL] PCI updates for v3.11) Message-ID: <20130805083943.GA14782@sepie.suse.cz> References: <20130802181740.GA27100@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Aug 02, 2013 at 01:28:25PM -0700, Linus Torvalds wrote: > On Fri, Aug 2, 2013 at 11:17 AM, Bjorn Helgaas wrote: > > > > Yinghai is still working on another SR-IOV-related fix or two, which > > will be simpler if pciehp is non-modular, so I included the Kconfig > > changes now to get them in earlier. > > Hmm. Doing a trivial "make allmoconfig" for testing, I get > > include/config/auto.conf:3014:warning: symbol value 'm' invalid for > HOTPLUG_PCI_PCIE > include/config/auto.conf:4711:warning: symbol value 'm' invalid for > HOTPLUG_PCI > > but that may be a build system issue with stale data from the > *previous* "make allmodconfig". Regardless, that makes me worried. > > Adding Michal Marek to the discussion. I'm currently doing a new "make > allmodconfig" after having done a "git clean -dqfx" to see if the > error remains. If it does, I will unpull. If it is gone, I'm going to > assume the Kconfig changes are ok, but that our build system is > missing some dependency. Added Yann and the linux-kbuild list to CC. Reproducer: git checkout 1fe0135 make mrproper make allmodconfig make silentoldconfig git checkout aa8032b make allmodconfig make silentoldconfig conf_write_autoconf() first calls conf_split_config() to generate the include/config/**.h hierarchy, then generates include/config/auto.conf. For some reason, conf_split_config() reads include/config/auto.conf, which may not exist yet or may be out of date. Yann, can anything break if we simply do not read that file from conf_split_config(), like this? Thanks, Michal --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index c55c227..8c90835 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -829,16 +829,12 @@ next: static int conf_split_config(void) { - const char *name; char path[PATH_MAX+1]; char *s, *d, c; struct symbol *sym; struct stat sb; int res, i, fd; - name = conf_get_autoconfig_name(); - conf_read_simple(name, S_DEF_AUTO); - if (chdir("include/config")) return 1;