From patchwork Wed Aug 28 19:27:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 2850954 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 36608BF546 for ; Wed, 28 Aug 2013 19:27:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 452862044A for ; Wed, 28 Aug 2013 19:27:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D3FB203FD for ; Wed, 28 Aug 2013 19:27:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753783Ab3H1T11 (ORCPT ); Wed, 28 Aug 2013 15:27:27 -0400 Received: from mail-yh0-f51.google.com ([209.85.213.51]:37081 "EHLO mail-yh0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753092Ab3H1T11 (ORCPT ); Wed, 28 Aug 2013 15:27:27 -0400 Received: by mail-yh0-f51.google.com with SMTP id c41so1755166yho.38 for ; Wed, 28 Aug 2013 12:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=V2WLg/DbgRExH2a9SZid1ojAmE+J+yPNy/M6EWCzHBM=; b=oqlcQn/LsKdAv/XBciyJKeuf7Uf7bC7rb4jJL2Y9I1N+DIAbJnmjABkpyt+jVXNSV8 7kY1QXpxNe3HeO/O2FzVb8jwIDE00eMZrKwiNHobM+67v4LIYka07vdjtMd46MjWWAli 84BTgJ+LIoKvdi6oAIitVJ+qg7ioHcJnd0OeRyKWA7UQ+VethRDX2o25tOn5DsjwmCYZ q7B+sg4cMD8WYWPPyq0XG52tOHiY639egkj8/KMXdHaS1SG80TZJz5E7MinUCPJ5dDA/ K73+B8EhroZgnd/Fo1kH+xdjFtKcWdId910B8kz1oIdC3bKjqzfMYPKVsSrtU66u+VvK 4CaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=V2WLg/DbgRExH2a9SZid1ojAmE+J+yPNy/M6EWCzHBM=; b=puH4wjouXm1a7BEW571Y57FBE8kPmBgQGX5VjzzIEGrGsFPlnSW3kwAm4fqZrl8ptt FEh3Qv4Wxnb2tEr3lQbAgpBbzzWMc6nB8MkBillivwovjj7AyFGrgndMeGBH9er46aUw AWQIUGVeGU/AyFZIlDx59cKyIM4yklY+yjzX5auixL4hlx91B8ecZhG4z+uKdPeQEyll WPEegb2qLnoYtnNfvWy7eQYk2IGgkqJ14XsA4jXyeH2WhVT50ZmNXsr0A9tP1nX6OsET e7olF1JG2cJ01PZJV4yYomC4L9MNdjx+DVw1uTUxCMxH1Jqzml44xVEv1sS/XEpwsuxE oGOQ== X-Gm-Message-State: ALoCoQk+1eC1tvuQBmL6/hUe928f/xMP3V1Ep5w2bcz5WeyQ3aHqFdBYZnnrgOCN3DokJ5Nq/S4QCpPRt+fZctylM2nlBKSeE5QESFZ83i6aQOwLl/nNqUs4hNorsKJSbCSpReUhx5iodke7/7+FTFHLoCZZMjflTHKUkAFABaWEVFUWGWlHLbjQ1dlqy1OXPWtjCRoZKerA1ie2inDgypooDWnbSFKa19xINXwWnf5H8/WHLP2SRds= X-Received: by 10.236.60.137 with SMTP id u9mr1995836yhc.71.1377718046691; Wed, 28 Aug 2013 12:27:26 -0700 (PDT) Received: from localhost ([172.16.52.7]) by mx.google.com with ESMTPSA id c6sm33503708yhl.22.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 28 Aug 2013 12:27:26 -0700 (PDT) Subject: [PATCH 4/4] PCI: Remove pcie_cap_has_devctl() To: linux-pci@vger.kernel.org From: Bjorn Helgaas Cc: Yuval Mintz , Jacob Keller , Jiang Liu , Jiang Liu Date: Wed, 28 Aug 2013 13:27:23 -0600 Message-ID: <20130828192723.5895.68711.stgit@bhelgaas-glaptop> In-Reply-To: <20130828192627.5895.26558.stgit@bhelgaas-glaptop> References: <20130828192627.5895.26558.stgit@bhelgaas-glaptop> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pcie_cap_has_devctl() does nothing, so remove it. Simplicity over consistency in this case. No functional change. Signed-off-by: Bjorn Helgaas --- drivers/pci/access.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 061da8c..0857ca9 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -475,11 +475,6 @@ static inline int pcie_cap_version(const struct pci_dev *dev) return pcie_caps_reg(dev) & PCI_EXP_FLAGS_VERS; } -static inline bool pcie_cap_has_devctl(const struct pci_dev *dev) -{ - return true; -} - static inline bool pcie_cap_has_lnkctl(const struct pci_dev *dev) { int type = pci_pcie_type(dev); @@ -521,7 +516,7 @@ static bool pcie_capability_reg_implemented(struct pci_dev *dev, int pos) case PCI_EXP_DEVCAP: case PCI_EXP_DEVCTL: case PCI_EXP_DEVSTA: - return pcie_cap_has_devctl(dev); + return true; case PCI_EXP_LNKCAP: case PCI_EXP_LNKCTL: case PCI_EXP_LNKSTA: