From patchwork Sat Jan 11 01:27:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 3468761 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 66AC0C02DD for ; Sat, 11 Jan 2014 01:28:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A9D4320142 for ; Sat, 11 Jan 2014 01:28:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E05EA2013A for ; Sat, 11 Jan 2014 01:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751449AbaAKB1i (ORCPT ); Fri, 10 Jan 2014 20:27:38 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:60042 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbaAKB1h (ORCPT ); Fri, 10 Jan 2014 20:27:37 -0500 Received: by mail-pa0-f44.google.com with SMTP id fa1so5497848pad.3 for ; Fri, 10 Jan 2014 17:27:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=hEGLkATfFLGz0IkG898Nm3tqOts5FPl0FebmbTPd51s=; b=nk37XNO5tCRj6f414UyqC2Uh4XUzV04eHjnRXLwj/PHKO8f2Gy2DFSqjLO8bQek+mJ u8bBvhQj9WB/gZ0i3UuSPcxv650nAWoqU3Y9YPlj033wBSIEC33HPYfngHIdEvxFopPR /wohmKb2tW6XmHgvST1Jo2EiKIzefTVLW38Ju/QUsE9QLmY8HGfCZxfMTSASyo/heKb4 rrm20NwH8stq4f0clhHytgQWKGiC/F7VT2Jfg3RYGBC/bhcvcZF2Jhd+YdSod2Dvyw3Y qNdUgDdJNlj5REk+hPQPtNL3cBk5+DmOmR+YgSgv/nGmuGFwBRlsg5iMvVzF5P17fp/A 64RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=hEGLkATfFLGz0IkG898Nm3tqOts5FPl0FebmbTPd51s=; b=DgE1U1ZMUvd2S3w3504Tnb0ZmnS6JTso8mlzT55AeEaXoBTQ59IK1klaX2nCi0eaB1 3oxzR/xS3OOLG0iOFtCqIvueiNwqbSegfwkk8hcd5aJfEEJ9Qudsk6HAIUDo8iBSEmWu nj2ehkOSxf0Ip5tLiGkfTbHBChVaV7Z5hAd/W3+NN7SKMbv52I2uPyfh7BNZeMDLNVgQ uwHw3r/3tt0izIWkbxwRo/yh/nh9F99VBEcy4HxLZ6LjVBAgrpdCTRh7G1K7QIyGY/2P SuNHTRCRBOX+ZXXSQ7mBosdrKSW6jjoiAWY8pHTtg9GFPvAUqPZJTEvAqpRNiNHh3mnC qyxw== X-Gm-Message-State: ALoCoQnJpbWsgw3RNY0OaVp/0Of1IDufYRKwndhOOKqZzohD6pZJTYrF6A/BBpRizu/+G5cSsDZ1FO7v5yvfOmncPhMcfwkT/DNzG+cKki4gdHiRYZPY75tnOl1CF8vZZGPWUk0t3blaWSlWcXWignOKp0DbuyVZwW5GueQT/sbzUM8AwfgZqfa8UXx3igW1N+ULbvWGkw6Gu7o0Yb2nVOeYqnxm1dJtmQ== X-Received: by 10.68.129.201 with SMTP id ny9mr15442351pbb.70.1389403657249; Fri, 10 Jan 2014 17:27:37 -0800 (PST) Received: from localhost ([172.26.52.174]) by mx.google.com with ESMTPSA id gg10sm20357437pbc.46.2014.01.10.17.27.35 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 10 Jan 2014 17:27:36 -0800 (PST) Subject: [PATCH v2 07/12] PCI: Remove unused pcie_aspm_enabled() To: Stephen Hemminger , linux-pci@vger.kernel.org From: Bjorn Helgaas Cc: Yu Zhao , Andrew Patterson Date: Fri, 10 Jan 2014 18:27:34 -0700 Message-ID: <20140111012734.14505.57102.stgit@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: <20140111012339.14505.40203.stgit@bhelgaas-glaptop.roam.corp.google.com> References: <20140111012339.14505.40203.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Stephen Hemminger My philosophy is unused code is dead code. And dead code is subject to bit rot and is a likely source of bugs. Use it or lose it. This reverts part of 3e1b16002af2 ("ACPI/PCI: PCIe ASPM _OSC support capabilities called when root bridge added"), removing this interface: pcie_aspm_enabled() [bhelgaas: split to separate patch] Signed-off-by: Stephen Hemminger Signed-off-by: Bjorn Helgaas CC: Andrew Patterson --- drivers/pci/pcie/aspm.c | 12 ------------ include/linux/pci.h | 2 -- 2 files changed, 14 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c index f1272dc54de1..e1e7026b838d 100644 --- a/drivers/pci/pcie/aspm.c +++ b/drivers/pci/pcie/aspm.c @@ -984,18 +984,6 @@ void pcie_no_aspm(void) } } -/** - * pcie_aspm_enabled - is PCIe ASPM enabled? - * - * Returns true if ASPM has not been disabled by the command-line option - * pcie_aspm=off. - **/ -int pcie_aspm_enabled(void) -{ - return !aspm_disabled; -} -EXPORT_SYMBOL(pcie_aspm_enabled); - bool pcie_aspm_support_enabled(void) { return aspm_support_enabled; diff --git a/include/linux/pci.h b/include/linux/pci.h index bf1f385bf14d..583348275085 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1198,10 +1198,8 @@ extern bool pcie_ports_auto; #endif #ifndef CONFIG_PCIEASPM -static inline int pcie_aspm_enabled(void) { return 0; } static inline bool pcie_aspm_support_enabled(void) { return false; } #else -int pcie_aspm_enabled(void); bool pcie_aspm_support_enabled(void); #endif