From patchwork Wed Feb 12 19:10:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 3640111 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BC8D09F35F for ; Wed, 12 Feb 2014 19:10:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D4BA82020A for ; Wed, 12 Feb 2014 19:10:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF63220203 for ; Wed, 12 Feb 2014 19:10:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752831AbaBLTK4 (ORCPT ); Wed, 12 Feb 2014 14:10:56 -0500 Received: from mail-ob0-f181.google.com ([209.85.214.181]:64941 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbaBLTKz (ORCPT ); Wed, 12 Feb 2014 14:10:55 -0500 Received: by mail-ob0-f181.google.com with SMTP id va2so10973105obc.40 for ; Wed, 12 Feb 2014 11:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=hcQgMhq/VYn7yKfHO2IKUAQuVTIXQzL8FKl0nKSrxoY=; b=V4mQ9J2a0DbmD89d64u2qcgsSkGYxIJMzShjLB3nyE6vOcqItgAUzlqkYeVUcel92F U9kinjUBuIZO8HvI+64q9otkw4I2K4scUkJCt2XrkVrXheAo70sMyO2lSYJYW6qn7QEV gOH5XRyd+J3qsDWGDMdTVHXTVt23aN/BmIFYvORCPX9IP5pn1rMySizVUkDXDV62JNdl QmNHmC9Ih+gZ7DEepqOucEaEAznLRbVMqaYaOOp/eA7sVdhQE338wD3iEsPnwdOQk3xk B0H0O2rzO0lVmjUt/wAx00qM+ln11FA3Jtcl3xUJNwBYsKrMVpRs/PYtvoMvOap0NeNg vE9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=hcQgMhq/VYn7yKfHO2IKUAQuVTIXQzL8FKl0nKSrxoY=; b=DUVbN+OneMoGg53YeofWlJPEuviRs0BFbN3eIgzix5s/j9SEAcK+CTAeDzBl65kEHQ sjyYkA6q1HH07TS+56wc/P0ETxsuKmzwfSo0uLDJWAdhiSwz9nUmKu6T8WluR26bauYk 1o/XHNWO49jnTDq1HMFS1KVanGbdQG3DZIh1bzY0MwOVlA2J7DLQ1NOUp1IvlefNLEmY jTGh/3oN8kJKQ9ILTecEjOI9mRpaBhTOABjYSygHx5UDXEBZcXqM5Oup4WMoTSiBzBmI gKE54wV4H7Lo7P7cOqQRju47ucDYD8fQQJgzGTL3P7Yv21359bTkpfFxQAKwGgEA45cy 5/6g== X-Gm-Message-State: ALoCoQmYlRm5klSRNJH21EULUHZ8NeDUuGyW+HdTYCqiMwXuNC5mPaFHiKrZonKyFZbXvtHtzdqPwYqNwZAT+T3iw/vWy+0IjRBnPm2KKzlAsPDCkWCX2nEjNemye39rG1aT6cn7+gXLBVdr5TWKx9ruVOKKtZ0uY80pcn26+GTubxKD/L9OCBUoZdhHUu6O6wPH2UZdVr8/P1RhHWXHNU0n3Y7UkTFVGtokijpRiLofw0U/pDMJfV8= X-Received: by 10.182.219.197 with SMTP id pq5mr1687663obc.64.1392232254867; Wed, 12 Feb 2014 11:10:54 -0800 (PST) Received: from localhost ([172.16.48.185]) by mx.google.com with ESMTPSA id lg8sm30750777obc.14.2014.02.12.11.10.54 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 12 Feb 2014 11:10:54 -0800 (PST) Subject: [PATCH 1/4] PCI: Remove unnecessary list_empty(&pci_pme_list) check To: linux-pci@vger.kernel.org From: Bjorn Helgaas Cc: "Rafael J. Wysocki" Date: Wed, 12 Feb 2014 12:10:53 -0700 Message-ID: <20140212191053.5459.95323.stgit@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: <20140212190949.5459.46330.stgit@bhelgaas-glaptop.roam.corp.google.com> References: <20140212190949.5459.46330.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP list_for_each_entry() handles empty lists just fine, so there's no need to check whether the list is empty first. No functional change. Signed-off-by: Bjorn Helgaas CC: Rafael J. Wysocki Acked-by: Rafael J. Wysocki --- drivers/pci/pci.c | 40 +++++++++++++++++++--------------------- 1 file changed, 19 insertions(+), 21 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 1febe90831b4..52e10e1181d0 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1611,29 +1611,27 @@ static void pci_pme_list_scan(struct work_struct *work) struct pci_pme_device *pme_dev, *n; mutex_lock(&pci_pme_list_mutex); - if (!list_empty(&pci_pme_list)) { - list_for_each_entry_safe(pme_dev, n, &pci_pme_list, list) { - if (pme_dev->dev->pme_poll) { - struct pci_dev *bridge; - - bridge = pme_dev->dev->bus->self; - /* - * If bridge is in low power state, the - * configuration space of subordinate devices - * may be not accessible - */ - if (bridge && bridge->current_state != PCI_D0) - continue; - pci_pme_wakeup(pme_dev->dev, NULL); - } else { - list_del(&pme_dev->list); - kfree(pme_dev); - } + list_for_each_entry_safe(pme_dev, n, &pci_pme_list, list) { + if (pme_dev->dev->pme_poll) { + struct pci_dev *bridge; + + bridge = pme_dev->dev->bus->self; + /* + * If bridge is in low power state, the + * configuration space of subordinate devices + * may be not accessible + */ + if (bridge && bridge->current_state != PCI_D0) + continue; + pci_pme_wakeup(pme_dev->dev, NULL); + } else { + list_del(&pme_dev->list); + kfree(pme_dev); } - if (!list_empty(&pci_pme_list)) - schedule_delayed_work(&pci_pme_work, - msecs_to_jiffies(PME_TIMEOUT)); } + if (!list_empty(&pci_pme_list)) + schedule_delayed_work(&pci_pme_work, + msecs_to_jiffies(PME_TIMEOUT)); mutex_unlock(&pci_pme_list_mutex); }