From patchwork Wed Feb 26 19:09:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 3727671 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DB5F59F2F7 for ; Wed, 26 Feb 2014 19:10:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2418B20204 for ; Wed, 26 Feb 2014 19:10:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D027201F9 for ; Wed, 26 Feb 2014 19:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753722AbaBZTJL (ORCPT ); Wed, 26 Feb 2014 14:09:11 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:63841 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753571AbaBZTJJ (ORCPT ); Wed, 26 Feb 2014 14:09:09 -0500 Received: by mail-ig0-f174.google.com with SMTP id h18so1452056igc.1 for ; Wed, 26 Feb 2014 11:09:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=7R+/ignm77riJaxNivq7Zjx6NK50HCpaC910HMlGW4I=; b=RAId/Dgkivt7bIQpdSrfrlNwmbyKOS8ImE9avZfYSwyp8zqT7ayMpNB0Eor5Lqwqjg lWLggQ8Zvwux94hftAiy3EPZmKhNweH0Na6gM57gJCl3sVOclPULNrEO/klLjuFGEjCO ETzToBWE5CATL4gYHqqIg6yx7To6+Jmk7hOmt0/9CWHdLtQcWq5JjxyvjoGoRiKaNJRq bVGRw7NOBQDgUG4nNMRDK0sCAftRa38bbHQdDiPleOQX1hs7iA92YUt6+MAk75HiCYlv CuMdHQ2IQu2/eug1Et4OvrgFCQnqPh+yjn2hKQpVLDtmXh6Ctjwzn8NQjAGj1CzTTcwf GZHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=7R+/ignm77riJaxNivq7Zjx6NK50HCpaC910HMlGW4I=; b=gF08vohJzsdlIhyHONrE11b6bz7X3wm+qgs1v8rge/lu/S4xsi0O332alKrJCQzVF/ iNvKmG7ijcOH87LXzORH9rJn7L/42fag0SjZ65VzLyn4OdU2fw9AAR0Zvn53K8XtlvuA edMSAEgFx+VVRXJxlg08jc5C+dAWgTSkDwX4IQe+8lCj4SEbRMW7rV/o99z6hrkOS9ZA /w2q4cIIidsSp0V+Zxpz/qaw7g361ojZYvTGUXH2GGl4SzUraoOa1fIhKKMn1UDquzKF aiOC4gwV8xeakAbcuxoG+vDSApvqF5RDk9UvxnllZgKgqtjHZb5Qzr7RhC9yZ/VcYrHB RuIg== X-Gm-Message-State: ALoCoQnTLOK/tE/yyTbhArQEafNyL3JA4Mpu0DvZPGx/D8XP5zBa+XX+z53w8R5S9eXiRJhB7d/rhmUJC5SZXu0qK9i2lX0yMbRjSl5pyhNmuAQZbTcbdstpbDvE17fmvPqQ7Dx6aSxoVQf1ncS5VIagmPXI5AxWkDbHwetTr7y0AxCNHwrBE3FdkfMD0EcSuKdhHU5ngWMdv4OsnboLGHjYQcWyiQfQs8u5GDgGWVX2a+hSQvyh4Qw= X-Received: by 10.42.139.136 with SMTP id g8mr1004931icu.96.1393441748235; Wed, 26 Feb 2014 11:09:08 -0800 (PST) Received: from localhost ([172.16.49.60]) by mx.google.com with ESMTPSA id qk2sm51995560igc.1.2014.02.26.11.09.07 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 26 Feb 2014 11:09:07 -0800 (PST) Subject: [PATCH 1/4] i2o: Fix I/O space allocation copy/paste error To: linux-pci@vger.kernel.org From: Bjorn Helgaas Cc: Markus Lidel , linux-kernel@vger.kernel.org Date: Wed, 26 Feb 2014 12:09:06 -0700 Message-ID: <20140226190906.9616.52057.stgit@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: <20140226190306.9616.30567.stgit@bhelgaas-glaptop.roam.corp.google.com> References: <20140226190306.9616.30567.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When i2o_iop_systab_set() allocates I/O port space, it assigns the base of the new I/O port region to sb->current_mem_base, not sb->current_io_base. This looks like a copy/paste error, because we do use current_io_base, but there's no other place that sets it. Signed-off-by: Bjorn Helgaas --- drivers/message/i2o/iop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/message/i2o/iop.c b/drivers/message/i2o/iop.c index a8c08f332da0..a8373d7aaef7 100644 --- a/drivers/message/i2o/iop.c +++ b/drivers/message/i2o/iop.c @@ -704,7 +704,7 @@ static int i2o_iop_systab_set(struct i2o_controller *c) NULL, NULL) >= 0) { c->io_alloc = 1; sb->current_io_size = resource_size(res); - sb->current_mem_base = res->start; + sb->current_io_base = res->start; osm_info("%s: allocated %llu bytes of PCI I/O at " "0x%016llX.\n", c->name, (unsigned long long)resource_size(res),