From patchwork Fri Aug 22 12:41:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mika Westerberg X-Patchwork-Id: 4763561 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E4EF1C0338 for ; Fri, 22 Aug 2014 12:42:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 393B82017A for ; Fri, 22 Aug 2014 12:42:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A05820127 for ; Fri, 22 Aug 2014 12:42:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756191AbaHVMl7 (ORCPT ); Fri, 22 Aug 2014 08:41:59 -0400 Received: from mga02.intel.com ([134.134.136.20]:61628 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756166AbaHVMl6 (ORCPT ); Fri, 22 Aug 2014 08:41:58 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 22 Aug 2014 05:41:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,380,1406617200"; d="scan'208";a="562119328" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.95]) by orsmga001.jf.intel.com with SMTP; 22 Aug 2014 05:41:47 -0700 Received: by lahna (sSMTP sendmail emulation); Fri, 22 Aug 2014 15:41:45 +0300 Date: Fri, 22 Aug 2014 15:41:45 +0300 From: Mika Westerberg To: Jiang Liu Cc: Benjamin Herrenschmidt , Thomas Gleixner , Grant Likely , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Bjorn Helgaas , Randy Dunlap , Yinghai Lu , x86@kernel.org, Konrad Rzeszutek Wilk , Andrew Morton , Tony Luck , Joerg Roedel , Paul Gortmaker , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, Ingo Molnar Subject: Re: [Patch V4 29/42] x86, irq: introduce two helper functions to support irqdomain map operation Message-ID: <20140822124145.GF1660@lahna.fi.intel.com> References: <1402302011-23642-1-git-send-email-jiang.liu@linux.intel.com> <1402302011-23642-30-git-send-email-jiang.liu@linux.intel.com> <20140821141729.GT1660@lahna.fi.intel.com> <20140821165728.GV1660@lahna.fi.intel.com> <53F641E0.8040401@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <53F641E0.8040401@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Aug 22, 2014 at 03:00:48AM +0800, Jiang Liu wrote: > Hi Mika, > I'm out of office until next Tuesday. Will handle this > when back to work. Could you please help to take a look at > mp_set_gsi_attr() to check whether it could be used to resolve > this issue. The problem seems to be that when we allocate the legacy 16 IRQ range, they will be set to edge-triggered and then info->set is set to 1 preventing any further configuration (if I understand that part right). I tried simply following and it seems to work. Not sure how correct it is, though. --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 29290f554e79..29c5d4fa9e86 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1531,8 +1531,7 @@ static void __init setup_IO_APIC_irqs(void) KERN_DEBUG " apic %d pin %d not connected\n", mpc_ioapic_id(ioapic), pin); else - pin_2_irq(idx, ioapic, pin, - ioapic ? 0 : IOAPIC_MAP_ALLOC); + pin_2_irq(idx, ioapic, pin, 0); } }