From patchwork Tue Sep 2 04:03:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 4822981 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AF0339F2ED for ; Tue, 2 Sep 2014 04:03:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D4CE3201BC for ; Tue, 2 Sep 2014 04:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC64E2017A for ; Tue, 2 Sep 2014 04:03:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750706AbaIBEDu (ORCPT ); Tue, 2 Sep 2014 00:03:50 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:62128 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750701AbaIBEDt (ORCPT ); Tue, 2 Sep 2014 00:03:49 -0400 Received: by mail-ie0-f182.google.com with SMTP id rd18so6962476iec.41 for ; Mon, 01 Sep 2014 21:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:user-agent:mime-version :content-type:content-transfer-encoding; bh=cg7nfadkCmH2ox4YitL41ivjydyJW5VN+2xIFi2+P/4=; b=T1ZA80goWlzNyZDf8+PF074i0U9VCGCck5tLc8Zkqx52lXGc/D1jRbyRmb/UAXdwZV Mj6+gPuHRn4YUg79UnDypbwxmde/bTayLU8ZB8Es+xizvlResWx3JGU895lna+ISLbbW l+URgnmFhBQtBwBPfm/uEM5mPwd+UIdwFkQwDr5t3+fNyy4mVrYKoOkMVQkZPUChUi74 eJDtNtmHWTsgi5NKQYHw8xxGdOujWjNWG7C5h4pDgYKg0H47QvlGOeUWx9iDAzDYv5C4 qCj3VaFTE62slvyLaImj/QQpLMzDv9Vd7ftOZu/1fIsNgqs5kuzr5rnb42Ocdeh2U1Y+ h/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:user-agent :mime-version:content-type:content-transfer-encoding; bh=cg7nfadkCmH2ox4YitL41ivjydyJW5VN+2xIFi2+P/4=; b=HR/D57n1oOokyrrtDHSdWC/2FH8cyCooRIv+dlYqxEOG7gD8wxSNNEyUOAiBdnWkcX 8tJYq4Di6zd0Gu5D27uK+rIz2JsHZS2aMaa93HyAdKFxTXiI6VQ8+jV9qgJD0nyrW49q 5FkQsMyBbAR/4RJYe/DItWwl6cD4bdOxS/mj+r5XX7L21ZegK4ceDwnNT5IiRvJpWrRr nsP9Xr/8qIopPYr6r61fXS/n30eEojkhz3DDzjz/w+ZXjarAeCj66i0L3Jol+zp8pnNA HF7ZIvpUR/DCiVKjksHMa1YkFEVpoacwGzafBZC5Wqlw8kB6cnY/Bx7iu4KW2nU++b85 nbSg== X-Gm-Message-State: ALoCoQkU+R1nvsVidLz+xI0ZOjL6WvREbnvi/Rpm691dYSRbQtldx8I2njHNg3GxG6IBYAroD4lX X-Received: by 10.50.176.169 with SMTP id cj9mr25485091igc.14.1409630629007; Mon, 01 Sep 2014 21:03:49 -0700 (PDT) Received: from localhost ([172.16.49.108]) by mx.google.com with ESMTPSA id lq10sm34563353igb.22.2014.09.01.21.03.47 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 01 Sep 2014 21:03:47 -0700 (PDT) Subject: [PATCH] lspci: Correct Root Capabilities "CRS Software Visibility" bit To: Martin Mares From: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, rajatxjain@gmail.com Date: Mon, 01 Sep 2014 22:03:46 -0600 Message-ID: <20140902040346.18691.58345.stgit@bhelgaas-glaptop2.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP lspci incorrectly tests bit 4, not bit 0, for "CRS Software Visibility" in the Root Capabilities register, so it shows "RootCap: CRSVisible-" even for devices that do support Software Visibility. Use the correct definition for PCI_EXP_RTCAP_CRSVIS. Signed-off-by: Bjorn Helgaas --- lib/header.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/lib/header.h b/lib/header.h index db85df1..8ee7565 100644 --- a/lib/header.h +++ b/lib/header.h @@ -842,7 +842,7 @@ #define PCI_EXP_RTCTL_PMEIE 0x0008 /* PME Interrupt Enable */ #define PCI_EXP_RTCTL_CRSVIS 0x0010 /* Configuration Request Retry Status Visible to SW */ #define PCI_EXP_RTCAP 0x1e /* Root Capabilities */ -#define PCI_EXP_RTCAP_CRSVIS 0x0010 /* Configuration Request Retry Status Visible to SW */ +#define PCI_EXP_RTCAP_CRSVIS 0x0001 /* Configuration Request Retry Status Visible to SW */ #define PCI_EXP_RTSTA 0x20 /* Root Status */ #define PCI_EXP_RTSTA_PME_REQID 0x0000ffff /* PME Requester ID */ #define PCI_EXP_RTSTA_PME_STATUS 0x00010000 /* PME Status */