From patchwork Fri Sep 12 18:04:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 4897331 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 936CCBEEA5 for ; Fri, 12 Sep 2014 18:05:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 64B432024C for ; Fri, 12 Sep 2014 18:05:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43EF420200 for ; Fri, 12 Sep 2014 18:05:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497AbaILSEH (ORCPT ); Fri, 12 Sep 2014 14:04:07 -0400 Received: from mail-ig0-f174.google.com ([209.85.213.174]:37058 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752448AbaILSEE (ORCPT ); Fri, 12 Sep 2014 14:04:04 -0400 Received: by mail-ig0-f174.google.com with SMTP id h18so962488igc.1 for ; Fri, 12 Sep 2014 11:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=F4b3s1ENDOXvoHqt9Ak5KO0bx7bzLlnmxW/a/iTVmDk=; b=SzHDUit+Rp/MjLSKP3x7vMKvcAT4Yb2tuvx92LcTGf8F5ghb2UcWssCsrNDeM0cQfE 46I3O3xXy+CgiIXtyEtFjH7w8CGStKTGeVqgpdytDCxxzi65oIPVJ8vHNKkXql4vAADP 8xTrBm+ldwqao+tfS8dJKhx0GgO4pzE9y5PEskfSc32IA/y99UOJmlQ/DR75Pr852WNd 8Bk+MiYJveNEENNa7STcs0/EUNZhpzF7YOG2VU+Lie8eZkaAeU4YRwjbXjgKVl/srAAJ S9McdrJkFw7spb4omO6joQSsS334MMUGKpW1QiDUGv9nSQQkGQI4L/Opl7Gu998gCP8s cBnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=F4b3s1ENDOXvoHqt9Ak5KO0bx7bzLlnmxW/a/iTVmDk=; b=TVbVmer5PH1sYW2JIpCq1oYCm0gciGTU22EsNXITropPVUV7MI5xB1Md8sEdBgFmJx W0ulQHquYm+rsq++TNdkX07BVEDvjBQdZa/5D0bBZ9oZ9If4AxLuX+p9vqOjT22lsyju y+skHUxNAGL+0gznCSihu2R9Uzq8FRYmmoh/8Ag/kIjetFiIWH0UAlRj5hTMXlN5HhZH KtcgGn6stf4BjQCo2FWreBh8eqvaWa6pwG9utGDjtzmlK+LI1/0RfaqARjuPE5YEvGPd z98bJsKUpOzrx52HDbqAD/VX8i0XtQV7l5SDR8Q3WEH82t1QJlkwULHxA4FZ9+4Rm2KB KZIQ== X-Gm-Message-State: ALoCoQnsrFf0zjiiozFJG3cSUAX8KdihStSUg5KplcqyZjzlTXC2b2X7ts2BQgYMHc+bwwlxMF4g X-Received: by 10.50.79.132 with SMTP id j4mr4375826igx.9.1410545044326; Fri, 12 Sep 2014 11:04:04 -0700 (PDT) Received: from localhost ([172.16.49.108]) by mx.google.com with ESMTPSA id a4sm2106787igv.1.2014.09.12.11.04.03 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 12 Sep 2014 11:04:03 -0700 (PDT) Subject: [PATCH v1 11/13] PCI: Apply _HPP settings to all hot-added PCI devices To: linux-pci@vger.kernel.org From: Bjorn Helgaas Cc: Rajat Jain , Linus Torvalds , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Yinghai Lu Date: Fri, 12 Sep 2014 12:04:03 -0600 Message-ID: <20140912180403.1630.49400.stgit@bhelgaas-glaptop2.roam.corp.google.com> In-Reply-To: <20140912180141.1630.17120.stgit@bhelgaas-glaptop2.roam.corp.google.com> References: <20140912180141.1630.17120.stgit@bhelgaas-glaptop2.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We currently apply _HPP settings only to: - non-bridge devices, and - PCI-to-PCI bridges i.e., we do not apply them to PCI-to-ISA bridges and the like. It has been that way since _HPP support was added by 40abb96c51bb ("pciehp: Fix programming hotplug parameters"), but I don't think there's any reason to exclude these other bridges. Apply _HPP settings to hot-added PCI devices of any type. Signed-off-by: Bjorn Helgaas --- drivers/pci/probe.c | 5 ----- 1 file changed, 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index a16b3472b70d..1ff2105ba401 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1351,11 +1351,6 @@ static void pci_configure_device(struct pci_dev *dev) if (system_state == SYSTEM_BOOTING) return; - if (!(dev->hdr_type == PCI_HEADER_TYPE_NORMAL || - (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE && - (dev->class >> 8) == PCI_CLASS_BRIDGE_PCI))) - return; - memset(&hpp, 0, sizeof(hpp)); ret = pci_get_hp_params(dev, &hpp); if (ret)