From patchwork Tue Feb 24 08:33:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 5870451 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id ABC80BF440 for ; Tue, 24 Feb 2015 08:33:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E64BA2063C for ; Tue, 24 Feb 2015 08:33:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9E402064F for ; Tue, 24 Feb 2015 08:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485AbbBXIdF (ORCPT ); Tue, 24 Feb 2015 03:33:05 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:46603 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbbBXIdE (ORCPT ); Tue, 24 Feb 2015 03:33:04 -0500 Received: by pabkx10 with SMTP id kx10so34321311pab.13 for ; Tue, 24 Feb 2015 00:33:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=eu7+IJj22d3q8M2PXx7CWpkAVxrE2fsfu45TL5dGF/4=; b=GADi+Q2+8GsDuYsMG98eiIx/GySUK2j8VNFHo3gSN5AXej7CGm7VgCnkt3qKo0aI9Q YzslZDHB4tZ/CwlQQNk9fuw27FbT/MLRWkKAOZnOu650R5soqKI1QbJ22hJXBGkaZ5Ra zV4ILDbxCy7wRaqA1g0WqLr3qGcedjmjQ986CqE7U7f+kEL00012vgcZI0W7OCMQU6A9 QiFnEevW098/jA78R6f6evVwIWfXcmPr0uy64n3EJLy1pTTlHldOHD9jZlRcfC36XtqQ kLyZL/I4+HLpJI7rVXafnqyGiwjNaQUxvk6yczs5rNtJJfDpp8zs96gjlKmaEIielL+s mq9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-type :content-transfer-encoding; bh=eu7+IJj22d3q8M2PXx7CWpkAVxrE2fsfu45TL5dGF/4=; b=gtok/Cd5RnIRjA7QtrrNj78RUBYo5HF7BVXMRVoOB6sjY777j6qpXgfQBa/10+wCkB MGgpr+5zrVKJ8b3LlZVjEWaZklTgn8xW/WIUfqe2FNK9/5HfNaATx8wh/cmp2fePb7F0 0wFh0fxd098fYrc7nwqCoMwH8XwyG84CGYGVgH5MWdSecLnx4ipdusrXcIpViAhe3ezo bIBIdfgKqtSwDAjc4CgKtwvwqAKZAO18Sqw0Q2Nbk16CkcV3QDzlzQVaNg0EhITHq7h1 TirQC6Kp8JpXmenTcmkpcdNpK4jclln9nIdzOQDipJ+NJJW/VNGnwTUJHo71RSv2yD/X HOcA== X-Gm-Message-State: ALoCoQlWnjkrWXXEuZBvMkIR+WUpen2qL1mFcMtjsyoz34TCWb7fNEgfDVpM6P5/7J0zxY6SOR5c X-Received: by 10.66.217.230 with SMTP id pb6mr27302433pac.2.1424766784005; Tue, 24 Feb 2015 00:33:04 -0800 (PST) Received: from localhost ([12.23.74.29]) by mx.google.com with ESMTPSA id ru8sm3748272pbb.20.2015.02.24.00.33.02 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 24 Feb 2015 00:33:03 -0800 (PST) Subject: [PATCH v12 01/21] PCI: Print more info in sriov_enable() error message To: Wei Yang , benh@au1.ibm.com, gwshan@linux.vnet.ibm.com From: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Tue, 24 Feb 2015 02:33:02 -0600 Message-ID: <20150224083302.32124.13369.stgit@bhelgaas-glaptop2.roam.corp.google.com> In-Reply-To: <20150224082939.32124.45744.stgit@bhelgaas-glaptop2.roam.corp.google.com> References: <20150224082939.32124.45744.stgit@bhelgaas-glaptop2.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If we don't have space for all the bus numbers required to enable VFs, print the largest bus number required and the range available. No functional change; improved error message only. Signed-off-by: Bjorn Helgaas --- drivers/pci/iov.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index 4b3a4eaad996..c4c33ead03bc 100644 --- a/drivers/pci/iov.c +++ b/drivers/pci/iov.c @@ -180,6 +180,7 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn) struct pci_dev *pdev; struct pci_sriov *iov = dev->sriov; int bars = 0; + u8 bus; if (!nr_virtfn) return 0; @@ -216,8 +217,10 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn) iov->offset = offset; iov->stride = stride; - if (virtfn_bus(dev, nr_virtfn - 1) > dev->bus->busn_res.end) { - dev_err(&dev->dev, "SR-IOV: bus number out of range\n"); + bus = virtfn_bus(dev, nr_virtfn - 1); + if (bus > dev->bus->busn_res.end) { + dev_err(&dev->dev, "can't enable %d VFs (bus %02x out of range of %pR)\n", + nr_virtfn, bus, &dev->bus->busn_res); return -ENOMEM; }