From patchwork Thu Apr 9 19:12:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 6190001 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4A994BF4A6 for ; Thu, 9 Apr 2015 19:12:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5F9912037C for ; Thu, 9 Apr 2015 19:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 547712035C for ; Thu, 9 Apr 2015 19:12:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933121AbbDITMl (ORCPT ); Thu, 9 Apr 2015 15:12:41 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:33371 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932833AbbDITMj (ORCPT ); Thu, 9 Apr 2015 15:12:39 -0400 Received: by oblw8 with SMTP id w8so146796125obl.0 for ; Thu, 09 Apr 2015 12:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=7HUXIfNl8uylkeMVnqrnZc6CkCjD9/CgpIT9nSEDYUQ=; b=C14gy92f4j3L2E8Ftgs56sBkvRhXeD83BgfiV+QH0RgNLcH5A25rPjT60fEZcPKczK fjDOreMr7+6yd7Ljx/q3wGHq28NUuTPLtkNRE6bmWvLzmRX4txr1hXMSphpx3qDHJP9j K3QZz2YQEBrl3PKjBmo1jx9+JYghA2K8bbeODJEaujO3ClI0nI8OhPHRhD4hjYrFagml XcmMwCFUGyIUO23GOGs+vv7N86K1t4YybUGlJbpNos/cXhypCelrtkPvrDtZrvnEujpl htpmyQEW8QUwGjxLIpkDjmlRP29sC3dmTkx4X/+UL6ek6E5kQoxv12+7L1S1fJrWqLR6 T7Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=7HUXIfNl8uylkeMVnqrnZc6CkCjD9/CgpIT9nSEDYUQ=; b=ZP5x3RbsuxGWKvjbCQaOy4Jb/8ZWkWQ/MHNFY8NXd4GPWzgSsydBuB6+Tle2Mjpp/H X6X7gF3KGJ0HObwIo7Gv9AfKfVmcL2voVFTBbdtk8s/c6BymqWpDN0ppgjUYmwlYz15Q 3e957L1Hg6itlO5M8k17c6N+7NgzQV1FkYrzmiwjiwQjuoeFT15NyBG5c8PFppJYioeL s2J79bH0qmvUtrWvdv4HaKdhAOuHs0AHOLdqKJGFSLtp/uWdkE/eHFCBMs8rneJJUpHB ocd//zxbGM/XNIPgAxDEY61F2uu2bPGP1u4/P92lzKIfRRX6HoHhE9fxxqCC6bdE/5YH 5ujQ== X-Gm-Message-State: ALoCoQkTBh8CTz25pfNRcQ7cB5ErYTj/wfr9Zdaq/dM+hqTls9tqGZUFSgEciF7s33G9ePPtQSSv X-Received: by 10.182.56.196 with SMTP id c4mr3433952obq.26.1428606759302; Thu, 09 Apr 2015 12:12:39 -0700 (PDT) Received: from google.com ([146.7.4.74]) by mx.google.com with ESMTPSA id ek11sm3500231oeb.6.2015.04.09.12.12.37 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 09 Apr 2015 12:12:38 -0700 (PDT) Date: Thu, 9 Apr 2015 14:12:35 -0500 From: Bjorn Helgaas To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Jonathan Corbet , linux-pci@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH] pci.txt: clarify vendor ID policy Message-ID: <20150409191235.GI30967@google.com> References: <1427704341-14125-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1427704341-14125-1-git-send-email-mst@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FSL_HELO_FAKE, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Mar 30, 2015 at 10:32:34AM +0200, Michael S. Tsirkin wrote: > Top of include/linux/pci_ids.h says: > Do not add new entries to this file unless the definitions > are shared between multiple drivers. > on the other hand, Documentation/PCI/pci.txt seems to imply that all > vendor IDs should be added in include/linux/pci_ids.h. > > Clarify text pci.txt to avoid the apparent contradiction. > > Signed-off-by: Michael S. Tsirkin Applied to pci/misc for v4.1 in the following form. Thanks! commit b3d3d4d67569ad726530d8de3d7aa334c7e7465b Author: Michael S. Tsirkin Date: Mon Mar 30 10:32:34 2015 +0200 PCI: Clarify policy for vendor IDs in pci.txt Clarify pci.txt so it matches the "do not add new entries unless they are sahred between multiple drivers" comment in include/linux/pci_ids.h. [bhelgaas: changelog, strengthen language] Signed-off-by: Michael S. Tsirkin Signed-off-by: Bjorn Helgaas --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/Documentation/PCI/pci.txt b/Documentation/PCI/pci.txt index 9518006f6675..123881f62219 100644 --- a/Documentation/PCI/pci.txt +++ b/Documentation/PCI/pci.txt @@ -564,14 +564,14 @@ to be handled by platform and generic code, not individual drivers. 8. Vendor and device identifications ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -One is not required to add new device ids to include/linux/pci_ids.h. -Please add PCI_VENDOR_ID_xxx for vendors and a hex constant for device ids. +Do not add new device or vendor IDs to include/linux/pci_ids.h unless they +are shared across multiple drivers. You can add private definitions in +your driver if they're helpful, or just use plain hex constants. -PCI_VENDOR_ID_xxx constants are re-used. The device ids are arbitrary -hex numbers (vendor controlled) and normally used only in a single -location, the pci_device_id table. +The device IDs are arbitrary hex numbers (vendor controlled) and normally used +only in a single location, the pci_device_id table. -Please DO submit new vendor/device ids to pciids.sourceforge.net project. +Please DO submit new vendor/device IDs to http://pciids.sourceforge.net/.