From patchwork Thu Apr 9 19:49:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 6190311 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 954C99F2E9 for ; Thu, 9 Apr 2015 19:49:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BE88920380 for ; Thu, 9 Apr 2015 19:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7E532037B for ; Thu, 9 Apr 2015 19:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933239AbbDITt2 (ORCPT ); Thu, 9 Apr 2015 15:49:28 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:33715 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933018AbbDITt2 (ORCPT ); Thu, 9 Apr 2015 15:49:28 -0400 Received: by oblw8 with SMTP id w8so148350523obl.0 for ; Thu, 09 Apr 2015 12:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:user-agent:mime-version :content-type:content-transfer-encoding; bh=xibn/C1DE0jnzYzwqvU4buyZBS7EhhGOCX+ZHdcFz/4=; b=LLE+Oz6ixfcKC63GrztvIzsOVFTtgLXYOnhrVBiBZcAkzyCzJH7EpSKZ5Fb8XVV58m gvJ1mwD6FzerhLBYeviBU0ETEIgN5QfUWZnx1VzYlsOazzmXFCkDriyqlghkXhMgiovw Ov4oXU9Md1jIiyWeZiB8GOVH6Auge0krc7hGrSxjqP7v8sSUmwJ2yqesgpD4S7tXn6rz MMURK+82VPcz6G760jZrGJetxg8CWZKqBheJFGcUZJQ/WtNxMh7Y10vZFZvygTzeGS3F r8//V+3Tt0WShqWJmh2tfH1G7WwAR9Js/3JWuDXkSJ+GjXQ1Jn8NGg+nLKGye60ivX1f eTYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:from:cc:date:message-id:user-agent :mime-version:content-type:content-transfer-encoding; bh=xibn/C1DE0jnzYzwqvU4buyZBS7EhhGOCX+ZHdcFz/4=; b=jyRXH3IuHYze3mPL+W7YtSC6kFV+sTgd6eKGCOSR/QPcFN+jT1wVW9sOCePUve3FmD LIjVGtT2/at10gwSGwAkachrxBtmKIR8LqEXaxZNnZDJoiS5o/orLERwiSxciowMCPL7 5oiXhm4s24OLsKLD32+antS/YNwIssKd1cl54iGawvbv8PIuDs0B/GfoIu/RfImOdHsM cQV78sNBJPvZZm57bScqYxoVrWasf5tr7kw1PK5hRzVQ9dqQtxVDKpaLG2VQZsPtG29z CRNm2DuupL0c5ZYLsMvjUdZQ8CKn3sV7HrzMCj6QXiHb6ZFGh/aHLU4MVDwTwKjyjLjy jsDw== X-Gm-Message-State: ALoCoQl5iv8AEY/cO3TZztW81CUzFdTm7GQvilf5+aqJg8DX4xNhKGFcifOjdWF3j+Th7qoM+9SF X-Received: by 10.182.106.197 with SMTP id gw5mr17044964obb.30.1428608967634; Thu, 09 Apr 2015 12:49:27 -0700 (PDT) Received: from localhost ([146.7.4.74]) by mx.google.com with ESMTPSA id co9sm12149532obb.22.2015.04.09.12.49.26 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 09 Apr 2015 12:49:27 -0700 (PDT) Subject: [PATCH] PCI: layerscape: Simplify platform_get_resource_byname() failure checking To: Minghuan Lian , Mingkai Hu , Roy Zang From: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Date: Thu, 09 Apr 2015 14:49:23 -0500 Message-ID: <20150409194923.19293.96454.stgit@bhelgaas-glaptop2.roam.corp.google.com> User-Agent: StGit/0.16 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP devm_ioremap_resource() validates the resource it receives, so if we check for devm_ioremap_resource() failure, we need not check for failure of the preceding platform_get_resource(). Signed-off-by: Bjorn Helgaas --- drivers/pci/host/pci-layerscape.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c index 68c9e5e9b0a8..4a6e62f67579 100644 --- a/drivers/pci/host/pci-layerscape.c +++ b/drivers/pci/host/pci-layerscape.c @@ -127,14 +127,11 @@ static int __init ls_pcie_probe(struct platform_device *pdev) pcie->dev = &pdev->dev; dbi_base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs"); - if (!dbi_base) { - dev_err(&pdev->dev, "missing *regs* space\n"); - return -ENODEV; - } - pcie->dbi = devm_ioremap_resource(&pdev->dev, dbi_base); - if (IS_ERR(pcie->dbi)) + if (IS_ERR(pcie->dbi)) { + dev_err(&pdev->dev, "missing *regs* space\n"); return PTR_ERR(pcie->dbi); + } pcie->scfg = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "fsl,pcie-scfg");