From patchwork Thu Jun 18 20:00:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 6640331 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D4B3DC0020 for ; Thu, 18 Jun 2015 20:01:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E4F5220868 for ; Thu, 18 Jun 2015 20:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A802120845 for ; Thu, 18 Jun 2015 20:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755521AbbFRUA7 (ORCPT ); Thu, 18 Jun 2015 16:00:59 -0400 Received: from mail-ie0-f171.google.com ([209.85.223.171]:36273 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbbFRUA6 (ORCPT ); Thu, 18 Jun 2015 16:00:58 -0400 Received: by iecrd14 with SMTP id rd14so62039507iec.3 for ; Thu, 18 Jun 2015 13:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=3ThicbuYACr2ThhbhHpuyeXZruMv5b1AueZelSW01OA=; b=DttjDRsGD8yf+EVa6gQIl5YKwahGJAGJrRlIyFDVkbiy1TzOUeyVYs/oPxkAiYmkCg uv+iOCUBlY2OTcPrVs4J+EoLJd0sgwInd78H4BX9BgN8Z+FI/CYr+GAVwgKm/Fa6KGXU ioPFiaB2vK7qxCYm8HF0uV+jSBTSdnOL2OdmATHicgXdYvwoRkOwVX4ta1leJaAa6jPR ZzLLIs32UAFr3VpbNiA7wTFJaUy26IbQoPopvtoeSwCXWNiZ2Wc/kTKyx1QYjjJxS3d3 bIyhDJrs2wiCFIZnbWbHQXtX+g2q+VE3qwoeQNeraEwURT89gWnEIczuJJsGOFAcCP3G yUqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=3ThicbuYACr2ThhbhHpuyeXZruMv5b1AueZelSW01OA=; b=kmvvU7DxtTI9H8ZggnCEZkQoV4+csh6ulqy893thm47D7FY1VbZqVQKDZBAErg4akc Pua37pw8A9vSqd/3XSTbZLu0HaTVBQgPPOcbyZ/ZbnNodch27VYpMjR4qv7UrUthTcib rDvH8pAsecEl3yuTfMi5rLngv3+D40OaA3o159UvzGpAFHqmmXtxxYob24AIVkmkIcNH ZzjH3mR1V2ompkD8sK59jh1x6L/lLmGki2JrlsqGPJraEdOI75y6K+Oz0hXdtvQSCLA9 GaDAFOSOQf/VC/44FnCJk53XIzieXSGHlKygtYRsfNl7GnDSh6yUkYlnNIHXpFfXkUSq +akA== X-Gm-Message-State: ALoCoQn+B1w+37kiQ/U51Akkp4eGvkSmEdcNR0fUGlR6GSliTXtfTRb118w3GsSijKs8LVWH7v+/ X-Received: by 10.107.10.151 with SMTP id 23mr16780322iok.89.1434657657816; Thu, 18 Jun 2015 13:00:57 -0700 (PDT) Received: from google.com ([69.71.1.1]) by mx.google.com with ESMTPSA id f82sm5584606ioj.37.2015.06.18.13.00.54 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 18 Jun 2015 13:00:55 -0700 (PDT) Date: Thu, 18 Jun 2015 15:00:53 -0500 From: Bjorn Helgaas To: Duc Dang Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tanmay Inamdar , patches@apm.com Subject: Re: [PATCH 1/1] PCI: xgene: Allow config access to Root Port even when link is down Message-ID: <20150618200053.GG7710@google.com> References: <1434653139-14461-1-git-send-email-dhdang@apm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1434653139-14461-1-git-send-email-dhdang@apm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jun 18, 2015 at 11:45:39AM -0700, Duc Dang wrote: > Even if a Root Port's link is down, we should still be able to access the > Port's configuration space. > > Suggested-by: Bjorn Helgaas > Signed-off-by: Duc Dang > Signed-off-by: Tanmay Inamdar > --- > drivers/pci/host/pci-xgene.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c > index 7e3cf28..2e66c87 100644 > --- a/drivers/pci/host/pci-xgene.c > +++ b/drivers/pci/host/pci-xgene.c > @@ -139,7 +139,7 @@ static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn, > { > struct xgene_pcie_port *port = bus->sysdata; > > - if ((pci_is_root_bus(bus) && devfn != 0) || !port->link_up || > + if ((pci_is_root_bus(bus) && devfn != 0) || > xgene_pcie_hide_rc_bars(bus, offset)) > return NULL; > Applied with changelog as follows to pci/host-xgene for v4.2, thanks! commit 979595bcb8da04381ed85d3b0eb1f471cc5863e4 Author: Duc Dang Date: Thu Jun 18 11:45:39 2015 -0700 PCI: xgene: Allow config access to Root Port even when link is down Previously, when a Root Port's link was down, we didn't allow config access to the Root Port, which meant that if the Root Port led to an empty slot, "lspci" didn't even show the Root Port. Allow config access to Root Port even when link is down. [bhelgaas: changelog] Suggested-by: Bjorn Helgaas Signed-off-by: Duc Dang Signed-off-by: Tanmay Inamdar Signed-off-by: Bjorn Helgaas --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c index 70af714..1fc8910 100644 --- a/drivers/pci/host/pci-xgene.c +++ b/drivers/pci/host/pci-xgene.c @@ -139,7 +139,7 @@ static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn, { struct xgene_pcie_port *port = bus->sysdata; - if ((pci_is_root_bus(bus) && devfn != 0) || !port->link_up || + if ((pci_is_root_bus(bus) && devfn != 0) || xgene_pcie_hide_rc_bars(bus, offset)) return NULL;