From patchwork Wed Aug 5 09:25:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 6947221 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0A8C69F39D for ; Wed, 5 Aug 2015 09:25:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2887120426 for ; Wed, 5 Aug 2015 09:25:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 349342040F for ; Wed, 5 Aug 2015 09:25:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752522AbbHEJZk (ORCPT ); Wed, 5 Aug 2015 05:25:40 -0400 Received: from foss.arm.com ([217.140.101.70]:32964 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbbHEJZg (ORCPT ); Wed, 5 Aug 2015 05:25:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 025C275; Wed, 5 Aug 2015 02:25:39 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 33E843F318; Wed, 5 Aug 2015 02:25:34 -0700 (PDT) Date: Wed, 5 Aug 2015 10:25:34 +0100 From: Will Deacon To: Bjorn Helgaas Cc: Jayachandran C , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Arnd Bergmann , Lorenzo Pieralisi , Liviu Dudau , "suravee.suthikulpanit@amd.com" , Ming Lei Subject: Re: [PATCH v4 1/3] PCI: generic: remove dependency on hw_pci Message-ID: <20150805092533.GC6092@arm.com> References: <1438721620-15493-1-git-send-email-jchandra@broadcom.com> <20150804234956.GF17327@google.com> <20150805092318.GB6092@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150805092318.GB6092@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Aug 05, 2015 at 10:23:18AM +0100, Will Deacon wrote: > That said, I just tried to build this and it fails to compile the x-gene > PCI host driver. Fixup below. Wait, there's more! Will --->8 --- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c index 514f41b86c49..8ab3bd098424 100644 --- a/drivers/pci/host/pci-xgene.c +++ b/drivers/pci/host/pci-xgene.c @@ -506,7 +506,7 @@ static int xgene_pcie_msi_enable(struct xgene_pcie_port *port) { struct device_node *msi_node; - msi_node = of_parse_phandle(port->dev.of_node, "msi-parent", 0); + msi_node = of_parse_phandle(port->dev->of_node, "msi-parent", 0); if (!msi_node) return -ENODEV; @@ -515,7 +515,7 @@ static int xgene_pcie_msi_enable(struct xgene_pcie_port *port) return -ENODEV; of_node_put(msi_node); - port->msi->dev = &port->dev; + port->msi->dev = port->dev; return 0; }