From patchwork Fri May 18 19:51:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 10412015 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DAF6A602C2 for ; Fri, 18 May 2018 19:52:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA53128AC4 for ; Fri, 18 May 2018 19:52:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BF03428AC7; Fri, 18 May 2018 19:52:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8921028AC4 for ; Fri, 18 May 2018 19:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751897AbeERTv7 (ORCPT ); Fri, 18 May 2018 15:51:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:44010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbeERTv5 (ORCPT ); Fri, 18 May 2018 15:51:57 -0400 Received: from localhost (unknown [69.71.5.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D0FA20833; Fri, 18 May 2018 19:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1526673117; bh=s+IvFzHJmI31aaAuswNYWy4VNiZx9oOjSeMwPzkSmPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e4tgWQ3IVyJKRz+yOxeZY/dr0T0j27JUoaMH9b+Ex/wNHlQNvZhamyP0dy/1cMMr7 +T08L7eKeyJKVuwPq5L/+4Mw9kbsRdVTRGC4yta0YazDyWNbV3aZ7cn5F23K7Upuv7 kZg33jluhzXaqaXonzYpSCIEgeMUxvh2ChSGRIjw= Date: Fri, 18 May 2018 14:51:54 -0500 From: Bjorn Helgaas To: honghui.zhang@mediatek.com Cc: lorenzo.pieralisi@arm.com, marc.zyngier@arm.com, bhelgaas@google.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, ryder.lee@mediatek.com, hongkun.cao@mediatek.com, youlin.pei@mediatek.com, yong.wu@mediatek.com, yt.shen@mediatek.com, sean.wang@mediatek.com, xinping.qian@mediatek.com Subject: Re: [PATCH v7 2/2] PCI: mediatek: Using chained IRQ to setup IRQ handle Message-ID: <20180518195154.GB41790@bhelgaas-glaptop.roam.corp.google.com> References: <1525412853-24367-1-git-send-email-honghui.zhang@mediatek.com> <1525412853-24367-3-git-send-email-honghui.zhang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1525412853-24367-3-git-send-email-honghui.zhang@mediatek.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, May 04, 2018 at 01:47:33PM +0800, honghui.zhang@mediatek.com wrote: > From: Honghui Zhang > > Using irq_chip solution to setup IRQs in order to consist > with IRQ framework. > > Signed-off-by: Honghui Zhang > Acked-by: Ryder Lee > --- > drivers/pci/host/pcie-mediatek.c | 206 ++++++++++++++++++++++----------------- > 1 file changed, 115 insertions(+), 91 deletions(-) > > diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c > index c3dc549..dabf1086 100644 > --- a/drivers/pci/host/pcie-mediatek.c > +++ b/drivers/pci/host/pcie-mediatek.c > ... > -static int mtk_pcie_msi_map(struct irq_domain *domain, unsigned int irq, > - irq_hw_number_t hwirq) > +static struct msi_domain_info mtk_msi_domain_info = { I think this patch should be amended to include this: Lorenzo, if you want to fold that in and update your branch, I can pull it. If not, I can add a patch on top, which should only break compile-testing bisection. diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index 0d0177ce436c..368b70d9371b 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -193,7 +193,7 @@ config PCIE_MEDIATEK bool "MediaTek PCIe controller" depends on (ARM || ARM64) && (ARCH_MEDIATEK || COMPILE_TEST) depends on OF - depends on PCI + depends on PCI_MSI_IRQ_DOMAIN select PCIEPORTBUS help Say Y here if you want to enable PCIe controller support on