From patchwork Fri Sep 14 16:14:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Miroshnichenko X-Patchwork-Id: 10601023 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5839015A7 for ; Fri, 14 Sep 2018 16:21:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 426782A448 for ; Fri, 14 Sep 2018 16:21:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 350A22BBE0; Fri, 14 Sep 2018 16:21:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB57B2A448 for ; Fri, 14 Sep 2018 16:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbeINVgp (ORCPT ); Fri, 14 Sep 2018 17:36:45 -0400 Received: from mta-01.yadro.com ([89.207.88.251]:60246 "EHLO mta-01.yadro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728178AbeINVgo (ORCPT ); Fri, 14 Sep 2018 17:36:44 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id B91B64122E; Fri, 14 Sep 2018 16:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= content-type:content-type:mime-version:references:in-reply-to :x-mailer:message-id:date:date:subject:subject:from:from :received:received:received; s=mta-01; t=1536941651; x= 1538756052; bh=HxEg0hSCMXqPYz5u/o7EAYQzRg0m5i0GBjy7NvSR2AQ=; b=B f5gjcXhMurzY+2DuKv3mi9G+7D2/1tGklo8DqrTbDNWkTqCrkYkcUBJTfff8f6KM kAp+E+NhBK2jh4I9kZRX0F3swrPNdSL/u291b+uPa6dOKQeqwFPXbY8ZP0yPOQcC tEO3sEv8c5e8SqZzEoAtnWyGd9/KrqvglzySYyp+HM= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id spDUaVe5CqYA; Fri, 14 Sep 2018 19:14:11 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 3E0E5418A4; Fri, 14 Sep 2018 19:14:11 +0300 (MSK) Received: from NB-148.yadro.com (172.17.15.60) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Fri, 14 Sep 2018 19:14:10 +0300 From: Sergey Miroshnichenko To: CC: Bjorn Helgaas , , Sergey Miroshnichenko Subject: [PATCH RFC 3/4] PCI: Invalidate the released BAR resources Date: Fri, 14 Sep 2018 19:14:03 +0300 Message-ID: <20180914161404.4685-4-s.miroshnichenko@yadro.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180914161404.4685-1-s.miroshnichenko@yadro.com> References: <20180914161404.4685-1-s.miroshnichenko@yadro.com> MIME-Version: 1.0 X-Originating-IP: [172.17.15.60] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-02.corp.yadro.com (172.17.10.102) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Otherwise after release_child_resources() there can be resources with the IORESOURCE_STARTALIGN flag remaining, but with start dropped to zero, that makes them not valid for re-assigning. Signed-off-by: Sergey Miroshnichenko --- drivers/pci/setup-bus.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index fd5675bb501f..ec88461462b8 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -1521,7 +1521,7 @@ static void __pci_bridge_assign_resources(const struct pci_dev *bridge, static void pci_bridge_release_resources(struct pci_bus *bus, unsigned long type) { - struct pci_dev *dev = bus->self; + struct pci_dev *dev = bus->self, *child_dev; struct resource *r; unsigned old_flags = 0; struct resource *b_res; @@ -1564,6 +1564,25 @@ static void pci_bridge_release_resources(struct pci_bus *bus, * all */ release_child_resources(r); + list_for_each_entry(child_dev, &bus->devices, bus_list) { + int i; + + if (child_dev->subordinate) + continue; + + for (i = 0; i <= PCI_ROM_RESOURCE; i++) { + struct resource *res = &child_dev->resource[i]; + resource_size_t size = resource_size(res); + + if (!res->flags) + continue; + + res->end = size - 1; + res->start = 0; + res->flags &= ~IORESOURCE_STARTALIGN; + res->flags |= IORESOURCE_SIZEALIGN; + } + } if (!release_resource(r)) { type = old_flags = r->flags & PCI_RES_TYPE_MASK; pci_printk(KERN_DEBUG, dev, "resource %d %pR released\n",