| Message ID | 20191017181937.7004-4-palmer@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | [1/3] ia64: Use the generic msi.h | expand |
On 10/17/19 2:19 PM, Palmer Dabbelt wrote: > As far as I can tell, the only reason there was an architecture > whitelist for PCI_MSI_IRQ_DOMAIN is because it requires msi.h. I've > built this for all the architectures that play nice with make.cross, but > I haven't boot tested it anywhere. > > Signed-off-by: Palmer Dabbelt <palmer@sifive.com> > --- > drivers/pci/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig > index a304f5ea11b9..77c1428cd945 100644 > --- a/drivers/pci/Kconfig > +++ b/drivers/pci/Kconfig > @@ -52,7 +52,7 @@ config PCI_MSI > If you don't know what to do here, say Y. > > config PCI_MSI_IRQ_DOMAIN > - def_bool ARC || ARM || ARM64 || X86 || RISCV > + def_bool y > depends on PCI_MSI > select GENERIC_MSI_IRQ_DOMAIN > The linking of asm-generic/msi.h is currently enabled for ./arch/powerpc/include/asm/Kbuild:generic-y += msi.h ./arch/arm/include/asm/Kbuild:generic-y += msi.h ./arch/mips/include/asm/Kbuild:generic-y += msi.h ./arch/riscv/include/asm/Kbuild:generic-y += msi.h ./arch/arc/include/asm/Kbuild:generic-y += msi.h ./arch/arm64/include/asm/Kbuild:generic-y += msi.h ./arch/sparc/include/asm/Kbuild:generic-y += msi.h Your patchset adds 2 more and x86 has its own asm/msi.h. That leads to a total of 10 archs, but there are 37 sub-directories under arch. It is possible that the other architectures don't have PCI_MSI set. Still it may be a bit risky to set it to "def_bool y". Cheers, Longman
diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig index a304f5ea11b9..77c1428cd945 100644 --- a/drivers/pci/Kconfig +++ b/drivers/pci/Kconfig @@ -52,7 +52,7 @@ config PCI_MSI If you don't know what to do here, say Y. config PCI_MSI_IRQ_DOMAIN - def_bool ARC || ARM || ARM64 || X86 || RISCV + def_bool y depends on PCI_MSI select GENERIC_MSI_IRQ_DOMAIN
As far as I can tell, the only reason there was an architecture whitelist for PCI_MSI_IRQ_DOMAIN is because it requires msi.h. I've built this for all the architectures that play nice with make.cross, but I haven't boot tested it anywhere. Signed-off-by: Palmer Dabbelt <palmer@sifive.com> --- drivers/pci/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)