diff mbox series

[v8,20/24] PCI: Don't claim fixed BARs

Message ID 20200427182358.2067702-21-s.miroshnichenko@yadro.com
State New, archived
Delegated to: Bjorn Helgaas
Headers show
Series PCI: Allow BAR movement during boot and hotplug | expand

Commit Message

Sergei Miroshnichenko April 27, 2020, 6:23 p.m. UTC
Fixed BAR always has an address, but its parent bridge window can be not
yet calculated (during boot) or temporarily released for re-calculation
(during PCI rescan) when pci_claim_resource() is called.

Apart from that, fixed BARs now have separate guaranteed mechanism of
assigning comparing to usual BARs, so claiming them is not needed.

Return immediately from pci_claim_resource() to prevent misleading "can't
claim BAR ... no compatible bridge window" error messages

Signed-off-by: Sergei Miroshnichenko <s.miroshnichenko@yadro.com>
 drivers/pci/setup-res.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series


diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
index a1e61e74ce00..98051edd7eef 100644
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -138,6 +138,9 @@  int pci_claim_resource(struct pci_dev *dev, int resource)
 		return -EINVAL;
+	if (pci_dev_bar_fixed(dev, res))
+		return 0;
 	 * If we have a shadow copy in RAM, the PCI device doesn't respond
 	 * to the shadow range, so we don't need to claim it, and upstream