| Message ID | 20200914053110.23286-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | MAINTAINERS: make linux-mediatek list remarks consistent | expand |
On Mon, 14 Sep 2020, Lukas Bulwahn wrote: > Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller > support") does not mention that linux-mediatek@lists.infradead.org is > moderated for non-subscribers, but the other eight entries for > linux-mediatek@lists.infradead.org do. > > Adjust this entry to be consistent with all others. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > --- > applies cleanly on v5.9-rc5 and next-20200911 > > Ryder, please ack. > > Bjorn, Matthias, please pick this minor non-urgent clean-up patch. > > This patch submission will also show me if linux-mediatek is moderated or > not. I have not subscribed to linux-mediatek and if it shows up quickly in > the archive, the list is probably not moderated; and if it takes longer, it > is moderated, and hence, validating the patch. > Okay, my patch showed up within seconds in the archive: https://lore.kernel.org/linux-mediatek/20200914053110.23286-1-lukas.bulwahn@gmail.com/ I think the linux-mediatek list is actually NOT _moderated for non-subscribers_. Please IGNORE this patch until someone can confirm if it is moderated or not. I will then send the patch that reflects the actual state. Thanks, Lukas
On 14/09/2020 07:31, Lukas Bulwahn wrote: > Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller > support") does not mention that linux-mediatek@lists.infradead.org is > moderated for non-subscribers, but the other eight entries for > linux-mediatek@lists.infradead.org do. > > Adjust this entry to be consistent with all others. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Maybe rephrase the commit message to something like: "Mark linux-mediatek@lists.infraded.org as moderated for the MediaTek PCIe host controller entry, as the list actually is moderated." Anyway: Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > applies cleanly on v5.9-rc5 and next-20200911 > > Ryder, please ack. > > Bjorn, Matthias, please pick this minor non-urgent clean-up patch. > > This patch submission will also show me if linux-mediatek is moderated or > not. I have not subscribed to linux-mediatek and if it shows up quickly in > the archive, the list is probably not moderated; and if it takes longer, it > is moderated, and hence, validating the patch. I can affirm the list is moderated :) > > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5e6e36542c62..83c83d7ef2a5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13485,7 +13485,7 @@ F: drivers/pci/controller/dwc/pcie-histb.c > PCIE DRIVER FOR MEDIATEK > M: Ryder Lee <ryder.lee@mediatek.com> > L: linux-pci@vger.kernel.org > -L: linux-mediatek@lists.infradead.org > +L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) > S: Supported > F: Documentation/devicetree/bindings/pci/mediatek* > F: drivers/pci/controller/*mediatek* >
On Mon, 14 Sep 2020, Matthias Brugger wrote: > > > On 14/09/2020 07:31, Lukas Bulwahn wrote: > > Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller > > support") does not mention that linux-mediatek@lists.infradead.org is > > moderated for non-subscribers, but the other eight entries for > > linux-mediatek@lists.infradead.org do. > > > > Adjust this entry to be consistent with all others. > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > Maybe rephrase the commit message to something like: > "Mark linux-mediatek@lists.infraded.org as moderated for the MediaTek PCIe > host controller entry, as the list actually is moderated." > > Anyway: > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > > > --- > > applies cleanly on v5.9-rc5 and next-20200911 > > > > Ryder, please ack. > > > > Bjorn, Matthias, please pick this minor non-urgent clean-up patch. > > > > This patch submission will also show me if linux-mediatek is moderated or > > not. I have not subscribed to linux-mediatek and if it shows up quickly in > > the archive, the list is probably not moderated; and if it takes longer, it > > is moderated, and hence, validating the patch. > > I can affirm the list is moderated :) > Hmm, do we mean the same "moderation" here? I believe a mailing list with the remark "moderated for non-subscribers" means that a mail from an address that has not subscribed to the mailing list is put on hold and needs to be manually permitted to be seen on the mailing list. Matthias, is that also your understanding of "moderated for non-subscribers" for your Reviewed-by tag? I am not subscribed to linux-mediatek. When I sent an email to the list, it showed up really seconds later in the lore.kernel.org of the linux-mediatek public-inbox repository. So, either it was delivered quickly as it is not moderated or my check with lore.kernel.org is wrong, e.g., mails show up in the lore.kernel.org archive, even they were not yet permitted on the actual list. Lukas
On 14/09/2020 12:20, Lukas Bulwahn wrote: > > > On Mon, 14 Sep 2020, Matthias Brugger wrote: > >> >> >> On 14/09/2020 07:31, Lukas Bulwahn wrote: >>> Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller >>> support") does not mention that linux-mediatek@lists.infradead.org is >>> moderated for non-subscribers, but the other eight entries for >>> linux-mediatek@lists.infradead.org do. >>> >>> Adjust this entry to be consistent with all others. >>> >>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> >> >> Maybe rephrase the commit message to something like: >> "Mark linux-mediatek@lists.infraded.org as moderated for the MediaTek PCIe >> host controller entry, as the list actually is moderated." >> >> Anyway: >> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> >> >>> --- >>> applies cleanly on v5.9-rc5 and next-20200911 >>> >>> Ryder, please ack. >>> >>> Bjorn, Matthias, please pick this minor non-urgent clean-up patch. >>> >>> This patch submission will also show me if linux-mediatek is moderated or >>> not. I have not subscribed to linux-mediatek and if it shows up quickly in >>> the archive, the list is probably not moderated; and if it takes longer, it >>> is moderated, and hence, validating the patch. >> >> I can affirm the list is moderated :) >> > > Hmm, do we mean the same "moderation" here? > > I believe a mailing list with the remark "moderated for non-subscribers" > means that a mail from an address that has not subscribed to the mailing > list is put on hold and needs to be manually permitted to be seen on the > mailing list. > > Matthias, is that also your understanding of "moderated for > non-subscribers" for your Reviewed-by tag? Yes. > > I am not subscribed to linux-mediatek. When I sent an email to the list, > it showed up really seconds later in the lore.kernel.org of the > linux-mediatek public-inbox repository. So, either it was delivered > quickly as it is not moderated or my check with lore.kernel.org is wrong, > e.g., mails show up in the lore.kernel.org archive, even they were not > yet permitted on the actual list. > I'm the moderator and I get requests to moderate emails. I suppose I added you to the accepted list because of earlier emails you send. Regards, Matthias
On Mon, 14 Sep 2020, Matthias Brugger wrote: > > > On 14/09/2020 12:20, Lukas Bulwahn wrote: > > > > > > On Mon, 14 Sep 2020, Matthias Brugger wrote: > > > > > > > > > > > On 14/09/2020 07:31, Lukas Bulwahn wrote: > > > > Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller > > > > support") does not mention that linux-mediatek@lists.infradead.org is > > > > moderated for non-subscribers, but the other eight entries for > > > > linux-mediatek@lists.infradead.org do. > > > > > > > > Adjust this entry to be consistent with all others. > > > > > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > > > > > Maybe rephrase the commit message to something like: > > > "Mark linux-mediatek@lists.infraded.org as moderated for the MediaTek PCIe > > > host controller entry, as the list actually is moderated." > > > > > > Anyway: > > > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > > > > > > > --- > > > > applies cleanly on v5.9-rc5 and next-20200911 > > > > > > > > Ryder, please ack. > > > > > > > > Bjorn, Matthias, please pick this minor non-urgent clean-up patch. > > > > > > > > This patch submission will also show me if linux-mediatek is moderated > > > > or > > > > not. I have not subscribed to linux-mediatek and if it shows up quickly > > > > in > > > > the archive, the list is probably not moderated; and if it takes longer, > > > > it > > > > is moderated, and hence, validating the patch. > > > > > > I can affirm the list is moderated :) > > > > > > > Hmm, do we mean the same "moderation" here? > > > > I believe a mailing list with the remark "moderated for non-subscribers" > > means that a mail from an address that has not subscribed to the mailing > > list is put on hold and needs to be manually permitted to be seen on the > > mailing list. > > > > Matthias, is that also your understanding of "moderated for > > non-subscribers" for your Reviewed-by tag? > > Yes. > Okay, then I guess my patch is actually VALID and can be applied. > > > > I am not subscribed to linux-mediatek. When I sent an email to the list, > > it showed up really seconds later in the lore.kernel.org of the > > linux-mediatek public-inbox repository. So, either it was delivered > > quickly as it is not moderated or my check with lore.kernel.org is wrong, > > e.g., mails show up in the lore.kernel.org archive, even they were not > > yet permitted on the actual list. > > > > I'm the moderator and I get requests to moderate emails. I suppose I added you > to the accepted list because of earlier emails you send. > Okay, I see. I did send some clean-up patch in the past, but I completely forgot that, but my mailbox did not forget. So, now it is clear to me why that mail showed up so quickly. Thanks for the explanation. Bjorn, with that confirmation and Reviewed-by from Matthias, could you please pick this patch? Lukas
On Mon, 2020-09-14 at 16:01 +0200, Lukas Bulwahn wrote: > > > I am not subscribed to linux-mediatek. When I sent an email to the list, > > > it showed up really seconds later in the lore.kernel.org of the > > > linux-mediatek public-inbox repository. So, either it was delivered > > > quickly as it is not moderated or my check with lore.kernel.org is wrong, > > > e.g., mails show up in the lore.kernel.org archive, even they were not > > > yet permitted on the actual list. > > > > > > > I'm the moderator and I get requests to moderate emails. I suppose I added you > > to the accepted list because of earlier emails you send. > > > > Okay, I see. I did send some clean-up patch in the past, but I completely > forgot that, but my mailbox did not forget. So, now it is clear to me why > that mail showed up so quickly. > > Thanks for the explanation. AFAICT the linux-mediatek list isn't configured to automatically moderate messages from non-subscribers. Its generic_nonmember_action setting is 'Accept'. That is the default setting for lists on infradead.org and I strongly encourage list maintainers to leave it that way. Lukas, I don't see your address in the allowlist either. There are other reasons why some messages get might trapped for moderation — the message size, number of recipients, spam score, etc. The mere fact that *some* messages are moderated does not mean that the list is "moderated for non-subscribers" in the sense that the MAINTAINERS file lists. > Bjorn, with that confirmation and Reviewed-by from Matthias, could you > please pick this patch? I think we should be fixing the ones that *do* say it's moderated for non-subscribers, not the one that correctly didn't :)
On Mon, 14 Sep 2020, David Woodhouse wrote: > On Mon, 2020-09-14 at 16:01 +0200, Lukas Bulwahn wrote: > > > > I am not subscribed to linux-mediatek. When I sent an email to the list, > > > > it showed up really seconds later in the lore.kernel.org of the > > > > linux-mediatek public-inbox repository. So, either it was delivered > > > > quickly as it is not moderated or my check with lore.kernel.org is wrong, > > > > e.g., mails show up in the lore.kernel.org archive, even they were not > > > > yet permitted on the actual list. > > > > > > > > > > I'm the moderator and I get requests to moderate emails. I suppose I added you > > > to the accepted list because of earlier emails you send. > > > > > > > Okay, I see. I did send some clean-up patch in the past, but I completely > > forgot that, but my mailbox did not forget. So, now it is clear to me why > > that mail showed up so quickly. > > > > Thanks for the explanation. > > AFAICT the linux-mediatek list isn't configured to automatically > moderate messages from non-subscribers. Its generic_nonmember_action > setting is 'Accept'. That is the default setting for lists on > infradead.org and I strongly encourage list maintainers to leave it > that way. > > Lukas, I don't see your address in the allowlist either. > > There are other reasons why some messages get might trapped for > moderation — the message size, number of recipients, spam score, etc. > > The mere fact that *some* messages are moderated does not mean that the > list is "moderated for non-subscribers" in the sense that the > MAINTAINERS file lists. > > > Bjorn, with that confirmation and Reviewed-by from Matthias, could you > > please pick this patch? > > I think we should be fixing the ones that *do* say it's moderated for > non-subscribers, not the one that correctly didn't :) > Well, I am happy to send any PATCH v2. I guess we, you, David, Matthias and I, now just need to determine if the list is moderated or not. I will then adjust MAINTAINERS to the final conclusion. Lukas
On Mon, 2020-09-14 at 16:57 +0200, Lukas Bulwahn wrote: > Well, I am happy to send any PATCH v2. I guess we, you, David, Matthias > and I, now just need to determine if the list is moderated or not. It really isn't. # /usr/lib/mailman/bin/config_list -o- linux-mediatek | grep -B5 ^generic_nonmember_action # legal values are: # 0 = "Accept" # 1 = "Hold" # 2 = "Reject" # 3 = "Discard" generic_nonmember_action = 0
On Mon, 14 Sep 2020, David Woodhouse wrote: > > AFAICT the linux-mediatek list isn't configured to automatically > moderate messages from non-subscribers. Its generic_nonmember_action > setting is 'Accept'. That is the default setting for lists on > infradead.org and I strongly encourage list maintainers to leave it > that way. > > Lukas, I don't see your address in the allowlist either. > > There are other reasons why some messages get might trapped for > moderation — the message size, number of recipients, spam score, etc. > > The mere fact that *some* messages are moderated does not mean that the > list is "moderated for non-subscribers" in the sense that the > MAINTAINERS file lists. > > > Bjorn, with that confirmation and Reviewed-by from Matthias, could you > > please pick this patch? > > I think we should be fixing the ones that *do* say it's moderated for > non-subscribers, not the one that correctly didn't :) >
On Mon, 14 Sep 2020, David Woodhouse wrote: > On Mon, 2020-09-14 at 16:57 +0200, Lukas Bulwahn wrote: > > Well, I am happy to send any PATCH v2. I guess we, you, David, Matthias > > and I, now just need to determine if the list is moderated or not. > > It really isn't. > > # /usr/lib/mailman/bin/config_list -o- linux-mediatek | grep -B5 ^generic_nonmember_action > # legal values are: > # 0 = "Accept" > # 1 = "Hold" > # 2 = "Reject" > # 3 = "Discard" > generic_nonmember_action = 0 > David, I guess if you have access to the ground truth on lists.infradead.org, maybe you can dump the actual setting for all those lists? $ grep "lists.infradead.org" MAINTAINERS | sort | uniq L: ath10k@lists.infradead.org L: ath11k@lists.infradead.org L: b43-dev@lists.infradead.org L: kexec@lists.infradead.org L: libertas-dev@lists.infradead.org L: linux-afs@lists.infradead.org L: linux-amlogic@lists.infradead.org L: linux-arm-kernel@lists.infradead.org L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) L: linux-geode@lists.infradead.org (moderated for non-subscribers) L: linux-i3c@lists.infradead.org (moderated for non-subscribers) L: linux-mediatek@lists.infradead.org L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) L: linux-mtd@lists.infradead.org L: linux-nvme@lists.infradead.org L: linux-parport@lists.infradead.org (subscribers-only) L: linux-realtek-soc@lists.infradead.org (moderated for non-subscribers) L: linux-riscv@lists.infradead.org L: linux-rockchip@lists.infradead.org L: linux-rpi-kernel@lists.infradead.org (moderated for non-subscribers) L: linux-snps-arc@lists.infradead.org L: linux-um@lists.infradead.org L: linux-unisoc@lists.infradead.org (moderated for non-subscribers) L: wcn36xx@lists.infradead.org They are all reporting different settings and linux-mediatek and linux-arm-kernel even inconsistently. The inconsistency and a poor attempt to resolve that is what started this discussion. I can then send out the patch to adjust MAINTAINERS to your ground truth from the server. Thanks for your support, Lukas
On Mon, 2020-09-14 at 17:23 +0200, Lukas Bulwahn wrote: > > # /usr/lib/mailman/bin/config_list -o- linux-mediatek | grep -B5 ^generic_nonmember_action > > # legal values are: > > # 0 = "Accept" > > # 1 = "Hold" > > # 2 = "Reject" > > # 3 = "Discard" > > generic_nonmember_action = 0 > > David, I guess if you have access to the ground truth on > lists.infradead.org, maybe you can dump the actual setting for all those > lists? ath10k:generic_nonmember_action = 0 ath11k:generic_nonmember_action = 0 b43-dev:generic_nonmember_action = 0 kexec:generic_nonmember_action = 0 libertas-dev:generic_nonmember_action = 0 linux-afs:generic_nonmember_action = 0 linux-amlogic:generic_nonmember_action = 0 linux-arm-kernel:generic_nonmember_action = 0 linux-geode:generic_nonmember_action = 1 linux-i3c:generic_nonmember_action = 1 linux-mediatek:generic_nonmember_action = 0 linux-mtd:generic_nonmember_action = 0 linux-nvme:generic_nonmember_action = 0 linux-parport:generic_nonmember_action = 1 linux-realtek-soc:generic_nonmember_action = 1 linux-riscv:generic_nonmember_action = 0 linux-rockchip:generic_nonmember_action = 0 linux-rpi-kernel:generic_nonmember_action = 0 linux-snps-arc:generic_nonmember_action = 0 linux-um:generic_nonmember_action = 0 linux-unisoc:generic_nonmember_action = 1 wcn36xx:generic_nonmember_action = 0
On Mon, 14 Sep 2020, David Woodhouse wrote: > On Mon, 2020-09-14 at 17:23 +0200, Lukas Bulwahn wrote: > > > # /usr/lib/mailman/bin/config_list -o- linux-mediatek | grep -B5 ^generic_nonmember_action > > > # legal values are: > > > # 0 = "Accept" > > > # 1 = "Hold" > > > # 2 = "Reject" > > > # 3 = "Discard" > > > generic_nonmember_action = 0 > > > > David, I guess if you have access to the ground truth on > > lists.infradead.org, maybe you can dump the actual setting for all those > > lists? > > ath10k:generic_nonmember_action = 0 > ath11k:generic_nonmember_action = 0 > b43-dev:generic_nonmember_action = 0 > kexec:generic_nonmember_action = 0 > libertas-dev:generic_nonmember_action = 0 > linux-afs:generic_nonmember_action = 0 > linux-amlogic:generic_nonmember_action = 0 > linux-arm-kernel:generic_nonmember_action = 0 > linux-geode:generic_nonmember_action = 1 > linux-i3c:generic_nonmember_action = 1 > linux-mediatek:generic_nonmember_action = 0 > linux-mtd:generic_nonmember_action = 0 > linux-nvme:generic_nonmember_action = 0 > linux-parport:generic_nonmember_action = 1 > linux-realtek-soc:generic_nonmember_action = 1 > linux-riscv:generic_nonmember_action = 0 > linux-rockchip:generic_nonmember_action = 0 > linux-rpi-kernel:generic_nonmember_action = 0 > linux-snps-arc:generic_nonmember_action = 0 > linux-um:generic_nonmember_action = 0 > linux-unisoc:generic_nonmember_action = 1 > wcn36xx:generic_nonmember_action = 0 > Thanks, I will provide a suitable patch for MAINTAINERS. Lukas
On 14/09/2020 16:12, David Woodhouse wrote: > On Mon, 2020-09-14 at 16:01 +0200, Lukas Bulwahn wrote: >>>> I am not subscribed to linux-mediatek. When I sent an email to the list, >>>> it showed up really seconds later in the lore.kernel.org of the >>>> linux-mediatek public-inbox repository. So, either it was delivered >>>> quickly as it is not moderated or my check with lore.kernel.org is wrong, >>>> e.g., mails show up in the lore.kernel.org archive, even they were not >>>> yet permitted on the actual list. >>>> >>> >>> I'm the moderator and I get requests to moderate emails. I suppose I added you >>> to the accepted list because of earlier emails you send. >>> >> >> Okay, I see. I did send some clean-up patch in the past, but I completely >> forgot that, but my mailbox did not forget. So, now it is clear to me why >> that mail showed up so quickly. >> >> Thanks for the explanation. > > AFAICT the linux-mediatek list isn't configured to automatically > moderate messages from non-subscribers. Its generic_nonmember_action > setting is 'Accept'. That is the default setting for lists on > infradead.org and I strongly encourage list maintainers to leave it > that way. Ok, thanks for clarification. I never bothered too much with all the configuration option of the list. :| > > Lukas, I don't see your address in the allowlist either. I tried to find that in the web interface, but wasn't able to find the list. Regards, Matthias > > There are other reasons why some messages get might trapped for > moderation — the message size, number of recipients, spam score, etc. > > The mere fact that *some* messages are moderated does not mean that the > list is "moderated for non-subscribers" in the sense that the > MAINTAINERS file lists. > >> Bjorn, with that confirmation and Reviewed-by from Matthias, could you >> please pick this patch? > > I think we should be fixing the ones that *do* say it's moderated for > non-subscribers, not the one that correctly didn't :) >
diff --git a/MAINTAINERS b/MAINTAINERS index 5e6e36542c62..83c83d7ef2a5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13485,7 +13485,7 @@ F: drivers/pci/controller/dwc/pcie-histb.c PCIE DRIVER FOR MEDIATEK M: Ryder Lee <ryder.lee@mediatek.com> L: linux-pci@vger.kernel.org -L: linux-mediatek@lists.infradead.org +L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) S: Supported F: Documentation/devicetree/bindings/pci/mediatek* F: drivers/pci/controller/*mediatek*
Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller support") does not mention that linux-mediatek@lists.infradead.org is moderated for non-subscribers, but the other eight entries for linux-mediatek@lists.infradead.org do. Adjust this entry to be consistent with all others. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- applies cleanly on v5.9-rc5 and next-20200911 Ryder, please ack. Bjorn, Matthias, please pick this minor non-urgent clean-up patch. This patch submission will also show me if linux-mediatek is moderated or not. I have not subscribed to linux-mediatek and if it shows up quickly in the archive, the list is probably not moderated; and if it takes longer, it is moderated, and hence, validating the patch. MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)