| Message ID | 20201228135038.28401-1-zhengyongjun3@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [-next] pci: hotplug: Use DEFINE_SPINLOCK() for spinlock | expand |
On Mon, Dec 28, 2020 at 09:50:38PM +0800, Zheng Yongjun wrote: > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). See this again: https://lore.kernel.org/r/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> > --- > drivers/pci/hotplug/cpqphp_nvram.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/pci/hotplug/cpqphp_nvram.c b/drivers/pci/hotplug/cpqphp_nvram.c > index 00cd2b43364f..7a65d427ac11 100644 > --- a/drivers/pci/hotplug/cpqphp_nvram.c > +++ b/drivers/pci/hotplug/cpqphp_nvram.c > @@ -80,7 +80,7 @@ static u8 evbuffer[1024]; > static void __iomem *compaq_int15_entry_point; > > /* lock for ordering int15_bios_call() */ > -static spinlock_t int15_lock; > +static DEFINE_SPINLOCK(int15_lock); > > > /* This is a series of function that deals with > @@ -415,9 +415,6 @@ void compaq_nvram_init(void __iomem *rom_start) > compaq_int15_entry_point = (rom_start + ROM_INT15_PHY_ADDR - ROM_PHY_ADDR); > > dbg("int15 entry = %p\n", compaq_int15_entry_point); > - > - /* initialize our int15 lock */ > - spin_lock_init(&int15_lock); > } > > > -- > 2.22.0 >
diff --git a/drivers/pci/hotplug/cpqphp_nvram.c b/drivers/pci/hotplug/cpqphp_nvram.c index 00cd2b43364f..7a65d427ac11 100644 --- a/drivers/pci/hotplug/cpqphp_nvram.c +++ b/drivers/pci/hotplug/cpqphp_nvram.c @@ -80,7 +80,7 @@ static u8 evbuffer[1024]; static void __iomem *compaq_int15_entry_point; /* lock for ordering int15_bios_call() */ -static spinlock_t int15_lock; +static DEFINE_SPINLOCK(int15_lock); /* This is a series of function that deals with @@ -415,9 +415,6 @@ void compaq_nvram_init(void __iomem *rom_start) compaq_int15_entry_point = (rom_start + ROM_INT15_PHY_ADDR - ROM_PHY_ADDR); dbg("int15 entry = %p\n", compaq_int15_entry_point); - - /* initialize our int15 lock */ - spin_lock_init(&int15_lock); }
spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> --- drivers/pci/hotplug/cpqphp_nvram.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)