diff mbox series

PCI: endpoint: Select configfs dependency

Message ID 20210125113445.2341590-1-arnd@kernel.org (mailing list archive)
State Accepted
Delegated to: Lorenzo Pieralisi
Headers show
Series PCI: endpoint: Select configfs dependency | expand

Commit Message

Arnd Bergmann Jan. 25, 2021, 11:34 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The newly added pci-epf-ntb driver uses configfs, which
causes a link failure when that is disabled at compile-time:

arm-linux-gnueabi-ld: drivers/pci/endpoint/functions/pci-epf-ntb.o: in function `epf_ntb_add_cfs':
pci-epf-ntb.c:(.text+0x954): undefined reference to `config_group_init_type_name'

Add a 'select' statement to Kconfig to ensure it's always there,
which is the common way to enable it for other configfs users.

Fixes: 7dc64244f9e9 ("PCI: endpoint: Add EP function driver to provide NTB functionality")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pci/endpoint/functions/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Wilczyński March 7, 2021, 5:36 p.m. UTC | #1 
Hi,

[...]
> The newly added pci-epf-ntb driver uses configfs, which
> causes a link failure when that is disabled at compile-time:
> 
> arm-linux-gnueabi-ld: drivers/pci/endpoint/functions/pci-epf-ntb.o: in function `epf_ntb_add_cfs':
> pci-epf-ntb.c:(.text+0x954): undefined reference to `config_group_init_type_name'
[...]

Thank you for fixing this!

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Krzysztof
diff mbox series

Patch

diff --git a/drivers/pci/endpoint/functions/Kconfig b/drivers/pci/endpoint/functions/Kconfig
index 24bfb2af65a1..5d35fcd613ef 100644
--- a/drivers/pci/endpoint/functions/Kconfig
+++ b/drivers/pci/endpoint/functions/Kconfig
@@ -16,6 +16,7 @@  config PCI_EPF_TEST
 config PCI_EPF_NTB
 	tristate "PCI Endpoint NTB driver"
 	depends on PCI_ENDPOINT
+	select CONFIGFS_FS
 	help
 	  Select this configuration option to enable the NTB driver
 	  for PCI Endpoint. NTB driver implements NTB controller