diff mbox series

PCI: rcar: Fix runtime PM imbalance in rcar_pcie_ep_probe

Message ID 20210408072402.15069-1-dinghao.liu@zju.edu.cn (mailing list archive)
State New
Headers show
Series PCI: rcar: Fix runtime PM imbalance in rcar_pcie_ep_probe | expand

Commit Message

Dinghao Liu April 8, 2021, 7:24 a.m. UTC
pm_runtime_get_sync() will increase the runtime PM counter
even it returns an error. Thus a pairing decrement is needed
to prevent refcount leak. Fix this by replacing this API with
pm_runtime_resume_and_get(), which will not change the runtime
PM counter on error.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
 drivers/pci/controller/pcie-rcar-ep.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
index b4a288e24aaf..c91d85b15129 100644
--- a/drivers/pci/controller/pcie-rcar-ep.c
+++ b/drivers/pci/controller/pcie-rcar-ep.c
@@ -492,9 +492,9 @@  static int rcar_pcie_ep_probe(struct platform_device *pdev)
 	pcie->dev = dev;
-	err = pm_runtime_get_sync(dev);
+	err = pm_runtime_resume_and_get(dev);
 	if (err < 0) {
-		dev_err(dev, "pm_runtime_get_sync failed\n");
+		dev_err(dev, "pm_runtime_resume_and_get failed\n");
 		goto err_pm_disable;