From patchwork Fri Nov 19 00:38:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kelvin Cao X-Patchwork-Id: 12628027 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02AF1C433EF for ; Fri, 19 Nov 2021 00:39:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC5F561AA7 for ; Fri, 19 Nov 2021 00:39:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233687AbhKSAmT (ORCPT ); Thu, 18 Nov 2021 19:42:19 -0500 Received: from esa.microchip.iphmx.com ([68.232.153.233]:39910 "EHLO esa.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233678AbhKSAmS (ORCPT ); Thu, 18 Nov 2021 19:42:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1637282358; x=1668818358; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IVS4zJZCWHQBaTlisa8bNfSi3Y6NeWW4bfoJMvMTDoA=; b=abJitUNNdXbtmcJUuLnRPmSds6hnuFeoFHO5Z2s6vQOj4VGhOgQysIdL aLINQJtM1NsGjBlh85ZBqpMce4mkhn+HWPWxTa7KZTixKW6c/sb5CPVBf YYmov8AtXAdiDhuyFm8DRMMym7W4fePNI0x9eqqUC4Nz+TKDHfwGFJzq6 vYGyXmo6GHHP+6M9ir7QagDrBAOT/doNDbzK+rWNc1HAo0UabktzlT35L WAXeQUitXcny3f4XLC9gJa1N2sMImZ7QC8FnADJXrflg/r/+3B2se8wOl AfokOFSOpI3DHmWfzKH80QAFXbHSUIh+A6baJSm3Zic7MPx5TNyR6BjUu g==; IronPort-SDR: RLLN5VBYeVoEeGAuMN33eheFkYjohIEV5IWfwE6dcykDjnsEuAHXSPlWDW2Sj0VUEgr7b/MJi3 XI9D7S71jIABicSjb7K2maKWvyPk9RCOoBoBkB1MnqskhPx0ocPfcyMLbeEjL1S6XsDBIFo3u8 HoSvITaYmoB8s35VIQPXa3v4CHc6+FO0MHYhaA3EGoccc0WAYfO52KXp75uM7BVseTmOum5gmK AHdeq4v/sRxpNKZhik8qMzf/QMz90c/BwB/OgC57vWcgLX/zWK+BnyDjvZfjzPEGUKlkvMXQUy pTX6JoZOtIg0gUQkpnAFrSGK X-IronPort-AV: E=Sophos;i="5.87,246,1631602800"; d="scan'208";a="143882522" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 18 Nov 2021 17:39:18 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 18 Nov 2021 17:39:16 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 18 Nov 2021 17:39:16 -0700 From: Kelvin Cao To: Kurt Schwemmer , Logan Gunthorpe , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , , CC: Kelvin Cao , Subject: [PATCH 2/2] Declare local array state_names as static Date: Thu, 18 Nov 2021 16:38:03 -0800 Message-ID: <20211119003803.2333-3-kelvin.cao@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211119003803.2333-1-kelvin.cao@microchip.com> References: <20211119003803.2333-1-kelvin.cao@microchip.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org When a MRPC command is being executed, the function stuser_set_state() will be called several times to set the command execution state. During each run of stuser_set_state(), the local array state_names is allocated and populated. The array contains a constant mapping of the state enum values to the text strings, so repeated allocation and initialization is just a wait of CPU cycles. Therefore, declare the array as static. See the link below for the discussion. https://lore.kernel.org/r/20211014141859.11444-1-kelvin.cao@microchip.com/ Suggested-by: Krzysztof Wilczyński Signed-off-by: Kelvin Cao --- drivers/pci/switch/switchtec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c index 6e2d6c5ea4b5..c36c1238c604 100644 --- a/drivers/pci/switch/switchtec.c +++ b/drivers/pci/switch/switchtec.c @@ -122,7 +122,7 @@ static void stuser_set_state(struct switchtec_user *stuser, { /* requires the mrpc_mutex to already be held when called */ - const char * const state_names[] = { + static const char * const state_names[] = { [MRPC_IDLE] = "IDLE", [MRPC_QUEUED] = "QUEUED", [MRPC_RUNNING] = "RUNNING",