diff mbox series

[1/2] PCI: qcom: Drop unnecessary <linux/interrupt.h> include

Message ID 20220722154919.1826027-2-helgaas@kernel.org (mailing list archive)
State Accepted
Commit 4e4ad1bfefa8d148caf45b058f10bb7f3933f27b
Headers show
Series PCI: qcom: Minor cleanup | expand

Commit Message

Bjorn Helgaas July 22, 2022, 3:49 p.m. UTC 
From: Bjorn Helgaas <bhelgaas@google.com>

pcie-qcom.c uses nothing from <linux/interrupt.h>, so remove the
unnecessary include of it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/controller/dwc/pcie-qcom.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Johan Hovold July 26, 2022, 12:21 p.m. UTC | #1 
On Fri, Jul 22, 2022 at 10:49:18AM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> pcie-qcom.c uses nothing from <linux/interrupt.h>, so remove the
> unnecessary include of it.

Appears to be unused since commit 7c5925afbc58 ("PCI: dwc: Move MSI IRQs
allocation to IRQ domains hierarchical API") so there may be other
driver that also no longer need it.

> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Bjorn Helgaas July 27, 2022, 7:28 p.m. UTC | #2 
On Tue, Jul 26, 2022 at 02:21:14PM +0200, Johan Hovold wrote:
> On Fri, Jul 22, 2022 at 10:49:18AM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> > 
> > pcie-qcom.c uses nothing from <linux/interrupt.h>, so remove the
> > unnecessary include of it.
> 
> Appears to be unused since commit 7c5925afbc58 ("PCI: dwc: Move MSI IRQs
> allocation to IRQ domains hierarchical API") so there may be other
> driver that also no longer need it.

Thanks for digging that out!  You're right, there's a long list of
drivers that include <linux/interrupt.h> but don't appear to need it.
I'm going to drop this patch and try to do them all at once.

> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
diff mbox series

Patch

diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 3a3e667c3408..c27e3494179f 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -12,7 +12,6 @@ 
 #include <linux/crc8.h>
 #include <linux/delay.h>
 #include <linux/gpio/consumer.h>
-#include <linux/interrupt.h>
 #include <linux/io.h>
 #include <linux/iopoll.h>
 #include <linux/kernel.h>