From patchwork Thu Aug 11 20:33:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Conor Dooley X-Patchwork-Id: 12941715 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 998F4C19F2A for ; Thu, 11 Aug 2022 20:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235764AbiHKUd3 (ORCPT ); Thu, 11 Aug 2022 16:33:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235793AbiHKUd0 (ORCPT ); Thu, 11 Aug 2022 16:33:26 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B9AB9F0F5 for ; Thu, 11 Aug 2022 13:33:19 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id z16so22486407wrh.12 for ; Thu, 11 Aug 2022 13:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conchuod.ie; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=QxkmtF8asgPVQHFJENq/ehachAsL+qmscZvCCu05yWc=; b=XaRcrphLz19LTNxZ0dzKwHA8K/MkiviSjiw49WVWXeVE5qRONAyZyq8QlcuzrvefVq DVNMQX04znal0vPNRmcNC3MbIYAUaAwumKVcp1t0JK2JWpjZ/cp5ve/O9xgtHIB9jYp1 a8nRH+Wy1LAZE51EqhGYykiH3KzE9PEX9dP0kwd3yenGFVrqs5lMmYFvz3ozZW8IIaAJ Bj4EyFhC9G2D5gf3y3F2K/Htv7ZqH11Y9ovKD1Bz7OjfH17QcK/dDGLuF9YkGgrMvCco 4DIJtEW+NiKBMz3o+dzkdKU5lyhNrWpghKTXW2kDbXlMfdJOmER6MuwSLRX/k4n+MNIT Ftcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=QxkmtF8asgPVQHFJENq/ehachAsL+qmscZvCCu05yWc=; b=2Oc9s5AW6KUY/cqim0HTavPRub/ctHXPj9YeMrtpGZBqwcQmJyb3stCJWv+L1I5T0K ixREnIvWEBOuqwAEXaHcEMcLa6X2YsQBHi2O+N5jA1xqFIckm1Vun//rCkK/dPuiui5r bSItjkkB3pvbTyWztN9I0IyD5lx8SjYd+rXcB/7rM6EkYTeQcj2zPkEsJKe1mkqcpr1y 8WI0u0rudwazPNU0lhxRLzZJU79QPXhb18J/RImPcawl0qoZTsQ9uuG+W+hsE/cbbapG 8tceWFSDBRivOJXctgSqI/7hX7jI80gL9pg3lXmbLMwtof+bXcOruNsRt1RoczoDWL/a DP+Q== X-Gm-Message-State: ACgBeo3nd8RzcB3SoMakHkG7K6tFkdiPAXoQjyY3gMQtLubah2jYzGxD hlD9tQOq2wj9g311uIqGrRDkNw== X-Google-Smtp-Source: AA6agR5//7v1W6BSWMIoYqn+Fu+wgEM3FNII37M+y/PlRKeC6C5AWj7949Ozxp/ApCOBEqaRSPZzpw== X-Received: by 2002:a5d:59a5:0:b0:222:c5a5:59c4 with SMTP id p5-20020a5d59a5000000b00222c5a559c4mr337239wrr.656.1660249997915; Thu, 11 Aug 2022 13:33:17 -0700 (PDT) Received: from henark71.. ([109.76.58.63]) by smtp.gmail.com with ESMTPSA id i12-20020adfefcc000000b0021f1ec8776fsm86643wrp.61.2022.08.11.13.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 13:33:17 -0700 (PDT) From: Conor Dooley To: Daire McNamara , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Greentime Hu , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Conor Dooley Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH 2/4] dt-bindings: PCI: microchip,pcie-host: fix missing clocks properties Date: Thu, 11 Aug 2022 21:33:05 +0100 Message-Id: <20220811203306.179744-3-mail@conchuod.ie> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220811203306.179744-1-mail@conchuod.ie> References: <20220811203306.179744-1-mail@conchuod.ie> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org From: Conor Dooley Upgrading dt-schema to v2022.08 reveals unevaluatedProperties issues that were not previously visible, such as the missing clocks and clock-names properties for PolarFire SoC's PCI controller: arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dtb: pcie@2000000000: Unevaluated properties are not allowed ('clock-names', 'clocks', 'legacy-interrupt-controller', 'microchip,axi-m-atr0' were unexpected) From schema: Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml The clocks are required to enable interfaces between the FPGA fabric and the core complex, so add them to the binding. Fixes: 6ee6c89aac35 ("dt-bindings: PCI: microchip: Add Microchip PolarFire host binding") Signed-off-by: Conor Dooley --- .../bindings/pci/microchip,pcie-host.yaml | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml index edb4f81253c8..2a2166f09e2c 100644 --- a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml +++ b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml @@ -25,6 +25,31 @@ properties: - const: cfg - const: apb + clocks: + description: + Fabric Interface Controllers, FICs, are the interface between the FPGA + fabric and the core complex on PolarFire SoC. The FICs require two clocks, + one from each side of the interface. The "FIC clocks" described by this + property are on the core complex side & communication through a FIC is not + possible unless it's corresponding clock is enabled. A clock must be + enabled for each of the interfaces the root port is connected through. + minItems: 1 + items: + - description: FIC0's clock + - description: FIC1's clock + - description: FIC2's clock + - description: FIC3's clock + + clock-names: + items: + enum: + - fic0 + - fic1 + - fic2 + - fic3 + minItems: 1 + maxItems: 4 + interrupts: minItems: 1 items: