| Message ID | 20221013183854.21087-12-vidyas@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | Enhancements to pcie-tegra194 driver | expand |
On Fri, Oct 14, 2022 at 12:08:44AM +0530, Vidya Sagar wrote: > Tegra PCIe endpoint has a common interrupt that notifies hardware events > like link up, LTR send, etc. DMA completion event is also notified over > this interrupt. Remove IRQF_ONESHOT flag from interrupt registration and > allow DMA driver to share this interrupt. Please give a clearer explanation of why this is safe and the reasoning behind this change. Lorenzo > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > --- > V3: > * This is a new patch in this series > > drivers/pci/controller/dwc/pcie-tegra194.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > index 7820bf4b9786..786e5d5f43b9 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -2354,7 +2354,7 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) > ret = devm_request_threaded_irq(dev, pp->irq, > tegra_pcie_ep_hard_irq, > tegra_pcie_ep_irq_thread, > - IRQF_SHARED | IRQF_ONESHOT, > + IRQF_SHARED, > "tegra-pcie-ep-intr", pcie); > if (ret) { > dev_err(dev, "Failed to request IRQ %d: %d\n", pp->irq, > -- > 2.17.1 > > > -- > linux-phy mailing list > linux-phy@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/linux-phy
On Fri, Oct 14, 2022 at 12:08:44AM +0530, Vidya Sagar wrote: > Tegra PCIe endpoint has a common interrupt that notifies hardware events > like link up, LTR send, etc. DMA completion event is also notified over > this interrupt. Remove IRQF_ONESHOT flag from interrupt registration and > allow DMA driver to share this interrupt. I don't understand the rationale behind this change, please elaborate on it. Thanks, Lorenzo > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > --- > V3: > * This is a new patch in this series > > drivers/pci/controller/dwc/pcie-tegra194.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > index 7820bf4b9786..786e5d5f43b9 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -2354,7 +2354,7 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) > ret = devm_request_threaded_irq(dev, pp->irq, > tegra_pcie_ep_hard_irq, > tegra_pcie_ep_irq_thread, > - IRQF_SHARED | IRQF_ONESHOT, > + IRQF_SHARED, > "tegra-pcie-ep-intr", pcie); > if (ret) { > dev_err(dev, "Failed to request IRQ %d: %d\n", pp->irq, > -- > 2.17.1 > > > -- > linux-phy mailing list > linux-phy@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/linux-phy
diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c index 7820bf4b9786..786e5d5f43b9 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -2354,7 +2354,7 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(dev, pp->irq, tegra_pcie_ep_hard_irq, tegra_pcie_ep_irq_thread, - IRQF_SHARED | IRQF_ONESHOT, + IRQF_SHARED, "tegra-pcie-ep-intr", pcie); if (ret) { dev_err(dev, "Failed to request IRQ %d: %d\n", pp->irq,
Tegra PCIe endpoint has a common interrupt that notifies hardware events like link up, LTR send, etc. DMA completion event is also notified over this interrupt. Remove IRQF_ONESHOT flag from interrupt registration and allow DMA driver to share this interrupt. Signed-off-by: Vidya Sagar <vidyas@nvidia.com> --- V3: * This is a new patch in this series drivers/pci/controller/dwc/pcie-tegra194.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)