From patchwork Tue May 7 18:45:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13657555 X-Patchwork-Delegate: kw@linux.com Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2045.outbound.protection.outlook.com [40.107.15.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE7B16D4FA; Tue, 7 May 2024 18:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.15.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715107589; cv=fail; b=GKQlYalqlREiCXktgip80euLihPm7tj9YDQzbbiTU1oazVdI8VWsCJ8a5psWmGW2md7Z/78czuGJyvFE0CmpYYnqvAxF/Y+KPfwMXOze4XTp0pNiTk4OvlmqLtGmOysVUWHHwhHiLLoYG8577sjMkisALmpI1gnqQcssxaJBqgY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715107589; c=relaxed/simple; bh=YcV+bPfbQ8hPERCV2SDvifRpdqJ80QqWgg+hJThYFEQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kqP1+TCzu/CzqK9l8YJLKcPlyRcgELuDC34678RPcRk/CZleyE4RHS4b5senfFIL1m/T6qRz9vZr6ucCAjcrvPP7VvyH3iXxZjfMKgT6NVqcFUq2FbXQDE8w5u1A8+LhQFfS0GU2IXPoniTQJ4kwSQbNsNtFLihh64UQxP+SoQ0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=mPyY7mSE; arc=fail smtp.client-ip=40.107.15.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="mPyY7mSE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mv6diUiM95Eu1f5Qu98gYoFhdKy1IJDvX2CGZlGAQh5gOKa4yp1+T4E7iGDjiEJqtns0iXUYYmoOyrHoxtZwtMJv/YbecXhUy2Xdhx77XH58XyiyMeVQUv0EK1Ikl/p6CXnMF/ZBF4mp9SETd1qhq3/cPMddAjQmFlENWwaXViSoXjkNLW5Pha+QC3KTxLrSE3hgOQFn4Myjz0cA9fKAi10SWQvXJ9dMt4tOTrBwx9oxUSrivqJXKP1fpqAqyucZOnd7VNtIEcgKLF1d9zwhArYp1qHLovhCvxwVv9bd/SyaAOiD+6Rn6OTYRTqXs/6MkCPMxlyd8ZYWZD1j7qALoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vNogCV8zOg8H4Xb+q+NRE8ieQG+DU65n0HRUvVRx0GM=; b=dYZ0KDicNlRd4Y7XfbMuEzy/XpPCNitPtjNIW4b/7QoqrTzx/rGGEVd2k4nCATYrG162PRToF3K7Mb5oPebS3zFyZNyHoPFaVjxkGBDIKdm+/C6104nx6E+dj/byWSu8OmcLS2Q/GxxoaONktB0yFWj9SHYh9Raa3oVQ/wjIdH2rZTtBCIjAk1lm4N8P4kv8uyMJU2n0J3e4GheI7cMv9Ff1TECzdCuG9YTmhG2IzP+RbjrvubohrdhxcjqvhMJHDVhpGSWkMb0KyYXlQ0+IOFurj4Fc/hGsj8nifolo4cME3WnXvWOMMOy0wmnANPwiHE0ij1USOVBAdHrQUxYLUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vNogCV8zOg8H4Xb+q+NRE8ieQG+DU65n0HRUvVRx0GM=; b=mPyY7mSERXgH/us2NuPCyyeJL3DGanG0Md3X9f2dahFKyPAabBDFYSpVy2aBktSPJZ7s+DqDuv3LwQXXYqgKB8eBXaTJGbOxuJmvgXteM9bv9D82NAoz/LpD2qlVAUzXCsDhzXSIuvVlrUeCdLRP9OFvYnfsVWezQQue9IBJY5A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DB9PR04MB8204.eurprd04.prod.outlook.com (2603:10a6:10:240::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Tue, 7 May 2024 18:46:25 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::1e67:dfc9:d0c1:fe58]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::1e67:dfc9:d0c1:fe58%7]) with mapi id 15.20.7544.041; Tue, 7 May 2024 18:46:25 +0000 From: Frank Li Date: Tue, 07 May 2024 14:45:39 -0400 Subject: [PATCH v4 01/12] PCI: imx6: Fix establish link failure in EP mode for iMX8MM and iMX8MP Message-Id: <20240507-pci2_upstream-v4-1-e8c80d874057@nxp.com> References: <20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com> In-Reply-To: <20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com> To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1715107574; l=1456; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=xoxDn+MAsMCimd0wOl6G3C1M0+8a1hMq0JrOR9jgWlM=; b=txg6As3KcI6mOVHnc0/xjYotiu8vNM79HNmEQ+CdRoAqJpUEZyzcsWQ8ZM5IFKNj6T6qZT/X3 maY87uil+5ZC3yKRyYRq1BDgEZfXWkehY48e56/mddt6SXn6YRcVqcp X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0026.namprd17.prod.outlook.com (2603:10b6:a03:1b8::39) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DB9PR04MB8204:EE_ X-MS-Office365-Filtering-Correlation-Id: b0a883aa-a5ca-4916-c539-08dc6ec5ffb6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|7416005|1800799015|52116005|376005|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?q?QJOwZ5IrY3/OtaxygpaSlaF8Xo0RtH2?= =?utf-8?q?3ATpJ/kIOP8Lrz0E0bMFfCFMJaQPuqLnjzh9M35Jn+AkyF/bOGvSK1xMr3Xmi/G9U?= =?utf-8?q?RJfPvxuYaJJEfqpuf+0MmQPlhQqLKHNM58deelFauC9w6kCesWPXWyqXQrnMwq9h1?= =?utf-8?q?Ns1DYb1J8QNIzfhHkjW9F9Um4e14+x6rpBQq0ITAmkZwOzKzXpptJFyvDrb4KPk8b?= =?utf-8?q?drlgT16LWfL0sT609pZDzF3OsG3BWgkE7MSnM2iqINGWC0w43gWvZf4NDdxvOce//?= =?utf-8?q?SJSIM+S9Zm0890g/Yu/vODEU+wTW6Wt6SQKWYsL2c6N98u772rYZd1j5gUgh1IPeu?= =?utf-8?q?McqX7f5tzuhCXrCtuSrmY2OA2CV7CwPW68e3Gfl3dE/IXCmI6wyxV2pdpFFCSSwbF?= =?utf-8?q?zC1P4ULVuWDx1Dxl+U0MK5+2e2/QFOzFMb55H5+4guUOpMdGsIF8nrMy1VfhFUQBi?= =?utf-8?q?qvAXtwdO4Uo6uclD3l1cj1YhfXOSEz03vHOgnE9HUCCfJ65KFX2PT7xCEhBZ9w7nx?= =?utf-8?q?2xHchkNh91+0u3DEaFF0H56H3m8XUkVpvBlPZK7c3fVV6lJ2AqTI9Q3E9KV9l00pg?= =?utf-8?q?0ThY5LWZ/6Ytc2ZnXXHecPmyIljAooFTHtG7sx63TWbjb+3s50HX88RyMKbQhzCQb?= =?utf-8?q?zCMZkiFDVlSzcryQK+FAMefWvksvz4YLt+OtxvGkdfG6WnLnLX3fBwlDobwxiwBct?= =?utf-8?q?TsJEYVwtL2J1IG9D7E+DMRTCPIlv4W2WcaOFlNjpsG4MqvhRv7EwvdvqyuCxQrNRw?= =?utf-8?q?OP+GcDCLWZKyCG40S9ZmSzIyMAWJcEUj8mw7pZZvNbVa0KfWuiFUIr7rHn8I0L7vt?= =?utf-8?q?1UviiN8zLhGECZCT7mpHP8pfOEBrLXBnVut2M53Jl5loGYH2bs8fFfKyKW6cujU7W?= =?utf-8?q?Cnuo1N6uK+6t0dlGAIgzvOJ9rZPlvYZ06+tLhC/YH1H99tWoCGsUDIKUjoY9mpHOs?= =?utf-8?q?vgRJz8Gg78TZEznlpx54kQUiI0ivq78fGaG9tA2CfzeGWA6DmBjhE8ujORatwEqcQ?= =?utf-8?q?nJXPAucIvpHJCMDm1ucXJpJgc6fefFKVAGejGDB8A6dBSIrH2LLeAsH22NYChZQF5?= =?utf-8?q?mnT209jMThA1iGYFoqRXUNypGvtyIA8udPp53m9Ud8NuXuAEPphIJtERf9ItTnCIz?= =?utf-8?q?0Rd9odJzuorTDctzlXCE44oQvaMZQWrnR4s+lsMnsB5GGsFQyacJGoYRKWvE09Epj?= =?utf-8?q?85iw94OnbAJDPI0u2yGQC8TGfW96t9t9PXOpiZ64vJDCx/oN1peI3OTzVZVdi/Q8o?= =?utf-8?q?hx7f1QbtfyZDN4Iwy2TC2Q2ven0O2AGqjz1Qs7fwfrNsN3zrvBn8t4aE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(1800799015)(52116005)(376005)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?nXRZLL6H/2vNUq3Rg835h9YhVc4V?= =?utf-8?q?LmKgREfDnJkJkGpgUevcPExOSBLEfO9fGE7bREI7/Dwyatw5e71UG4zoilxhR6qdJ?= =?utf-8?q?0L3nX8Cpt1QNvJSK15UNnwTKtFisAzhr0nfS2pBIPb7pI6uP8T2VcZxmOOHymo03s?= =?utf-8?q?CmYXlq19fdUf+I4U4KQu2TBLwa6PedQkfqJOtv3oJXmi7LnSOaV2qUVGaPxWq3bZp?= =?utf-8?q?nITQj9nIUeuXk88o1gFPPspQYc7D/+7xxOLD+8YYkXBW5iv0u65uvSCM7MImxkj0Z?= =?utf-8?q?KFgGvC/VJBRPS+6nCZcoia88NERQtuApnsPEETooqbcR0xDMCy+Mhxb7tVYD20kZg?= =?utf-8?q?xk8gy9jsMDkyJ2sde+WrgwSpZDcDisBM+KtLyXJEfb4Yzvnc/w/aPc3ZeCGiSL8Yp?= =?utf-8?q?DuXS4PbxPhiQNsb2GXHLLLzhZgX2zn5/u1DT19e0tYFItzOhG/tldeCPs91PPy4IL?= =?utf-8?q?cX31P+X2Koi4i0OwEatJ6nmw71XmLth1+RArsnWlcnMxDYBRhO/SGJRXzVwEGlPcI?= =?utf-8?q?vHIvx2a5pj5ms2CFtCnP5Hw552V63el9feDWrGLmScOkQp0y6qJ7YiJdC7+/uHi4Q?= =?utf-8?q?rxfkIWSw/zUO+1OnPCAwmwQKjiKnNEUG6WrJ7nQyPtUSn3T//hjQ8Z7PkaigcDXav?= =?utf-8?q?Xk3zMybQLCvi6rXDHzCS2mhc4z2fRHcv3LOJ0LOATRqatzmE66/JqcHroUU0bNI7c?= =?utf-8?q?hGp80bXkDPFXhpVzPV0DvbfcaZ1WPXDgGyI3nbFu8iOKhw7UqnirDw15Yowau0s7z?= =?utf-8?q?cCyVhJB7QoJ0C+fjMu6hqi1pppy3hOOhpfLfO5iotD4TJgiaJZcHg6RlbGVuLeJU1?= =?utf-8?q?no9ZubaCbkjKDl42fE/avJi3b7tLnni5KVufXFWJJyUd6NH242aH6cQUeaov+4GQc?= =?utf-8?q?scbPHWI/FIt/uwLrzps4Zbl+ZiUU6PSdk1oX5KFAnvB+JFeBcvvBm1HK+HKAF6U2T?= =?utf-8?q?zO4l8q5uNZVdEZdDz+87Mc1JWri8tM1wCS6+gG5TNZyQdhbDbK5jHh6VcYpD6PSeV?= =?utf-8?q?x3lnOVMU0rmGmRkOZ1TRLXv95mMrV6/376pN0yJ+B8dYtkKVF4bgB6HuvQXcUBo4y?= =?utf-8?q?O2kzTXjs45z/2a/iAfh46E5T9JtC3Z0tP7A66FIUPQUeNt1ydLR2KLOINBvFLB7UM?= =?utf-8?q?V7JP0HxMoawaHMJgvtC+/v5y7Xr6Nznl5oBtLwmpzeFeCF2uUJWmjKeJDWavi/zlQ?= =?utf-8?q?ZeeI+F9dmdzOY0nCzICSCjpilySrWd9z2gl7o3vwnsii0AuWrfGmy3FPXfwSZOH/Y?= =?utf-8?q?hnwcYiuXeyTdK884ZZDb1vVz3w+4gBMbj8mPw7PTi36D5sytGkRrHN/C26v29o+Cl?= =?utf-8?q?M8sA9eAyXFUrRnjTen8Xr16VBtyNeIHa30mUggInJqkzdE6/qCp0r9WHxv81u44vW?= =?utf-8?q?WsUd8GYEhbaouNQgUG4dN6tE8Xp/2gcERoT3c0VdE7UynmedvEjll6zHl6REaR2cS?= =?utf-8?q?2r1oo8+5qIQhv4NNlDGzcildsb4US6/3J4OlEcMkjRvqZCb7oqYJa9ZQHKOAckoNV?= =?utf-8?q?s7vJC2AJldt4?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0a883aa-a5ca-4916-c539-08dc6ec5ffb6 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 18:46:25.8500 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G9tM9vHOWeDxWLNloUwmejTGTR2Uopf+f/2HHieWGAgcPq/Q92bUBzPczK7hzWqChZKjm1gjaPpJQSMrgTEiQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8204 From: Richard Zhu Add IMX6_PCIE_FLAG_HAS_APP_RESET flag to IMX8MM_EP and IMX8MP_EP drvdata. This flag was overlooked during code restructuring. It is crucial to release the app-reset from the System Reset Controller before initiating LTSSM to rectify the issue Fixes: 0c9651c21f2a ("PCI: imx6: Simplify reset handling by using *_FLAG_HAS_*_RESET") Signed-off-by: Richard Zhu Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 99a60270b26cd..e43eda6b33ca7 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1568,7 +1568,8 @@ static const struct imx6_pcie_drvdata drvdata[] = { }, [IMX8MM_EP] = { .variant = IMX8MM_EP, - .flags = IMX6_PCIE_FLAG_HAS_PHYDRV, + .flags = IMX6_PCIE_FLAG_HAS_APP_RESET | + IMX6_PCIE_FLAG_HAS_PHYDRV, .mode = DW_PCIE_EP_TYPE, .gpr = "fsl,imx8mm-iomuxc-gpr", .clk_names = imx8mm_clks, @@ -1579,7 +1580,8 @@ static const struct imx6_pcie_drvdata drvdata[] = { }, [IMX8MP_EP] = { .variant = IMX8MP_EP, - .flags = IMX6_PCIE_FLAG_HAS_PHYDRV, + .flags = IMX6_PCIE_FLAG_HAS_APP_RESET | + IMX6_PCIE_FLAG_HAS_PHYDRV, .mode = DW_PCIE_EP_TYPE, .gpr = "fsl,imx8mp-iomuxc-gpr", .clk_names = imx8mm_clks,