From patchwork Tue May 7 18:45:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13657565 X-Patchwork-Delegate: kw@linux.com Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2047.outbound.protection.outlook.com [40.107.8.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 920B616D9AC; Tue, 7 May 2024 18:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.8.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715107647; cv=fail; b=W8KQJ4Q5+h40ZvpZfZaF68T9PHFNg3mPSoAPQPZsEaylvKsnWJq2p+c1TwcSW8EUX9NHms4+lhPu12kT3b6kpa4x/8LMVKpj7jz2C2gjo4Wi7Yt9QIn9FDhReZ/DUxHpgl/RlqWP0bkY6F7dYqus+P/OlaWW7tS894kkYcnZ7n0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715107647; c=relaxed/simple; bh=rRm5SujhEiX9hVYVjrxBprduIqi9bHP431kr+qPwfZU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=FelqPxWTz34Cb6my9812JjQU+SohXLexrNO1/OZaxOlC19gJITP/RefXojUfq+bObGJHy6bLyYd+c/2MztzYB9KPuBphduEbK8Onz2Px1iG3CbAM7iHmswzr9gYux0jXWY6qA69iqDzFSEee6MOx5Arb58LYB8tNrDb69NwfyGk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=pj48bWJx; arc=fail smtp.client-ip=40.107.8.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="pj48bWJx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BVC0slsCU7m6rwCaqyU0zemLyqnpdMNp4/iBP1A0gATqMJ1S/lok8CgSg/V/C78FNhHI8JZmSa8tJ4S3fX6L1mer3lx24/ZrpnWzNr2NTvqRfusiAQQCLt+puocB4OJ/1Xd4eiDXAj2kKYivPI56CtMD5QSwoOJsIMWZ3Bmxt12AbLWIt/Bi5ptzvJXTum0Rxg6xVFXO30zUmj8N+w38Im9WegGGgKT25AO8akFGhnPXMmyx8NHxsflfOZA8FP5zzK7ZGX5vVTILiJ2zm0ybv66Um5TiXCgko87QcMyRJCXoRfDt1rSM682gF1YnJGz5fbSyh2dpleYS+6Fm/WUO1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3gTTDoBfA/yf91PPA7MqT/q+r+bNwi1FVYdnjZCH/pM=; b=AY2iTw9Rt+1nZPoVfXCpaRXzhL+ij8CHgco5qb7EqRaCAG3mT86wFxS1C2y+yqEwvJaOUvmx17q/8JVp0pmWVxsygSqGsC7TBHMUW77nhXg3lq5ePgFpltsQ2nZKd6dqvBuE27cMGT6c9GdmcH5VDBsLrJWt3nJmiFZN9NoaTR9sgxhD3EDq/dCsiJ+hdWWY1NSg9MOv6O93foeVRqnXtqxJfzxXZywcmTFImsip/D9TU6YXY6BJz+fFFnpFng+BeCOb2htK6Kn1TzH3Y1sWvKdVduDhpaWsIRavXLfFg9NCMLfhBOiRZJIRn0kkeWjkpCJjdSeQbXTR4hegnYDlww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3gTTDoBfA/yf91PPA7MqT/q+r+bNwi1FVYdnjZCH/pM=; b=pj48bWJx3lGiBnoAHuTDveo/2hVXXWvQXRKRg8ZhyodlObgQiMLuQ9dTCJ0NQXPRhPXICQbejmbCAg8o7Q3EWryvI40z7FpRgu0QKlYLJioMsNY/ZSeGeMkGuHu1lcBThziwXGc4iAe+p7WtSRV+958TekhI9LpCN2H9bURyPgM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DU0PR04MB9636.eurprd04.prod.outlook.com (2603:10a6:10:320::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Tue, 7 May 2024 18:47:22 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::1e67:dfc9:d0c1:fe58]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::1e67:dfc9:d0c1:fe58%7]) with mapi id 15.20.7544.041; Tue, 7 May 2024 18:47:22 +0000 From: Frank Li Date: Tue, 07 May 2024 14:45:49 -0400 Subject: [PATCH v4 11/12] PCI: imx6: Call: Common PHY API to set mode, speed, and submode Message-Id: <20240507-pci2_upstream-v4-11-e8c80d874057@nxp.com> References: <20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com> In-Reply-To: <20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com> To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1715107574; l=2344; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=rRm5SujhEiX9hVYVjrxBprduIqi9bHP431kr+qPwfZU=; b=WnHtWsp2PCQ89Q1ObmF3XJCsbhZXA9pISVqfFPDcdZvNNlXxL+QnVzS9Awh0VaZGnDJc4pQFV LpJsjSeWcV8AYCsOyL7PfeeZ2dJyupXyMN5LEntzJxC+NB0RcLE+lhY X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0026.namprd17.prod.outlook.com (2603:10b6:a03:1b8::39) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DU0PR04MB9636:EE_ X-MS-Office365-Filtering-Correlation-Id: 577e8acb-a1d5-4427-4e5e-08dc6ec62161 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|376005|7416005|52116005|366007|921011|38350700005; X-Microsoft-Antispam-Message-Info: =?utf-8?q?gpFbGQ0Q8Bu2KdG4H8gQ6LcpKbRQ5SB?= =?utf-8?q?EsvwUSBHKQoFBE351kBYK/sZF2YDu0ry9sjfuRksRsZ0853w8GBT5G2w2plsseQRl?= =?utf-8?q?pMdczNRQKxkTQO68rvtFW60qZ/sCdGr+wPnyL9K0lSdSTH+gZ1CIBKt/J7R7gVHRZ?= =?utf-8?q?Lk5/LQUqwIPIDgEatqpWAAMJuKAHiFSgAFv0C0Kjau5l6o+wP0Canl44Qayd3rOS4?= =?utf-8?q?Sy9Voz2sYjq28Y9tRbqy3V9aBhmx7yaAZFj5JKNeeb3QrH8queJboR8iJFCqpiRnG?= =?utf-8?q?8QT5P7elM8frymUtSi2AUnQesHSb8KURMyuzWA/PFAiTFP95r0b9+IoRtWxpHKR3o?= =?utf-8?q?lPJN+Qz1jSIT1WaAJTCgvguTMsABw4AcSmYVvYDe5Kz9SyjwmMFi22eJMCkDKqCqi?= =?utf-8?q?wr3Lm1n3Hg5PGcYbRDQqvIKTZMNjSVVm523LXNuUGGbohfrP01hkAqBkd1kZVj76m?= =?utf-8?q?km3+fpHmZOw8TjZp/3dptym9TFT6qSFmdY1nZizQnGyzlecaNNGv05ZNPH15GvQN0?= =?utf-8?q?dif3PdeifvkLn8S1d8f1nGBIJBTtsO29Zpzes65kv72PJiI8IvRmOImLeZuAJgUlQ?= =?utf-8?q?i1WeixQfHHc1Qt3PRE+dWQqrkm+UOYwg/B12Hey7CmgCWzyrlMz4az2L1U+u+muDd?= =?utf-8?q?Jvi54N4yW063zGSvCfNC15j6HinAxUabptG8s5QjL739+A07wl/zcfJp48k05t3L4?= =?utf-8?q?zHHBITvUIRXFS9+5AbRHtXvjCE+6gGyRxEPpeAwsrxxtlN8psgplbwufaHEawQ5iz?= =?utf-8?q?ySE7fFLxMkSsiNrts+af/UE/bfxuMmzhmhU7Smtj2LWokAedhrO6BCGDTVP0x8nZ0?= =?utf-8?q?9GlJAVdGz4bqyNFOnME034EWQnTthmo+e/U37sQjW3Ez622EcHavrWfgZAdapeK9Y?= =?utf-8?q?Q26zoX5tHZT2M6QH+QIIXIOgUo2kpRGTmMWkaV6ARJZqVuK6IMctc6udoZigh/KW1?= =?utf-8?q?gqYFpHNuvScnM3cx9y6xSyaCkn2qDv0wERBGtWIyUgC0pNMtkDgWlR/ICp7FYl5eI?= =?utf-8?q?R0is+6xm/sbSkgRAPatOtgIz192UuLJVGIcWEKakRNG6HugAEGmPLYdFvT/TxtJ4S?= =?utf-8?q?HO/Qpa1aVQa/nmyBL25FsW4sX3P8//77eAGOuG33Q5DSaFqwWSyEAtiy3BK/MFzSW?= =?utf-8?q?1HCHR3KGYrSymgMJwPEknDZhiLjJLkmTeOoxQAblaOnJ0J88EcUJfNkinW1mApHav?= =?utf-8?q?+YBcAMb9WXSPiRBSpBEDvizlVVgfHZb39ApzPJ+aV90ywDqAaLnoYZEkVz8Y1KNG4?= =?utf-8?q?08cLo92bDZJYDjGigmK+vCZ4EclE0+r+0aNCD7nMV6kpUmSh4B9pDLSk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(7416005)(52116005)(366007)(921011)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?R+vQTVb7HgUpIXIhMmRRmtR7mStM?= =?utf-8?q?a/2rWRiAyvN5sXiLTWS2CThtPO1g3Yjqd+IMeB1iTK4x8AFTWL7Bbf6+cA0g+mcap?= =?utf-8?q?3GC/3c4VxmEbuCgiKTvFWbPTShnfxqzxgit5cdXhxGtAB0PartM8EZecxIBl6G8MC?= =?utf-8?q?uY3RRw6/oEK67N8cMim+h1Jg+yg/UgbV4B1y3UUgKf/5f10bW+XFlZpoBRylrKY5f?= =?utf-8?q?ORii49fpcg51CtSPF3G7HEuNul09L7x//cajE6DOPQjZJlYPA6eQkH9IEfVXlTK2k?= =?utf-8?q?9heIVU2PNnB83rFoy42E6j99e8VhN0vNwDVIBdfplE9vkKRCkSujjtZ8xbnN8NPrZ?= =?utf-8?q?eZtN4aj7QM3s1Q/mPAoeNRqZEj3Kcz6K3Hi0JaEC1B95DjEBO+7elLl7wOGru043x?= =?utf-8?q?ydzWAyL2U/RDNMJmh1HjRuHyLojuEKsWz1Is4FZT4kurzXkT2OXXQRyVWRKr0ZIk9?= =?utf-8?q?+lyFEcpPXbIi1sBIiKiGiupMi2y8jnpr70YH1QsBxPFaF/7OzAwGW45cIHy5QxBWW?= =?utf-8?q?yQ6+p0CgXKF0/FLYce7+bF+BA5kUvLvFWAmgMnzJ0xwlPKPKIVAwgKkvzR8eSVJtF?= =?utf-8?q?D0335czkb2Qv277zVyS1XNvOnWO+D/8w/2dpxMGkXFesvhHRJI2FmiUz7lVJ2uZMi?= =?utf-8?q?LJ8hqbP8t69Bfx7+F9gUMkHUXH8PUBTBhPVzjy0K4hlGbQYL5pjb62xJieFZG1UFy?= =?utf-8?q?nVTLCxYQt2IJBZUkGVynamP/HWPX6Ck9NL4meAa0cZjVVXCs6miqJZvEUMqGxL/qK?= =?utf-8?q?noXsZdhb7Jwb/BmqtGki2Q5/cEIIQhMGVegFyk2f8ZBgfmw04gSlgf57fY+HwUXwQ?= =?utf-8?q?ArWJgzXX7FYENeV9+QSJMbeJc+2bt7qQBgQZL7GlSIyDHxTkghDMM2lly2SuVsSZ2?= =?utf-8?q?NSF0nd01uSeiL1+gMtVbzVgwK1QxPOire2Tb2fcpRiJlVgJlIOksHiKzEwAXMY8Z3?= =?utf-8?q?HOR+Y1BpO0MOYY/eRzbRz9BDq9HoQQuoKfx4AJVF9c+Q5q+lnuPtMNoYb312EOnjK?= =?utf-8?q?WweBg8hYwwPViAte5dpZRQnyAUFzy+2q/MHFE80NuU+b1OdwQykTZJ+efPApB7naR?= =?utf-8?q?Q5x92xDWEdxIZspVMocxkoaMtnFpYGFOvk/uxoj5s4LMvSRwNxLxShTuAAyM6gNWT?= =?utf-8?q?BYxb5av2rdCIzpFw0Igs0bLqIj/NdOYqw94DCZJbnZMPxJToqpv/GiLXq1IKd/cmm?= =?utf-8?q?bhPu/jL2M5UW1heNRfvCYPglB3moDUlO81eu9AVmH9VLmTsP2oWUcY0SM/xORWi4U?= =?utf-8?q?oW3iz8O0xE3TzuPBRwiE+YRNQYUlf0wsQ4pIF38wI5uN1iNNRhxJxiuKF1eitzvAR?= =?utf-8?q?Iqpt8lVGNBXocGTbTL3BdQuHBTLvnUgIHqVsEBcS+REiWvS3TrmP4Z3DYKCiYBWHD?= =?utf-8?q?raT++WrODjNBLfr3mUGJVzdr0B8e5U15h1xLcO+jiU6aQc0XMwEAlvO3tfxWyKGhj?= =?utf-8?q?PRXQR08SF/f1Et+ou7BHceddu3F0tABAcJBNoYO9vaMWNV9HVYsut6AQfuVyj9HMW?= =?utf-8?q?xwjwCZzJ9Xj5?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 577e8acb-a1d5-4427-4e5e-08dc6ec62161 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 18:47:22.3242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nvrNUWcSTYaHBRMGb/2tH2Oe3m8IcLfb1K1D352gy2T62g3yZIPHSLBCLJfG77LzK/rhBQvymM9HjEJa/MGoyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9636 Invoke the common PHY API to configure mode, speed, and submode. While these functions are optional in the PHY interface, they are necessary for certain PHY drivers. Lack of support for these functions in a PHY driver does not cause harm. Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 9d53b545540c6..df623977d8fe6 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include @@ -308,6 +309,10 @@ static void imx_pcie_configure_type(struct imx_pcie *imx_pcie) id = imx_pcie->controller_id; + /* If mode_mask[0] is 0, means use phy driver to set mode */ + if (!drvdata->mode_mask[0]) + return; + /* If mode_mask[id] is zero, means each controller have its individual gpr */ if (!drvdata->mode_mask[id]) id = 0; @@ -887,6 +892,7 @@ static void imx_pcie_ltssm_enable(struct device *dev) struct imx_pcie *imx_pcie = dev_get_drvdata(dev); const struct imx_pcie_drvdata *drvdata = imx_pcie->drvdata; + phy_set_speed(imx_pcie->phy, PCI_EXP_LNKCAP_SLS_2_5GB); if (drvdata->ltssm_mask) regmap_update_bits(imx_pcie->iomuxc_gpr, drvdata->ltssm_off, drvdata->ltssm_mask, drvdata->ltssm_mask); @@ -899,6 +905,7 @@ static void imx_pcie_ltssm_disable(struct device *dev) struct imx_pcie *imx_pcie = dev_get_drvdata(dev); const struct imx_pcie_drvdata *drvdata = imx_pcie->drvdata; + phy_set_speed(imx_pcie->phy, 0); if (drvdata->ltssm_mask) regmap_update_bits(imx_pcie->iomuxc_gpr, drvdata->ltssm_off, drvdata->ltssm_mask, 0); @@ -1034,6 +1041,12 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) goto err_clk_disable; } + ret = phy_set_mode_ext(imx_pcie->phy, PHY_MODE_PCIE, PHY_MODE_PCIE_RC); + if (ret) { + dev_err(dev, "unable to set pcie PHY mode\n"); + goto err_phy_off; + } + ret = phy_power_on(imx_pcie->phy); if (ret) { dev_err(dev, "waiting for PHY ready timeout!\n");