From patchwork Tue May 7 18:45:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13657556 X-Patchwork-Delegate: kw@linux.com Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2051.outbound.protection.outlook.com [40.107.15.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28E0C16D4F6; Tue, 7 May 2024 18:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.15.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715107595; cv=fail; b=Fi2KPRByk+KgYHQP2vBe51jW3HDz66vvC9vUWj/DMdlqdgjrUHssZprq6BRG8UwDmCJoigF9ZxN8W9vX13/egqU6DiYHbM6M1jstPvwBs+hUKg9L9VQCGu5GjXLC6jchmblF48TsCuVZEI2qIDOXHha1z7EqQfIy6tAcPd7mB8A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715107595; c=relaxed/simple; bh=OgpauZFcGum+MIZkOfelPjFuUuL0H86OUPMoXcG8FfA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=G6pGG9RI9DSt7dolpK58mUnmPpYjauUcXncQwAxPfGkNqnP7w48EqHFm9oi3NYD66KaWLDMFKtZEnxNTmlJJ6FccZ8ubdReTPi2OyOFq0oxQyWKQ+3I+uf+hNXWgYekGNdnOKSKQ0MOEE65vNs5gx6ultnpmZnBcAg0cvYs0J5k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=kA5dPyB2; arc=fail smtp.client-ip=40.107.15.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="kA5dPyB2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IMjsteSB8W0YXCpAvrCc/ogQip0X8Fw3L7yPbDyLpFEUJg2shX1IYPvZnfWB7NnX9N8yBxH6N+qUDixeEKmuw8Ms2mNbVBnPwz2rmkxQ2YagcCI2RJSHfP0HAZe9CP4zSdtTBkGTrYlNHRu/FA5x4RDpWOk6k2QdY0tWHI4UAg6OFpa2F6hdXyG6YPc8TcmoLD7r8Cw8bVPoWjnFYUnocHvLd89VwAnoCHlgu1gODHnorqFo+8JuVVE1Gp40onK3lNfk6vAmoxZ1VTCbRL9iVHORY+5CBd2qEDFcZ3g9jF6UoXwubo3xyNuPTS8bgmzNbMs4GSWCVhGCd3GxKixi8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zrkaTSZzqqw8GcBn/WHt/2B3DkpbPCMJ0WUaK9Q0H5k=; b=Duc2VXJm2+T9+jPBk7whvHD79m+GjrPMVZ82AM4SxIb1QYSFHHhtQQT7HOpD5nD1BV0SEVldVRM51c+YZS6SPMPfoDM8DjQCdkw10SLncMcWZkBMGd31+2+Jt0z3Lw5hORy+hfqvPG9pxBfMq96JAhfHYZWv6aqJ18FDAvF2jUFrp8PBvUWm0r+R4+vOGYOnLMR75xNZT9W4830+WUOlXW4YhSUBJr1jSEuxREqn/naJB7rTFZ8Dng1VooKSMGpt+Qa6L9kGoes7GxNoMNsMIOPXRdesIe9/bzkGuPEnjDLJ2EeGUhs87/8EFOl8wAuJVCFLp8GYMOM5KBWm0WMAlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zrkaTSZzqqw8GcBn/WHt/2B3DkpbPCMJ0WUaK9Q0H5k=; b=kA5dPyB2T75oPiOQkMN7xCJblS5kKeBwA+zzTyao0cdOrlsz8D+HrEQCAhLr3u20w+Yhvs7USQ/PRm31dKgI8uqic9XkUdGPJATykcueaR20QNrOxA4Cv1P3RNC9M071Hfi6bcaFjk6H9rBesi2VPj71PzVUtrnG+iuMAW+KM+s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DB9PR04MB8204.eurprd04.prod.outlook.com (2603:10a6:10:240::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39; Tue, 7 May 2024 18:46:31 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::1e67:dfc9:d0c1:fe58]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::1e67:dfc9:d0c1:fe58%7]) with mapi id 15.20.7544.041; Tue, 7 May 2024 18:46:31 +0000 From: Frank Li Date: Tue, 07 May 2024 14:45:40 -0400 Subject: [PATCH v4 02/12] PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI Message-Id: <20240507-pci2_upstream-v4-2-e8c80d874057@nxp.com> References: <20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com> In-Reply-To: <20240507-pci2_upstream-v4-0-e8c80d874057@nxp.com> To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Frank Li , Jason Liu X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1715107574; l=1357; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=ol8CdKOtRGfAfsl8PVkNMeRQytaQpVg/b6Q5f4hgeBo=; b=kfE4VU+auk2OhfU4mAa+5x3eXAFW2Gnjj2rphlD9YN/sg5IHSwSNmM4pIo1eWAPtsBvzc7ar0 h4B6uEzoTytCPYgT70kExZGyRcVHi8AxIORRMbJVl13dpRqeKpzZbyP X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY5PR17CA0026.namprd17.prod.outlook.com (2603:10b6:a03:1b8::39) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DB9PR04MB8204:EE_ X-MS-Office365-Filtering-Correlation-Id: 21d98d75-2c3c-4153-5e34-08dc6ec60317 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|7416005|1800799015|52116005|376005|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?q?AFF0zKpWxvHHFFievnuHLISiMi7Kkjj?= =?utf-8?q?nvzCwdM1QJbt24TcM9xIGk3HVRlqE2ujmLkyl04Fy5wHOwcbwBytYf4T5c2P9UNQ5?= =?utf-8?q?UPmIF2BCdyJKH4+CG+nRFzNGBU9El6dRE9zmu+Kvz4iL0uWMMYdPgcyQmJHSdh92c?= =?utf-8?q?YLWDhf3LnnA/TDpwu3dP6sFPBupVagHRrmV9EeCASgJXICbFCiWgvWS4L53sbFQp8?= =?utf-8?q?7iiBV1iI/a7u2oLUpamJg4vvG5isHx4fpIX5GNDvevfSE50ZkYJZn26/V2BPek20C?= =?utf-8?q?Jyy/b4MOsl6uVQLGGynZV8wvCd1RZ5n9z6FDUJiB3ROgTeIGnYQsuiiV9HMcqgD/5?= =?utf-8?q?RDkHTf6XGJocQE/iyhCRzd+cRoVnBQhNIsTx6bEL4bAX2j0aAZuulN8QSIAr8M6to?= =?utf-8?q?nco8aCOrwHyy2AqVhxpvE8N9fsVtKtoRFloVbU+rqT1ssG0JO8DakYd0wAPMMnHA3?= =?utf-8?q?VAo2p4Ry0YO17G2/ic4rQpsqBITSCLyzDtxk0u/pCdi5lwuq80Vsq3YAw9Wo5M3la?= =?utf-8?q?0zdmI8hQVgzSgTo2sl9W6EqmaFpMsNh0mPtizNwnFEVcEaxk6cwf8Bq1LS59GwXzH?= =?utf-8?q?vK5DPBEFkJr4YMdklbZnVcuIvJT9y0OL4NqWhGd03gm8SEDhqSLiLEjcX3SI0F6ra?= =?utf-8?q?P8MXEWz7hPvJEvVyvyaVwElKDmEY1apLFJ+zYkMqOCPJRR65tLVkadNnTEJCaALQd?= =?utf-8?q?jeHN6q1ySNOq7CLUgz1Zhz6DyZt6e2uINM+/mrndiPcWjF+lS1ZKPbpKhMli60Vdw?= =?utf-8?q?iCXKdQAXTcqozO7joKqmPwkIlUKsdKAYvr5M42qktmFagsv+JY+T4JjNjGL4sVvJN?= =?utf-8?q?vNKZjg8/+bQYRgYPGFogmF1Q2ITbeK818KgzBTTEaheVrj0/OAlaRhLG5Fqq2rHlx?= =?utf-8?q?amq0RKaKFbCIRQOjgeEcnsuoQsRgVbbDD0NMkoblznxNN+7xHLg6ajp2s0kGujn04?= =?utf-8?q?A9ebKzP9QFZDXMD7e04LYBbm2VZUajgPO5I6w8jQSut4eFk2GSVf0xewpRuXuL0xu?= =?utf-8?q?M8kSioq5cHCyGKDerDv29/4tRSx9+YEdyL2CrJktaGsnLn8JTCMBjUe0J2ao4iMhe?= =?utf-8?q?nFUYR3T5M0PT00H8X77hOxZNO08pAsCKf34GS373bkjdnXYKmvOIyA6eslRXzPe9W?= =?utf-8?q?XVU+pPsZdclnJ7WjURyXJfWM1X5d5K3LZ8oCiMNfyl9GfbMRC+y/JcTyE2FiWlLRD?= =?utf-8?q?11uMtMNf1I9ep8KKo+YkC0o42x27YgNG2p7IRzKde6bMLICGiYYf7ZcKB51Wl6LSr?= =?utf-8?q?jdd35zjCIhrseex5YY7o7UwStUYRaFIcDgefp3Da2i1y9qdcxkYdatGI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(1800799015)(52116005)(376005)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?+VmpgFMwI0sjoRoK6xd0VgI09zmo?= =?utf-8?q?6Hf2iUTWaYo3kQD9Ay9rqdHQ9EUED7zZOgrdfeCvSyKDG1wL2bPB0lQnbDyeNCMal?= =?utf-8?q?01dcxhNeCUVvs3hREe1RYvRTar36RipxFUQpQU2Agk89NFSS+9Kmxd2Xbl863CvkK?= =?utf-8?q?thDv6ZBlCTiEr+QWHCfhiwOxUxw0zzlvDte8t156HPl6uri9QDHmoYL2alCFV5L8g?= =?utf-8?q?QoHVjIYiKG+rN9q964jQFJ7isWPCTXQtli/RNdOSzRW5L+sEfyK+58q7vn5xS3uEe?= =?utf-8?q?uMFuhe1YOxg0289SJMnKZlznojXqpnxwFSZTgjLR0yaDYe3IxqfZz+GfeoKCeIdCP?= =?utf-8?q?KuhOrxf/vhOB3lZ8XJQXdpfILBROrQTOc/kPrvkQ+OXCYlyLoEcFf4npTX8zaZhp2?= =?utf-8?q?inqe6K652tcDMkPwW9zbZsIByOYUaUwkoG+KkA2ISCtU+qWo1c5fpBY/2fKNw/9nt?= =?utf-8?q?GezZ66ZjKcNj9U6tCzB8DxkbkrVtgxHuy2WOneSmBUhcxzA8If0uiaYsQwrNOz1Kv?= =?utf-8?q?kAAHlFmBE3+d8MDH0IZPG6seP9yDz+t63kDgBlSTwRJRm51LFx6p3iugsjUcD6ggo?= =?utf-8?q?Yri6jgi/houf67pfl1RfvQBtqR0MzuZ7AoJgnAqWVQEg2tHDUG9r0AvWS0uR7x2S+?= =?utf-8?q?201ZWZUyiv/vqjeSx2QAwubsxSf66ungoLuXSo7XQa+x0MaM/yIQwkK5KFV2Pgokj?= =?utf-8?q?47oJH3ff2eCG37oNWgZLha+1NkQ+2vzNRc/bfkC2zptAhyfma7Ar0GwIB7JBpkTgt?= =?utf-8?q?E6R8KeFJENTAe/DAEd7/lD1j3wSCwsScZjwe29hujRLKW11CjbaAAvqTd4nkg/n66?= =?utf-8?q?6gqbuvQfkIeMo6GtGAPE7Ihqq1n64p7LsipXI7HVyv4Rki6ScNhTP89af9pJnUgf+?= =?utf-8?q?ZS+N1mRw2Sgu34ufomA43RYnZgg63pxx0JV6Mt6akxXgC2L0aDmepynGhnqjgvOGJ?= =?utf-8?q?eR+VqV5wqGlVz1o1ImmplfCNzO2b2H/z6vmtiMVA3rC8AJtEhRWMoHr9K/ob8p6s4?= =?utf-8?q?cuzZR28ARgv2XdRA/thDIQyZDjUqeTjajFLyHb94hB3n4fEphPTUFeeY55hPuvJfo?= =?utf-8?q?jPOSairxrp/OnhWSNrsKMprte4qsN7iB1mwjkomiK7ceYVj4YjRU3/rndFwJ/zTDz?= =?utf-8?q?CkMNK/2bdPcO+qAME9yK6QeFWWfTIMvz6tK02pwxkQTanqU8zLqj6U8lhTcYMjfAC?= =?utf-8?q?89dxqAwecykaFcZzFWBGh+rMNqdGTlgiWNzR3FYaQzTSNsGI/UGcE+ZAfM6SbjHRR?= =?utf-8?q?2tBK6jaOoGdfu2ynB6sKuBBJqJogUcmMPSSjCsHKCacgRxONNjeMB/z956d08/xX7?= =?utf-8?q?fYKlXzwhGK9qvGNd3MiHFCqpdIM9QUfKt3KPfaFV4VDspwm1LUEixHF+2xJFLt9Hi?= =?utf-8?q?2T6pBAI0mJPK+r6GUQnE0i4mly2quw8TUXkjDTZngoTFS47AQIQOi2r5HXkaLaL5h?= =?utf-8?q?9an/eyCL8QHCPHsVdF1bW4s3JDRdox55iIFYHyHMxlwQVg2ogARtv3IoE9tQ1f+LX?= =?utf-8?q?uIM1aqjiNcE6?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21d98d75-2c3c-4153-5e34-08dc6ec60317 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 18:46:31.5050 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +4Eyfj4Df6/2karId8j7zLFiljMXNwsHVqZVzqwxrwyKCntBHXWljCfu+lLb4vLbYVzDIRjS4Yd5x9tAe71uxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8204 From: Richard Zhu Correct occasional MSI triggering failures in i.MX8MP PCIe EP by apply 64KB hardware alignment requirement. MSI triggering fail if the outbound MSI memory region (ep->msi_mem) is not aligned to 64KB. In dw_pcie_ep_init(): ep->msi_mem = pci_epc_mem_alloc_addr(epc, &ep->msi_mem_phys, epc->mem->window.page_size); Set ep->page_size to match drvdata::epc_features::align since different SOCs have different alignment requirements. Fixes: 1bd0d43dcf3b ("PCI: imx6: Clean up addr_space retrieval code") Signed-off-by: Richard Zhu Acked-by: Jason Liu Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index e43eda6b33ca7..6c4d25b92225e 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1118,6 +1118,8 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie, if (imx6_check_flag(imx6_pcie, IMX6_PCIE_FLAG_SUPPORT_64BIT)) dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); + ep->page_size = imx6_pcie->drvdata->epc_features->align; + ret = dw_pcie_ep_init(ep); if (ret) { dev_err(dev, "failed to initialize endpoint\n");