diff mbox series

[v3] PCI/AER: Log error message if there are too many PCI devices with errors

Message ID 20240605230954.22911-1-jain.abhinav177@gmail.com (mailing list archive)
State New
Delegated to: Bjorn Helgaas
Headers show
Series [v3] PCI/AER: Log error message if there are too many PCI devices with errors | expand

Commit Message

Abhinav Jain June 5, 2024, 11:09 p.m. UTC
Added pci_err() to log PCI device information on which iteration fails.
Added pci_err() to log note if there are too many failed devices.

Signed-off-by: Abhinav Jain <jain.abhinav177@gmail.com>


Changes since v2:
 - Switched to pci_err() to log failing PCI device
 - Included the historical note below the "---" line
 - Fixed other style changes in the patch
 drivers/pci/pcie/aer.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
index 8b820a74dd6b..0bca83827ac1 100644
--- a/drivers/pci/pcie/aer.c
+++ b/drivers/pci/pcie/aer.c
@@ -882,11 +882,13 @@  static int find_device_iter(struct pci_dev *dev, void *data)
 	struct aer_err_info *e_info = (struct aer_err_info *)data;
 	if (is_error_source(dev, e_info)) {
+		/* Log error for the device */
+		pci_err(dev, "Error detected on device: %s\n", pci_name(dev));
 		/* List this device */
 		if (add_error_device(e_info, dev)) {
 			/* We cannot handle more... Stop iteration */
-			pr_notice("%s: Cannot handle more devices - iteration stopped\n",
-					__func__);
+			pci_err(dev, "Too many error devices encountered. Stopping iteration.\n");
 			return 1;