From patchwork Mon Jul 29 20:18:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13745671 X-Patchwork-Delegate: kw@linux.com Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2057.outbound.protection.outlook.com [40.107.21.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D30F18EFCF; Mon, 29 Jul 2024 20:19:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.57 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722284369; cv=fail; b=q0G/HTzTX+cvS9NKZZLvvisxSCZ7mfRFK34qbYhR8OwedMYUxAZSk1lX5es4un7GfAPnefjbp0QIxQ00Cj+0MrH3f4rHhlDKrLOBi8p9wmRq3KgOc5TUhAh9kFJqQHK7VPehYfl0Dkh4qtZeydDcX3neVaRzFVafNPA06i+vl/I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722284369; c=relaxed/simple; bh=TNSd+b5y2IdUI30Q9idwzdMxK5IHuQjkFajPvbPUy8I=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=gNwEYFCcgzq+jRfO9WjmmEA22NcclTtuUSsss3dgrjZUB1RDVRXZKCD9VqCTNYDSdO8BB420xFxsxqXjPtC6gx1XNV5iwR9wTKrK7H77ehRQ84TaLh+gxEO+pLiTx+wtMaId8CDFnNdtZVKSEOanMaP3Ph3RU7gxSPngJEhuwYk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=GoOyB+GZ; arc=fail smtp.client-ip=40.107.21.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="GoOyB+GZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Btr5xMXflJ2MxvcJzeLsNR96hHd90NQceLYel/LqyMm/iqj0bjwMJJrYJ5vvDKA7zDZiuLfqOElIQMWY+BAdtGwtv5IxQxIKbX8SP2yIyKttsMgBLgLIlN+yEBwelcYxBbaqHIJF9gyVSJEexiO3yF+rziQUN3wuCymkXmYBKAE/LZ1oPgRuaJrgpLbhCNnWXBt0gFPE6vXERYTHsvum9OtbzKsGaK7QzZlSAwCV7doRkoKyq30GuOz4PFRRgBS0v6w7eX2vbRFxKSQjyjJ3qSwGxHQgHztOcgFuOQksCxdAJ343xEmoM1knw05KRy3DkPoi+wZC964dUlSB5FOLvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JgP2ZgQ8Y17baGCLCTwEGc6nED28+XLD9ppoSRJTCow=; b=LEGfBer9sHSNb/cEq2W5fd3QX0WKR4PS2mIColnSqZNcFjE1nPdn2/L+H3QiEr/xh7IkH67wilteZ53dU4Tlc07On1Txsa846tXFEzFBKpAtU+svj7vfILRW3gVRR8mE4AxxrSqWXDiav7fjHEHDWQ8VHJw+rNA/hOlba6cpWJujV+KIdcWK0TdGtVPBoEQIHdxeJ9VuxXR51ilBx+47Yd70R2G8ZUM30VcWyDSoCHP1raN9wxb/9k6UZeAVfmQGNl4Pl8QLbsjEcQbcVVeQ+EZ77RwlNOqUF36o+JN+gAhj8Ii7Fw3q+ymHAFMXHo4SE6TFC4dHZxIvhASnuCMIZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JgP2ZgQ8Y17baGCLCTwEGc6nED28+XLD9ppoSRJTCow=; b=GoOyB+GZnh2W1lzYSBhGSmIHK+RkbpQml8lMK9tVWsBBQVcO+YlC4QGz/E1D+0hPfM5vQBjLdpX+sohllHGcaTMKzxRvSuKoTsvXJ5/Z/Lnu+LS7MhIRrZUtc1T9nP9y4DisXL/GUQraIhCz7FOVv8YCtPiqxj3opZDFt1eT2Fo9bNYQhfxqBdyzbcAZpORmhLPBFrsZGb3E9a2mHpesuuczYL7a9vUZiOkzH2zT86t2+quqUZ4vLiEPHAwAGoZE+5sNOCp2sW/9PpmHhDhs0/CXJBnKxMxrmY+FwCb/JpbVSfTlud7ufR9LsVoXB0tZwpuJrRRWyjOx3anu62zMzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DBAPR04MB7382.eurprd04.prod.outlook.com (2603:10a6:10:1ab::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7807.27; Mon, 29 Jul 2024 20:19:23 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.7807.026; Mon, 29 Jul 2024 20:19:23 +0000 From: Frank Li Date: Mon, 29 Jul 2024 16:18:14 -0400 Subject: [PATCH v8 07/11] PCI: imx6: Improve comment for workaround ERR010728 Message-Id: <20240729-pci2_upstream-v8-7-b68ee5ef2b4d@nxp.com> References: <20240729-pci2_upstream-v8-0-b68ee5ef2b4d@nxp.com> In-Reply-To: <20240729-pci2_upstream-v8-0-b68ee5ef2b4d@nxp.com> To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1722284317; l=1916; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=TNSd+b5y2IdUI30Q9idwzdMxK5IHuQjkFajPvbPUy8I=; b=2MBJzBHUD0rNYMpINkM4Y3v8wUZKNpvtaW8d0qIWkN1T2SYEBFFQQJEbWnGdhd4uB3RgEuskl QemHbccpzCQBj2PGMJqqAoe9Mc6+KLkpq7LUVe+GiDcwBVm1inVpGev X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR03CA0069.namprd03.prod.outlook.com (2603:10b6:a03:331::14) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DBAPR04MB7382:EE_ X-MS-Office365-Filtering-Correlation-Id: 58f17378-a150-4e66-5bca-08dcb00bbc71 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|52116014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?8FztPn7O1qVkIogtuqWV/ucCw/hLLV0?= =?utf-8?q?Rpj5+Jq+uZsxQpyRUTQ69dzT8jMijS+gTPLiVKlInnjLDi5hSgGRVHNISo1fimZZJ?= =?utf-8?q?TsJ3V3Z8488vTeAU3AcaAR6kyCKmKDNloIfyxAdxv2sKXWWisOyClkqPcUzZjkQA0?= =?utf-8?q?gJpplUlPU/+4gk27LPnESB+iRZnbMqPPZ9PbQyjZsfmEkZrcb8/2ATXYtO8BJW4vk?= =?utf-8?q?+DCNPKUbDkgb8znVZxUEchtbY8ZqNxyFEMjMXu1XNP1tscg48v8uXCoT6vU8LiZvO?= =?utf-8?q?F6IxGSztoORE9TiaHbLWkJGsgrih36kgQyfnl01z7aD8NLkcRey7z6Hl/QLnY4PRh?= =?utf-8?q?V/+vw5maMEojlpcpk+dWIJook4HMUigYD5/lZTz8iYkYCYajI6pj0emFfvKZR6jRB?= =?utf-8?q?biPakOso/LobTTSqk5BvqOXUxaVzfXzq2UeAX1xyheeLpQlbWz4SEdkjJAt5PgK8V?= =?utf-8?q?RnK8nIp9bkv50JMvcEvt/UmaBU+2Jj8hoWh/m+AgNJIjRc897K6wa8oxjsOE8bip2?= =?utf-8?q?ks/phEpUlVP12RzuyGx7yN76Fq+cY/GQAMF9IldBLT0bZ099IWnbbqrhRG5b9P6cv?= =?utf-8?q?2YF1MNyT90kvDVPt3waofEgzh3Q9+0xsR2UQbDr3X9EsCHIeSgGq0tWxQehnU/K/S?= =?utf-8?q?OgKaTRcoJ2Y3ez8pRCAiQxqYG21+8iSffEJqhcl56Pa3EpsGqexPsKmlR2gNjOekz?= =?utf-8?q?mhhAjMtANnc4teRV50EfavSesrFbm6Qbi86WpYzt443arIKorzOaCW11urMVcTOC2?= =?utf-8?q?vGQhOULuZZ5USwMWa1FQ+uHHemDjHMnJKW4EQY50WEiuRaFTCQv2uS59FDXveyj3Q?= =?utf-8?q?Ab1ic6jlUy/3z7RqsQYIGePEQOYqrNNVE0a25JgAWDwCw/oOpliQfHHFavV86h/w5?= =?utf-8?q?twzp8hfZWZZ/K3dAgEq/gMRZioEebk5mbNqMfzi5Yi0Um081IrqjrgjAxmsV/stPJ?= =?utf-8?q?aNyIrYXERJuCfjL5IuqbvlZz/UIlCFejons1MYPMaM/6XHvmawyYs82kfsZrDqBoo?= =?utf-8?q?dip5UPJr7sDmi2beAOOgQZLE+ezyp0sQxfbItyQmxUN5rVHPDsHFB8sKZhpSiKGwu?= =?utf-8?q?NTzO7TE5IrEcvzty1HNM1ao9c0pweSfvLlPxfo2WYUfUTyb575CCet2zrdEzz40qd?= =?utf-8?q?sTEZ+sh/xfPdjmGBHMlQy5Ml30zoY19tg12edi5Ne1E5wtw+250HyC9v5ZNqObt7R?= =?utf-8?q?rDR0aZojkGiVz3m0dVJvyHqsLxZ5B6Rc/Cyw8vPqLI5ZwHCi9IuFyMd0MFSHSQcEk?= =?utf-8?q?rFFj9gaOshZa69WaG0EUJokQ+4KVzMQT51zKcFXaHiUwhi2QjAqxOQpCLlG03pIxY?= =?utf-8?q?zcwuBA6h2Jtox1HiTGyGNZibeIRUCzrlh9EpzE1MDNV3aB5wQvEC1Xs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(52116014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?4FK4H4Sgcu6HRuahXJjMLaA0uMs3?= =?utf-8?q?N39n30iY5zE+SZOVrrAn4t97IUxQuegwlqWR9qhycEZxPqXsJn8FSWEk2twSH3D+F?= =?utf-8?q?CVj5PymaSEdU0M5dkQKni5heFtcMYlc03al64o+vNToz2n3ZiNkQREYxzpnuA5uf3?= =?utf-8?q?OfGiDDIzqR7G/1EMmVwBkoZF+JOuSNSmy2F7pSdNdh77pxzRXlVfHO8RSRscooW04?= =?utf-8?q?TptjPpAIdSiRizMthIQNhKa6Aww+KdNt53LZKCVLLULgZ4ivH1eXU3x2HgK8DnLER?= =?utf-8?q?U39zKuNUNkU/KEl2jGnquqaL8crK+laah553+x3ACpfPRjuOAjMxuk38aqvnSxekt?= =?utf-8?q?C0pMA8Kcw5VCeWIECHHhuLgFASdh34q86yG46BW8Oah8Z60yPj5Q2rWaT9vKAMt6b?= =?utf-8?q?HRlONTl750BIvp0r75u7+HLAA8YaSaB3wftu02f7I7mKVHVW+qB9vy65kVytJdD07?= =?utf-8?q?wmELexevhu3+YRoI3/g8W53KBC7ytEXC9zqMrpzW1ZDhK6I1S4+pcu9eSSjkkveuB?= =?utf-8?q?mzU4JjLNoQTDYyJgb1iZxkzRMKefykH7svwz/7SiXnrJNGIuzUZVtJxFewhaKLNmi?= =?utf-8?q?fN03G8EkUK5dI7c1QjbVB90J8glXdODYxTUGsHazQ8cSLullTu/y3+z2W+jE4drxH?= =?utf-8?q?JzkUU1ojnLD1QGVK89QuUgb/waod+p00+sPsWwiy3kypNVN8aqz9CB1S2Kwob8P1D?= =?utf-8?q?ke7AGf5quvgOxpgz4AkYKWR9DrhtnShTgLWFwm1CftmYz4rFJUKcJXSnEUk2f228l?= =?utf-8?q?RIbq/pwjYyYmCj9BbZpqVXUe4HwIAAT7sHHHkDEpIblk3IEVa1Mz1rt412pn+JgDK?= =?utf-8?q?WpvGzUZSkXoiWwLg3TzM46Xb0uehG50LBcal+eLVSmuP0zIqgGAFqGdUJVSTWLwDf?= =?utf-8?q?juNqJtACRzukR8tqs0UVxKoqwacHJkEx8izc4mdvwKgb5mXNfIUh5Lvh7NP2MhfT/?= =?utf-8?q?w2KC0t/2LhJNUss5tQUCHUKcOzOPfPBTjfJmKexhDGdLRs+nFyB4IoGNxU7JUed3P?= =?utf-8?q?GNDvhjlxYSdvYUQE+SB9F6JlGNmrUGcutlGkobh1efZi9zDnrgU/Nmr53fFL20d8u?= =?utf-8?q?aTT4Up1rpqffPQ6z4aHaa3sdGS99BcqdfrXgoVaqti4e/O+gFRj0ah4Jy3w4fXknL?= =?utf-8?q?6+QWUbh9vJGeUKnB7MctsqLKz5LtAfPsmzxz2He+A6Doh2o21IPLgmZQaGNFH+jvK?= =?utf-8?q?Tca2PgtWxF4nIxtDENSsXX6U2qJkG8OpfI2+S3RTp4KN0GZahQllBVvRQo24L6M+R?= =?utf-8?q?vZba4/ukgNQftlqzTX8dxK4EOLwFSJUPASWCtQkcoUClnbedKzKgwa1yhkpQEbFRA?= =?utf-8?q?pHPnRsmQb0n9vHl0gHkCQiskVLeDLYpdp2P6pTAn/lQ1NBdfercmeHsFb7gHn6L/2?= =?utf-8?q?fbgNPv4RWqUhmEzhpU0Odagg32UDfoF2sKVWMOZmVyYfAENFXVQG7eDkkSS+Vmp00?= =?utf-8?q?EDuNYjgn3ZkMd57sYaTQk6G1MHjVrtTEmT5bVs/CGuHCp+IhLrp7ydCYXKu0DIIii?= =?utf-8?q?tWFiWfTlCxQm?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58f17378-a150-4e66-5bca-08dcb00bbc71 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2024 20:19:23.3174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a4wvPqwygIKYoOHyV8bbpWKTjbjMxN5x7tY/jqhKhbX+IhDyCSdSSoF0iFCljTTfecZsx6aim46SOe7Os0YhOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7382 Improve comment about workaround ERR010728 by using official errata document content(https://www.nxp.com/webapp/Download?colCode=IMX7DS_2N09P). Reviewed-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index e295c7bef732e..6be32a93411b6 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -712,9 +712,26 @@ static int imx7d_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) return 0; /* - * Workaround for ERR010728, failure of PCI-e PLL VCO to - * oscillate, especially when cold. This turns off "Duty-cycle - * Corrector" and other mysterious undocumented things. + * Workaround for ERR010728 (IMX7DS_2N09P, Rev. 1.1, 4/2023): + * + * PCIe: PLL may fail to lock under corner conditions. + * + * Initial VCO oscillation may fail under corner conditions such as + * cold temperature which will cause the PCIe PLL fail to lock in the + * initialization phase. + * + * The Duty-cycle Corrector calibration must be disabled. + * + * 1. De-assert the G_RST signal by clearing + * SRC_PCIEPHY_RCR[PCIEPHY_G_RST]. + * 2. De-assert DCC_FB_EN by writing data “0x29” to the register + * address 0x306d0014 (PCIE_PHY_CMN_REG4). + * 3. Assert RX_EQS, RX_EQ_SEL by writing data “0x48” to the register + * address 0x306d0090 (PCIE_PHY_CMN_REG24). + * 4. Assert ATT_MODE by writing data “0xbc” to the register + * address 0x306d0098 (PCIE_PHY_CMN_REG26). + * 5. De-assert the CMN_RST signal by clearing register bit + * SRC_PCIEPHY_RCR[PCIEPHY_BTN] */ if (likely(imx_pcie->phy_base)) {