From patchwork Sun Sep 15 01:36:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Akihiko Odaki X-Patchwork-Id: 13804628 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B43A1FDD for ; Sun, 15 Sep 2024 01:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726364232; cv=none; b=IxVZ1x1UbtmA/nSwSDk2OMlRk3oXhBAY6yVY3WIW6+esMjZJjmiFZRd3TL2a8slE0+yjFVpiPQkpV7HSNu9Jz+FeswaZlc7w+ZBfHJsfTppL/GE59WAwvHPjgwPYYoflLWrsqMziyC42WKTh/7o0cT8E1TDQYulXgMOog//PPqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726364232; c=relaxed/simple; bh=e2DB0jY7CI7g9yMhLJrXFiC12wUCmyurX80yXHI+8ak=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=RsgTf6CYAZb4gUV7bUxmS6xyF3sPrrGoJa3EXQULGhw20vveCXANmUKya8BoR/46s9oyJN/m1x5b13rAGrJKxtHhVnAIR6jxc550397seW7YOiE/zvoMjHNsi33jRXSFCEU2XCLf3zJ/W8K0bwpkgyuvcdT3wymKvq9slkY3NbU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com; spf=none smtp.mailfrom=daynix.com; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b=eHFH5Vv/; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=daynix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b="eHFH5Vv/" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2059112f0a7so19008615ad.3 for ; Sat, 14 Sep 2024 18:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1726364231; x=1726969031; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=qd+n/+pRJnLuOWSZ4DY2fGdQOZIdYewseGE889SHmks=; b=eHFH5Vv/ej3b+HbyGqFufdbn2lWFX9udp1iJPBgwlA0SFYqx4XTSyIf4+qbJpm9cx/ G++AnBvpQnzph/mT5v90bXs69sPHbZ57peiOxVXpcuexhwq7jSFgpLchg7S4kJN8ZBSR +ctNUoO/VCSSy+HTPmBWd8TcwzcysklDZFIaMEA9vMDE27HVKjecaKggw6rHp5DrHRj+ 3P5QyKX4XykCN+SR3Nv/rI2qt+PrntaIoQ0S1/g6XCRiDxyY/7rLRlQH/rXFUNd7tL7i eGgOhhbKII84JGaAa9tiRLfw9QMvQbmZhL0o+7lird2KILuZ/8CLfjBynn8+Rz3UiXFV 04eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726364231; x=1726969031; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qd+n/+pRJnLuOWSZ4DY2fGdQOZIdYewseGE889SHmks=; b=Dm5qGW8TZw/gTTOYfgy7mSPoYDgZveMzOSrY3ksPDDPzxjDMD2o5TeNA6Il9Vuuth2 LIJjHq56TGwGOLGWZmEdp0JXJAsJeK42DRjcTuJVUqb/uXsnUW2rODHzomALAV9AMIKW xyArPrgDvgK2zaV3wKA1KoLgxygc2G1997dO1ZUhcFEp5H5SaESTO8rrY36Rk30mGTSj N1rC/sIDYp0N/tmDENW/vrm2BbL0Bsxa4AxupVKL70bYsLVgxFPzu0bXH33ziGRUBy9V LuRFDr5A1gNM6mHaRFJGRw4SUAcZVV/PRf+8xfba3KJjCRC2IYWQvu9ZnH7PyKmeWdcA zCfg== X-Forwarded-Encrypted: i=1; AJvYcCWqea5WllkzNw+J8VC3lw4HwUOhxxzyhZoeemIP6DiR9vDga8hr3F2PK/QyizUjgHhZoP9U1elIC7c=@vger.kernel.org X-Gm-Message-State: AOJu0YznY8Ev0FUthFk0W5sqqaJHj/PNT1N5iqT4PRzqBvHQgcXo+Fb+ 91HMbERcASXK3dOkdq9W3rNzx2aLYKOyjbqPae2146bOFf3VLc3f6rjrdSvvbhg= X-Google-Smtp-Source: AGHT+IGBzYZA6aqxcO/jlga0x7/3lidt29yrIn+ISrJpxc+g6woAA3sheKe9inzHSihEaDrpdgpEFQ== X-Received: by 2002:a17:90b:2249:b0:2cf:2bf6:b030 with SMTP id 98e67ed59e1d1-2dbb9f057a9mr10878850a91.33.1726364230768; Sat, 14 Sep 2024 18:37:10 -0700 (PDT) Received: from localhost ([210.160.217.68]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2dbb9c3f21esm4431154a91.6.2024.09.14.18.37.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Sep 2024 18:37:10 -0700 (PDT) From: Akihiko Odaki Date: Sun, 15 Sep 2024 10:36:58 +0900 Subject: [PATCH] Documentation: Fix config_acs= example Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240915-acs-v1-1-b9ee536ee9bd@daynix.com> X-B4-Tracking: v=1; b=H4sIADk65mYC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIxMDS0ND3cTkYl1jAxPjRCNzY/PkZEsloMqCotS0zAqwKdGxtbUAZEX2xlU AAAA= To: Jonathan Corbet , Bjorn Helgaas Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Akihiko Odaki X-Mailer: b4 0.14-dev-fd6e3 The documentation used to say: > For example, > pci=config_acs=10x > would configure all devices that support ACS to enable P2P Request > Redirect, disable Translation Blocking, and leave Source Validation > unchanged from whatever power-up or firmware set it to. However, a flag specification always needs to be suffixed with "@" and a PCI device string, which is missing in this example. It needs to be suffixed with "@pci:0:0" to configure all devices that support ACS in particular. Signed-off-by: Akihiko Odaki --- Documentation/admin-guide/kernel-parameters.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 46a0057a5853cbdb58211c19e89ba7777dc6fd50 change-id: 20240911-acs-3043a2737cc9 Best regards, diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index ee2984e46c06..5611903c27a9 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -4604,7 +4604,7 @@ '1' – force enabled 'x' – unchanged For example, - pci=config_acs=10x + pci=config_acs=10x@pci:0:0 would configure all devices that support ACS to enable P2P Request Redirect, disable Translation Blocking, and leave Source