From patchwork Tue Dec 17 21:41:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Ciocaltea X-Patchwork-Id: 13912541 X-Patchwork-Delegate: kw@linux.com Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C4D21FA8EF; Tue, 17 Dec 2024 21:42:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734471763; cv=none; b=JJkkfvSmkTQT7spqlLMIQVfjDuj09UK9sC3YMd23QIiqNPt3Otcxq0gg+qii8wnQj6S6BE/1JoJMCFKWP9hUInRKD4Ik27AYoEppfg0a4+EX0h9pxpjeC0q0qnt/AI0uOvVdKyvmLOTcJt5fv+li7vDRyeCy5IU8LzSfnb8BtHM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734471763; c=relaxed/simple; bh=iEUcW5EbPc3CuJsIl+m7Y0Zgw3NQlSs/GEI0BoftKtU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FSsV/Us45Ke4d8EnsqSNcBFF9Z+t7q6r/PgJoJkbN6DLWLuYk60Qah6CwajsQnwQBDxUgh/t8klR7L954XjS1pzrHFL+hBnMLCHVm6T/CY56QWipvQsODZEtPTp8PamXCUcxbBIdgTnimARnLw5r6ievF5/b3s+DT418bt0AclM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=lsExfrP6; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="lsExfrP6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1734471758; bh=iEUcW5EbPc3CuJsIl+m7Y0Zgw3NQlSs/GEI0BoftKtU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=lsExfrP6YrUyzNDCvIwKYIpg9WsHxjLvjhZpOyAAbvD4tN4VhCIGUHg3ymz1TR9Jp 6/5H47T+G+2dp33tm6APTLEHxu8XHiU+AP2axicvhjYpkM9OqIClsUn0gzpwlG8C3B 97BAK2L4YtfDCODe0ksfP9Xo0dbqVNIcvaFpco3EkMVo2t7OJNadd6nwEoCRufbmQ/ Y/ZxjrlsO7olnFDPoXtagd/LnTOlnQviVx0w3t0hGnD+YlCia5A6GNaNdXBcua3JbB mWPLCmctxqbYftfRp4ldrCU9NSYE80s/HHtY4SpKoMDLYMVTUXiccrxDn62pXDM1Df LHi2Iy2h1SGWQ== Received: from localhost (unknown [84.232.140.38]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 913C417E381A; Tue, 17 Dec 2024 22:42:38 +0100 (CET) From: Cristian Ciocaltea Date: Tue, 17 Dec 2024 23:41:52 +0200 Subject: [PATCH v5 2/3] PCI: exynos: Switch to devm_clk_bulk_get_all_enabled() Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241217-clk_bulk_ena_fix-v5-2-aafbbb245155@collabora.com> References: <20241217-clk_bulk_ena_fix-v5-0-aafbbb245155@collabora.com> In-Reply-To: <20241217-clk_bulk_ena_fix-v5-0-aafbbb245155@collabora.com> To: Michael Turquette , Stephen Boyd , Russell King , Matthias Brugger , AngeloGioacchino Del Regno , Jingoo Han , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Alim Akhtar Cc: kernel@collabora.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-samsung-soc@vger.kernel.org X-Mailer: b4 0.14.2 The helper devm_clk_bulk_get_all_enable() missed to return the number of clocks stored in the clk_bulk_data table referenced by the clks argument and, therefore, will be dropped. Use the newly introduced devm_clk_bulk_get_all_enabled() variant instead, which is consistent with devm_clk_bulk_get_all() in terms of the returned value: > 0 if one or more clocks have been stored = 0 if there are no clocks < 0 if an error occurred Reviewed-by: Manivannan Sadhasivam Signed-off-by: Cristian Ciocaltea --- drivers/pci/controller/dwc/pci-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c index 6a830166d37fff5bbbc35aaa7cc1b67b03e6ec3b..ace736b025b1b7d4cdcbd51d2e9d99af29f21149 100644 --- a/drivers/pci/controller/dwc/pci-exynos.c +++ b/drivers/pci/controller/dwc/pci-exynos.c @@ -300,7 +300,7 @@ static int exynos_pcie_probe(struct platform_device *pdev) if (IS_ERR(ep->elbi_base)) return PTR_ERR(ep->elbi_base); - ret = devm_clk_bulk_get_all_enable(dev, &ep->clks); + ret = devm_clk_bulk_get_all_enabled(dev, &ep->clks); if (ret < 0) return ret;