From patchwork Fri Jan 24 11:22:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krishna Chaitanya Chundru X-Patchwork-Id: 13949294 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF28521ADAF for ; Fri, 24 Jan 2025 11:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737717796; cv=none; b=Lgos6JkIG0lKweLxaWNuApxJAQS74y+p8XAOKE15ad9enu5O798+tfzoNVO1+VgX1g5Eii/mhT9iQceNyt/BnLiphBn04iE31AO5Zc4E3UyfsGM2uc2ej5Q9dQgl+SOoKWOS5Y8J8S4UelPVPFCPnldrRfmjtidN3lC9meKq5Ds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737717796; c=relaxed/simple; bh=f7z3CtNmxsHSKM03nohqE7aPIUwkTTXaD4CtcTYvgDI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JH3c3s+Xf9XncJmU9P2Vlm9BHBBmha9xHNhAsBRyktk+oBhk4ePFzQfDz93aFi7w2uKGIa4fkgoVRCKTPJttBqXl0S0Rx3PeAD75kfwJ/X40aHQPK2LEDEik+ZomzboCRXfmTd2a9yfIxYqQFl6/sgyGGpzX14HOn6VwWhzrh/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kkZbhuBd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kkZbhuBd" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50OAKR2Y018280 for ; Fri, 24 Jan 2025 11:23:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oPZTHj57MEyCMgMIvbxGmIatD2m1gGCN5WI13Bi7xRU=; b=kkZbhuBdHl1uAuGJ HBFUN73RL2SeQ2BP7OmraJE1AqijhtepG7nv+ExmAFRGZat08YNjwrP14rl7YmtU Ihq0L45meBLwIjzKFyg8PLtsHKfpMN1wzjtbJb9U9RiixlSzGKfnzhMaYxXFF9wv SuREmW9tKRklReA9raAGhXmUtJzipF0L9zQLoxUVQ9mde5ozXy5q0+Lh58oz6O7P 0zlr1zjIHcXnjfTOhTsQ29UCvl5cjMwFcfBfPFCk2ClcqKVbb5Ut5ZNYhMeliVhS FttmKtjxUxzYHwKtjbsKQxqohm/xkZ8iHLCzxNDpzDhgHo80rG5Z6c2xoYhYR2i3 TMBDew== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44c91ag721-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 24 Jan 2025 11:23:13 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2166464e236so53611895ad.1 for ; Fri, 24 Jan 2025 03:23:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737717793; x=1738322593; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oPZTHj57MEyCMgMIvbxGmIatD2m1gGCN5WI13Bi7xRU=; b=RABrvLGNKnitLnRyHxzKWcXvtpGgVLyyyopct4HhOdsohBpzbd1pxTcPQHgEwFBuZc FlspNHH57qwWzo9ihQLTA35w0ACI0+NOGuyH/NMNIHCHy8eUAxe6bHOCBQ3yW8LaBYx1 r45hrfDv7zqvRU8jEFk/pkjq+51pF8MBo2WcOdnDHApg369ZNJmnFe5a7yFs+LPt1aLs 4fS0bvw/lWcz82pecHVlKiQ9ULsg0MaiadxQZoIMNW1l4JLfHPaKeYDlCr8qtxJ1+Nxc eyu0CihsbzexLmeu1zvhZmYzX9IqsWtqo5QD/FUif+YT8vtWbw9IIKN1Aldbfg/2NhM0 JXhQ== X-Forwarded-Encrypted: i=1; AJvYcCXsb9Aeh1Q08EK57kzeAvCJBormmiX8xme8d/towtO0k/7mOi9xPEau0R7gLzFTiTJUFdFVx35DmGE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz68aYPvO+GPmSTl1XsOLTCxua9XRNynyP1sHfxJk92LdroSID9 o4eBs5iON12vpxYfuy3idxCLVuOV3hlriGrcAO7txeGZOkAeLdS+6ES73bteW+6eFoxHFla0Q/k /4/PiA506Y/UdzTyd6xlRTQx55W4Mmw4gGywIbyEwONQ7QS2HMVhVaPNjqAw= X-Gm-Gg: ASbGncvRJ0NsSyHTcGJw6weJZEm3FrnaMOxnXEqlRBFS9atLM62y/vx6HxvHrTJjTDo Fz4dO2Gzi6q1mtfI1fheq8768UnV70nBGP0nLbFyyBuiBVj3WNIA2Kti9ExAVfThSUMejW6wgKT 0CfQt7q+CQJUFZ6v148xakpVYWKgGG7BnCsz9r5NbLa8z/F07pKMq2QYILxzUd5N0NMtJ7+kiC1 /eZ3TZ1ailNCmo6ghkQQ2ZG4KVyyHCIhyfHBB1zQx9xpnuQAC+w3lYDcUOquVTHa58tzI8n6OBT I/MqIx0itDoIjHyvi0vs8czihNb0RQ== X-Received: by 2002:a17:902:f681:b0:216:1cfa:2bda with SMTP id d9443c01a7336-21c3564858emr475850355ad.43.1737717792785; Fri, 24 Jan 2025 03:23:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEr5DYYXHE2G/vBfLJJCN6ckREbrK5+wnUplikzoVZhqw80AYnBOws3G++Q2Ix4csuj5Tuxeg== X-Received: by 2002:a17:902:f681:b0:216:1cfa:2bda with SMTP id d9443c01a7336-21c3564858emr475849925ad.43.1737717792330; Fri, 24 Jan 2025 03:23:12 -0800 (PST) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da414cc20sm14025385ad.165.2025.01.24.03.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 03:23:11 -0800 (PST) From: Krishna Chaitanya Chundru Date: Fri, 24 Jan 2025 16:52:48 +0530 Subject: [PATCH v4 2/4] PCI: of: Add API to retrieve equalization presets from device tree Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250124-preset_v2-v4-2-0b512cad08e1@oss.qualcomm.com> References: <20250124-preset_v2-v4-0-0b512cad08e1@oss.qualcomm.com> In-Reply-To: <20250124-preset_v2-v4-0-0b512cad08e1@oss.qualcomm.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Helgaas , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, konrad.dybcio@oss.qualcomm.com, quic_mrana@quicinc.com, quic_vbadigan@quicinc.com, Bjorn Andersson , Konrad Dybcio , Krishna Chaitanya Chundru X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1737717776; l=4612; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=f7z3CtNmxsHSKM03nohqE7aPIUwkTTXaD4CtcTYvgDI=; b=ONmPOabKI/5+CXlcVHrVmoVXeeLa+NbJKA7XyAUP+yvdzFIStSgyQzc7zxbrQEzYeC/fnPWAJ KCBUFQE8411CxldWCVXPOcrFJlTYhQcHAoFUXYQDP7askNWfbP5Nxd1 X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-ORIG-GUID: h3EJ5sY3SGr1X7YCpMfMd-di1-C6UrrH X-Proofpoint-GUID: h3EJ5sY3SGr1X7YCpMfMd-di1-C6UrrH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-24_04,2025-01-23_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501240083 PCIe equalization presets are predefined settings used to optimize signal integrity by compensating for signal loss and distortion in high-speed data transmission. As per PCIe spec 6.0.1 revision section 8.3.3.3 & 4.2.4 for data rates of 8.0 GT/s, 16.0 GT/s, 32.0 GT/s, and 64.0 GT/s, there is a way to configure lane equalization presets for each lane to enhance the PCIe link reliability. Each preset value represents a different combination of pre-shoot and de-emphasis values. For each data rate, different registers are defined: for 8.0 GT/s, registers are defined in section 7.7.3.4; for 16.0 GT/s, in section 7.7.5.9, etc. The 8.0 GT/s rate has an extra receiver preset hint, requiring 16 bits per lane, while the remaining data rates use 8 bits per lane. Based on the number of lanes and the supported data rate, this function reads the device tree property and stores in the presets structure. Signed-off-by: Krishna Chaitanya Chundru --- drivers/pci/of.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ drivers/pci/pci.h | 24 +++++++++++++++++++++++- 2 files changed, 70 insertions(+), 1 deletion(-) diff --git a/drivers/pci/of.c b/drivers/pci/of.c index dacea3fc5128..7aa17c0042c5 100644 --- a/drivers/pci/of.c +++ b/drivers/pci/of.c @@ -826,3 +826,50 @@ u32 of_pci_get_slot_power_limit(struct device_node *node, return slot_power_limit_mw; } EXPORT_SYMBOL_GPL(of_pci_get_slot_power_limit); + +/** + * of_pci_get_equalization_presets - Parses the "eq-presets-ngts" property. + * + * @dev: Device containing the properties. + * @presets: Pointer to store the parsed data. + * @num_lanes: Maximum number of lanes supported. + * + * If the property is present read and store the data in the preset structure + * assign default value 0xff to indicate property is not present. + * + * If the property is not found or is invalid, returns 0. + */ +int of_pci_get_equalization_presets(struct device *dev, + struct pci_eq_presets *presets, + int num_lanes) +{ + char name[20]; + int ret; + + presets->eq_presets_8gts[0] = 0xff; + if (of_property_present(dev->of_node, "eq-presets-8gts")) { + ret = of_property_read_u16_array(dev->of_node, "eq-presets-8gts", + presets->eq_presets_8gts, num_lanes); + if (ret) { + dev_err(dev, "Error reading eq-presets-8gts %d\n", ret); + return ret; + } + } + + for (int i = 0; i < EQ_PRESET_TYPE_MAX; i++) { + presets->eq_presets_Ngts[i][0] = 0xff; + snprintf(name, sizeof(name), "eq-presets-%dgts", 8 << (i + 1)); + if (of_property_present(dev->of_node, name)) { + ret = of_property_read_u8_array(dev->of_node, name, + presets->eq_presets_Ngts[i], + num_lanes); + if (ret) { + dev_err(dev, "Error %s %d\n", name, ret); + return ret; + } + } + } + + return 0; +} +EXPORT_SYMBOL_GPL(of_pci_get_equalization_presets); diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 14d00ce45bfa..3a8c04e3b30d 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -7,6 +7,8 @@ /* Number of possible devfns: 0.0 to 1f.7 inclusive */ #define MAX_NR_DEVFNS 256 +#define MAX_NR_LANES 16 + #define PCI_FIND_CAP_TTL 48 #define PCI_VSEC_ID_INTEL_TBT 0x1234 /* Thunderbolt */ @@ -732,6 +734,18 @@ static inline u64 pci_rebar_size_to_bytes(int size) struct device_node; +enum equalization_preset_type { + EQ_PRESET_TYPE_16GTS, + EQ_PRESET_TYPE_32GTS, + EQ_PRESET_TYPE_64GTS, + EQ_PRESET_TYPE_MAX +}; + +struct pci_eq_presets { + u16 eq_presets_8gts[MAX_NR_LANES]; + u8 eq_presets_Ngts[EQ_PRESET_TYPE_MAX][MAX_NR_LANES]; +}; + #ifdef CONFIG_OF int of_pci_parse_bus_range(struct device_node *node, struct resource *res); int of_get_pci_domain_nr(struct device_node *node); @@ -746,7 +760,9 @@ void pci_set_bus_of_node(struct pci_bus *bus); void pci_release_bus_of_node(struct pci_bus *bus); int devm_of_pci_bridge_init(struct device *dev, struct pci_host_bridge *bridge); - +int of_pci_get_equalization_presets(struct device *dev, + struct pci_eq_presets *presets, + int num_lanes); #else static inline int of_pci_parse_bus_range(struct device_node *node, struct resource *res) @@ -793,6 +809,12 @@ static inline int devm_of_pci_bridge_init(struct device *dev, struct pci_host_br return 0; } +static inline int of_pci_get_equalization_presets(struct device *dev, + struct pci_eq_presets *presets, + int num_lanes) +{ + return 0; +} #endif /* CONFIG_OF */ struct of_changeset;