From patchwork Fri Feb 7 19:39:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13965639 X-Patchwork-Delegate: kw@linux.com Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2052.outbound.protection.outlook.com [40.107.20.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F86019EEBF; Fri, 7 Feb 2025 19:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.20.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738957276; cv=fail; b=mvP7Rm712EYpHH+H/vr0yrHh/srwY8w71O0vKChYzzNEZDU75T+Babju70MllkIM/a0EFAl6TUahTLBuc0rjZFH8yZ/4hpFSh5HuKcN1LEWLs0qnekImshYbDTeciZ6eueec6C/xQXnO9aZ3BSrca8UZcah5P51/2KQ1MZttffU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738957276; c=relaxed/simple; bh=YbUj9P3D0sAyJp8B54JaH2JpUQIaScRA/2vrLLIycnI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=UOzqPixz/uRmxq3DNO3svFEdUJXLsd9oSfDNNqK6pJzySnHjL/j18S2HNEGmJS+Kqqf20GBzpqIWWoN/Hd+97PeZjsJWc6U9TrIug8hZCCSkzz5T5vKHkiYmw9mYh20alxsLiJlLZImg5+qNP7nCIgoBVNVpEgHxAxS9i8fryFU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=hZHhwSug; arc=fail smtp.client-ip=40.107.20.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="hZHhwSug" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D/QHEJ+cM3dks2SsRjjVFxZvpv4mKM2yuAZ5Aq/8MiW6FPbSDB121/HCGLq2tH++AHtWtATyTlH+ggVfEUPYMqh0kvknXixOGrIk7JoshwhOdF4irGexkywwCTINP4GkZIKyHIBKFHoZutDJzE5hnzl9Arbn7yYbYAcXjKXfYq4hBFUDSal69sDOphOMjowyZr6ESZpr9iQQgmMnys3SOtDygLYt2FhjWiZeAm/D8OEAFjIUkt1ucjvYpUzqYe+y4usC6f4azstE0ntxGL3IODT3myG+xfKWRnF0GZ7oe8tb1vJz1qXZNJ53jw2cUBZhoRtzWj6qStAqKXm3YxJA3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iQRV15xEuqYShptV6LXNYxXUwjjQavO9It5cPdfJkJg=; b=D6zUFhsEPN/pd0h8LN9Kz3slSwojWZXY1MUqj4nyYeoP0FxVnxU2yyR4MWql4vNTfg8fckVJpsmrCcesPDOIOTVwymE1rWUUuKqhotuiTPAlU3M+nYU42CvomXC19tgBYIkMnXAu1ywy/NtfcfQvLk08XPh5zPZ1UspgTqpCpcmhn3hJgpI9jhQdAVdAbHm5XtcoSAZn3hQHIcuKhknZqVFP+SCl5fndWqy2nzSDa8xa2xtArBU7BJYEtGYyepXc654OalznjW5lc0xXo59odLLuBU7Ynx2RKd3+JPRFr+jWTHg5wUUSHwW0/EG/eau+QWPbpL/vQrbjXKEl9CTVAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iQRV15xEuqYShptV6LXNYxXUwjjQavO9It5cPdfJkJg=; b=hZHhwSugrpN9I+LSyt9Fe+iu/ix5lDfeEfcpH5yvWstG6lBvcLfOdK4avrO+/I0Llt0Lf1Ap7cWeUKk9Kb/82wabOepI2fPs//tt/rjglbDNYuxnybb53q5SnLdgOe3c0oRLvRGNB/XcQELQZvkWZD6o7Y7bzAOyEhCFhMVR33pyyPpWVspLflnJEp6hkUALlAf/y4j6hBko9mjB7F3tLOxZcoOddGdlp7rVSOHG8bm/YiSHmRON9jch4GtiN9s3GlBbYOI2uHTMALyxRaZATl38gniKg5l++5RQViwzfkJO3HuNiN+FxWs4UtRyXEd50nNF6Cl5C0R9sHp+8jjVrg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by VI1PR04MB9787.eurprd04.prod.outlook.com (2603:10a6:800:1d8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.14; Fri, 7 Feb 2025 19:41:11 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%6]) with mapi id 15.20.8422.012; Fri, 7 Feb 2025 19:41:11 +0000 From: Frank Li Date: Fri, 07 Feb 2025 14:39:50 -0500 Subject: [PATCH v14 08/15] PCI: endpoint: Add pci_epf_align_inbound_addr() helper for address alignment Message-Id: <20250207-ep-msi-v14-8-9671b136f2b8@nxp.com> References: <20250207-ep-msi-v14-0-9671b136f2b8@nxp.com> In-Reply-To: <20250207-ep-msi-v14-0-9671b136f2b8@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1738957203; l=3395; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=YbUj9P3D0sAyJp8B54JaH2JpUQIaScRA/2vrLLIycnI=; b=1i1jg5yYbJ9cvcOl6Sn612hw16rd5K/YoEF58TNDQZqjSziM2SDrz/gjkJSf3xGwJAzIC8Ypj S5VFPdv5gTlB2SXJXcUXheIPcpZdUPWdnj4HieAFsxOXjy6UHby5GF9 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0P220CA0004.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::9) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|VI1PR04MB9787:EE_ X-MS-Office365-Filtering-Correlation-Id: eea3202d-59dd-4441-bcf9-08dd47af6021 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|366016|376014|52116014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?GVkuoAyg+tzAbcP1FFaGaK4YLi328UT?= =?utf-8?q?Vd6b8QhGoUm1W18zGnP9RMSkIv05Fo+nd2DrlZeVChRI0PiGBfK19mjnCmVbvqbIz?= =?utf-8?q?AKiNxAi9x8iZdi5I5tprOzds2lEGHOTt9iAHywnpSIV2T3W4jFyBUZ1ee9WC41a2g?= =?utf-8?q?7Far4gC6DHxcTQ9XnCrzO7vnGFSsdhgG+MJHNsICd++u3wd96OoMMT34oQcplXp2p?= =?utf-8?q?6Z7xmCS5Qo2O4p379Jpy3QB9T7zK7kkTIXs4qfq+qW9rIufMzU97+1qseom1EZW0P?= =?utf-8?q?mLTXVL6VWFZguaQfHaWhIZS9HvFzbrb5uzPAdGIaaQDmf3qDpV0MspWF9QXlNFqtE?= =?utf-8?q?nT/lIij4mWFzLtXuPOkxzJzi/XOLz1kMSxHcjXTIOBnwNOU4QPLT9wWiu62eMQMh0?= =?utf-8?q?bD09ssrRODBIVP1fGeNSOWdKX3Gps9BSwIH0Yp4CaCHnMnTDFdc5n6Y+GQeSw6v7x?= =?utf-8?q?6WISK7JhIsT+psq/CkXzdB1uz3TGxmDVEnm7PUMscpEW6lpXuREZHRjD1ZnoDVtoi?= =?utf-8?q?3IQgaRjoVIs2JJ4eaox5dxUF7dz5x4Y20vCgeruJES8AFPS1PQFi94We2/pg7qnNJ?= =?utf-8?q?lGedBwUo2Et9o+dQWfJHNdAWwSzIgsc1RGw8NfdH2MEQ1fNI4fbNoA4EukM42IHEf?= =?utf-8?q?056Om1RcdARX963nZ9YLBXrZrlwozG33xlGUwRllkJogfwaCDUvAR82qdwueBJE8Z?= =?utf-8?q?MPYT2GHs/2J9XYBj5ofV8/1JKEjzKq0C4tcdFDjUe16rVG5MU/Lrh1Q3G0KX2sMyp?= =?utf-8?q?aEEivV9h6kECY6w0/DUtq3zvlfa9siSZ9qUg6LguHCCk0e62McV/YDXzRkiNrDJcS?= =?utf-8?q?CmSsZp3vC4XsJYGiK87nbFpscZjpz0R7s903BOL3w76A+3c1rEGDNUSTpiF/XDz1Z?= =?utf-8?q?aeikxVX3YIcP/6AGcm/gsEbgBWl+BACuwatMo8UHsloFSx7wu1JQqfYquapE0joIt?= =?utf-8?q?E89wFweqwmG3jBvK03GHlheiLH45IO+VaWK4NfS0OWA9gW6x9DqK0oL9fKu8f0wZj?= =?utf-8?q?S6cPFGl3vgdma76nBGe7f2UE50GS7xMcjgCFkERFRsPLcxqmXNWmFjowQkcnzTJQ/?= =?utf-8?q?MkdtfjE+fzRcP2KU7qseCbG9YSkfDiyE/i0CRmZ6DC3igFyYHBAFvZQJl6MJC6t/y?= =?utf-8?q?JxDQ+iVjOij70tjgV3mSFaiL6g7AX7qxynag0FVG/p5IHRsKrJAmpWLCYQOcIfAVQ?= =?utf-8?q?+p/DXh6U0SYlGmKIponZEC0CjqKp/u0a8dgUctCv4Eil4mdnJOSYWnaT/yVjJoOwf?= =?utf-8?q?VkRXFd9MnCAtJEc9/fRuS3yJCtYZhSHWo8OnluXpnYb8NX2VPO1IaFVJ5I+BrxVgm?= =?utf-8?q?/Ds72w9r1qAVzjImgiDPmsWjguj9q65LEH2f/LjRcgWr5Squn7EySpJnDlBH4bCGd?= =?utf-8?q?g+fHoK8is+m7JKYnU6sHvY4hfKqAi2fJA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(366016)(376014)(52116014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ENy4LsIVzgeV4agl/oirc1cbPIU3?= =?utf-8?q?CNxl8zgsRpR/wzJ69HJAd2r64fyrgwP/11K0mUNfpRW00hT1I5sBtZGN6CIRge/cW?= =?utf-8?q?zv1eKhHTBSiQw5KdGOYaXemAU+zKQM5A4mA2N52pacsyvuP0U6VZ1gUA3Pw3P8MQy?= =?utf-8?q?5LiPiZZ4RhIU4MmXGBjMu7Y4FrTg/TkpGgwdoRcVkmwJ8Ydvf6iTUu/T1XT22TjbP?= =?utf-8?q?R5JH1bZPnMWeY9bwDZNXCTAtqHXXl0cY4cMz/7DVZcawks3WTeC7PWdnExXGgTQjz?= =?utf-8?q?AfRtOS17gjaw4PlJX0TY06Xi5S5/1dzFNS0aqAxiYulviugmQneesQ0D7ecKJbVtk?= =?utf-8?q?pf9KJDpwo8w22SgibLhZdEcqvA7Lb1uxdeF+dhW4gXdVz/Y5zw5o75brABhvTRcra?= =?utf-8?q?s5qaGSfRSyR5csBTX+U0ICqaeJ2mFn0Boz5zb0vlndX4P1Rv6Fzj+HbHIoQv+g5kc?= =?utf-8?q?EGdg5jw3QzxSYXuue/SLwrqbTvEuWqbhDQwwHDRFcCP3z60Q4PjDH55F7FputCHN/?= =?utf-8?q?/ezzfna0M1zZFOuxX1WkHfMa/iMV60XVyEQQxt4vtt9nRVEUZhIeMJMOap/R304HG?= =?utf-8?q?Fq1urqiHtrOd3BerTysMmr30kUBsUDcK25Gdh0chJ6F9UDitvUUjGH5zeXNlaNeWl?= =?utf-8?q?fq2sXHvPuQGUCXJZVhWzYKf0M1wo79JPUen+0qutEgvsYstP2G3UQAWeLqNEnsm5b?= =?utf-8?q?47L6ixhX1ZWe1cxKXqGs2SSP+CG3B8MiAtFaV5XzVnUykh26DvyQTJFL+8ocBzr+W?= =?utf-8?q?/EDg7RMDCEQoChP8KC2VYydY7eEI2q3CrkuOoo14mvYDdodX8n/KNhjuu7VcTt7eQ?= =?utf-8?q?Zjfg4MBL8VRtSaRJ6XQeUssJDtLH9fwlrj53e6q+d1vaJLgWLyZP4rzAN01Z+7R5I?= =?utf-8?q?H6a1J5UqzF/jCoVBSXfStc3535qaeCmGcRc/2j19/ud4TYKYNW3wJQafbZ5pNGBe2?= =?utf-8?q?80wi/wLbk+N7hS0zZSrDoj22idDvzCojZUhrMHRY2eFwb3StRcxDCL5pl4w+plO9j?= =?utf-8?q?473P/YSJh1fVTUlmQUv8CVr+uJ0Q3lwtyZgIJhy0JDFs3Q+bARgrf6H/bkWXYnetH?= =?utf-8?q?umjNsWZP+nwLtKSRHHm4M7KWTnR4mAiNpW+0AvFl+ZCvqNkf4xISmlwzdfBHqVs4v?= =?utf-8?q?pYrWY/caqvNcPBcPpZxLVn6hSxdbwafugHaQOqr82rmycLnOCH2kgk7iuoXH6ErWx?= =?utf-8?q?OMO/rbFO9YVcai6jwboKazRrhUgIXZ6XSMlGS/PCfmk3VuCUULjnD+I9At7TSqs3U?= =?utf-8?q?ISASW1O8itTRerfvV7ZDxiOAI/TbYlZ41fbfr141Lukb9Z0D0+f2G2fRDX/i9eQ3G?= =?utf-8?q?SlVXpwDjpS5moF9ByNegeFLr9QSNzCZTnyE/MD7ylV7/Zb0TB07y/s0Yw93q6p4TS?= =?utf-8?q?ssS0OsrpMDLdHgTApPja9QeTALYJo+Pf5o79VyKj//9OW1nDFYz4wVqAmHI1VLhqr?= =?utf-8?q?bxa+E08LOwKaVs5Bw7DXo4ueZLBfm20zSvj8d+Q8mKQmEfrY2V7rTBtgL8xKAMhRy?= =?utf-8?q?RhBa32WScd6D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eea3202d-59dd-4441-bcf9-08dd47af6021 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2025 19:41:11.5925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Qt0HAwldIuKnZyyvnRLhnwk1TFBSJ22zHFy1ksxfL51sjWGvfIGrHUzK8kmewCFOWZqRYwa4dKMFz5w4s9Y1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9787 Introduce the helper function pci_epf_align_inbound_addr() to adjust addresses according to PCI BAR alignment requirements, converting addresses into base and offset values. Signed-off-by: Frank Li --- Change form v9 to v14 - none change from v8 to v9 - pci_epf_align_inbound_addr(), base and off must be not NULL - rm pci_epf_align_inbound_addr_lo_hi() change from v7 to v8 - change name to pci_epf_align_inbound_addr() - update comment said only need for memory, which not allocated by pci_epf_alloc_space(). change from v6 to v7 - new patch --- drivers/pci/endpoint/pci-epf-core.c | 44 +++++++++++++++++++++++++++++++++++++ include/linux/pci-epf.h | 3 +++ 2 files changed, 47 insertions(+) diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c index f728ee2660a4e..04facefc70423 100644 --- a/drivers/pci/endpoint/pci-epf-core.c +++ b/drivers/pci/endpoint/pci-epf-core.c @@ -469,6 +469,50 @@ struct pci_epf *pci_epf_create(const char *name) } EXPORT_SYMBOL_GPL(pci_epf_create); +/** + * pci_epf_align_inbound_addr() - Get base address and offset that match BAR's + * alignment requirement + * @epf: the EPF device + * @addr: the address of the memory + * @bar: the BAR number corresponding to map addr + * @base: return base address, which match BAR's alignment requirement. + * @off: return offset. + * + * Helper function to convert input 'addr' to base and offset, which match + * BAR's alignment requirement. + * + * The pci_epf_alloc_space() function already accounts for alignment. This is + * primarily intended for use with other memory regions not allocated by + * pci_epf_alloc_space(), such as peripheral register spaces or the trigger + * address for a platform MSI controller. + */ +int pci_epf_align_inbound_addr(struct pci_epf *epf, enum pci_barno bar, + u64 addr, u64 *base, size_t *off) +{ + const struct pci_epc_features *epc_features; + u64 align; + + if (!base || !off) + return -EINVAL; + + epc_features = pci_epc_get_features(epf->epc, epf->func_no, epf->vfunc_no); + if (!epc_features) { + dev_err(&epf->dev, "epc_features not implemented\n"); + return -EOPNOTSUPP; + } + + align = epc_features->align; + align = align ? align : 128; + if (epc_features->bar[bar].type == BAR_FIXED) + align = max(epc_features->bar[bar].fixed_size, align); + + *base = round_down(addr, align); + *off = addr & (align - 1); + + return 0; +} +EXPORT_SYMBOL_GPL(pci_epf_align_inbound_addr); + static void pci_epf_dev_release(struct device *dev) { struct pci_epf *epf = to_pci_epf(dev); diff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h index 518bc4171285e..1a5cc4d4ae362 100644 --- a/include/linux/pci-epf.h +++ b/include/linux/pci-epf.h @@ -240,6 +240,9 @@ void *pci_epf_alloc_space(struct pci_epf *epf, size_t size, enum pci_barno bar, enum pci_epc_interface_type type); void pci_epf_free_space(struct pci_epf *epf, void *addr, enum pci_barno bar, enum pci_epc_interface_type type); + +int pci_epf_align_inbound_addr(struct pci_epf *epf, enum pci_barno bar, + u64 addr, u64 *base, size_t *off); int pci_epf_bind(struct pci_epf *epf); void pci_epf_unbind(struct pci_epf *epf); int pci_epf_add_vepf(struct pci_epf *epf_pf, struct pci_epf *epf_vf);