From patchwork Wed Mar 5 16:20:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14002943 X-Patchwork-Delegate: kw@linux.com Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011070.outbound.protection.outlook.com [52.101.70.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E612319883C; Wed, 5 Mar 2025 16:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741191650; cv=fail; b=QU81n53W7o3Z2i1EqBl4+pdyGZzvGa/dQ6dsOF+rTzCsw/lWvxTbdwuQiIo8skSjFpja3cJrmaNrPwOU0/elQrhKN5cPYBvkR/Gps90Bvmlue7wlUfjIO+uHQFkEMdl5FbWQjqVNezEn74FlFlXWpLKrwh0NHkcVoz5Xp6vl7ag= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741191650; c=relaxed/simple; bh=3QIzc8WTNujMOXv5K1kYaiq4ezn8ZEepEvWT7U3Cc70=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ls32xxZcNHIlEae/X1EzJf363RzhufH/cEnESEIWTP2y+S0oY391pbKCRyssZy2dKDP7WjO51Psd4lPUEjzMwwbMrk+8aAk1uKJBo/QOMon5ubinWz7RqdwDaRiBE/rcVGmLbS0m8E96pzBz6mm4OfImXog/GaF2kqjjKkSm7ao= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=F4kSvBA9; arc=fail smtp.client-ip=52.101.70.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="F4kSvBA9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SruyA2E7UDkP43w4VrQzQzpyFdv8lnSj4Xmh/ipYNojgKrMekPViNWVvn2d4X6O6nGW3XyM8PJoYorxqlEhxDT7AdlIjLRgjRMOA07Jgo6AY7PY0lSw4pTQbe0S2JbUqst+dzwzOvwyNGPYkP7LI8BC/CczAJEuWKsj/ReulebCsx5JafcTPu4i/7nodKjxy6Slb0wp6CNBRgO6iM+jhMmVsCx/K63zmiKrFVbQnJeMQ3hupNqxZ1Nq7GO9EyipRuNupuw8cU7MBsXGrk2xVOuK3HIEa10sScxe04fgJqLqPiwBs9Tj7ncSVN/PvFTeqR3M9yZGlJ/s4w7aRiOYOSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OfT/Q/5DdN/YXK8m/U1ThkSwFdsp/fnT2K3YASq2D8U=; b=PY8xj4B4oeFJPADTzWeu7y2Wg8eNEMWEd7uJH6I3rRx5xBj05BC+sFvucxlyTVSo8a6FJpUqq7h1ONtFNxvl82g1n2BHEpcuBlLD4bnioekgiLD0BA04Okw90Ge0lpeeFaMWlIfgeqt57P3HV0BUxS21+DiH9INuTHsOfxDpO5+8KTXE/u4Du24GFj2MAn03VHAl7WNvGA+OnLTd3lk7PkcaGTU4T8zBDleRh4/jzE6PGBmBoHBIlqpNLm1X8PlhzYlpfYSZX4EhJ84BUhgg/vTGcj3ZXxrHE7AoOh+iIOrGOjgGra681wwqN2HFhtBKwRXASeAoIoUK62GL+3jKYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OfT/Q/5DdN/YXK8m/U1ThkSwFdsp/fnT2K3YASq2D8U=; b=F4kSvBA9gfo/V7dCST0Ojn/nqLD6SrOinSxkvjVc1TenOU+d9pC1ouwanrXnfuRLQrvkmFDGS+dDbT7bd7fUdhV2Vw8+fPOIxK5QjntKvQhC4qu96OrrPw3tmT/osvweR2OhHYsctCM7pBmtkLF8iq1udkXT80AQC7YInG45f8e2kKA1eObXg7wUyHaOj/SCvt8qkCWEHl87/MxmpGxZ6eFOTui8m+iYGIfgN50zE6qi+KiuFnCvImDA7WZkvsHPsFTDobUlrI0j3C7FtkF2AglM5IhxfzBmURFLApjLXSyjtuNLEMoyNuPI/XBFM1yswFT0ScC8P0inVkmkuhn43Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) by DUZPR04MB10039.eurprd04.prod.outlook.com (2603:10a6:10:4d9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Wed, 5 Mar 2025 16:20:46 +0000 Received: from DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d]) by DB9PR04MB9626.eurprd04.prod.outlook.com ([fe80::e81:b393:ebc5:bc3d%4]) with mapi id 15.20.8489.025; Wed, 5 Mar 2025 16:20:46 +0000 From: Frank Li Date: Wed, 05 Mar 2025 11:20:22 -0500 Subject: [PATCH PATCH RFC NOT TESTED 1/2] ARM: dts: ti: dra7: Correct ranges for PCIe and parent bus nodes Message-Id: <20250305-dra-v1-1-8dc6d9a0e1c0@nxp.com> References: <20250305-dra-v1-0-8dc6d9a0e1c0@nxp.com> In-Reply-To: <20250305-dra-v1-0-8dc6d9a0e1c0@nxp.com> To: Tony Lindgren , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1741191638; l=3360; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=3QIzc8WTNujMOXv5K1kYaiq4ezn8ZEepEvWT7U3Cc70=; b=cPtESDjyV2SR//RApO4tblNVPsYp4T+gUmuKLsS3/lMgRNhOc+0vP2FQa/xl5p1MS7xFQ/507 BwNgIcQl4vkDrclq/KcNcJGqzYRqJlDD65FdIybmgUgTHhj92l/K2xC X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0153.namprd13.prod.outlook.com (2603:10b6:a03:2c7::8) To DB9PR04MB9626.eurprd04.prod.outlook.com (2603:10a6:10:309::18) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB9626:EE_|DUZPR04MB10039:EE_ X-MS-Office365-Filtering-Correlation-Id: b2c0614c-d9aa-4db0-e75e-08dd5c01af7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|52116014|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?+XeRYQjOT+02J+hS2N1UCGhxdrEyzIh?= =?utf-8?q?uqqgDfpuUUXcR67O3m78L1pDdcnupjYl80wSFWHKZdJ2ybyEeEAYSnre4qbTsDVzE?= =?utf-8?q?o79paoeKbuOO7cF2PxvwFRM8HkLKB0xxXzGmCpA37Y2NTHmO4llTMyVFeRopqIExa?= =?utf-8?q?MQ4N920WLm8iESEwdhAb7f4tWxFCHgF63yReiIU9zirVrQIlsMU1CLSFNS9rMW7TT?= =?utf-8?q?SYSdhdRtJlNZ6na9CAAbtz/WqC1lDKwdfHG1OehQdGNPkHIDFwUGho7I/Nsr+uh2b?= =?utf-8?q?gsk38U48GAQ+BZwyBBhVGjXv6FVJYnutEwj8vTX0FhySiCgh5g4nS6QGz94jIfbw5?= =?utf-8?q?fPFk/HDzkEZzciXVnz3CvwU9yAa5lf3jSwiXrWzXKPwEdrnrshlnkPeUceClOjxf1?= =?utf-8?q?SzukSV1vzf2cQanISEGclyvcqB0qhmpLvIZEs3WMxIoOxX5glPi9dqW/n+GzOnhoi?= =?utf-8?q?T3wFJ+EZzUA5gQ/l6iD/su/JQdfsk1IU2O2pRIkU8unpFGgNzCTqnIONK/C6gngfr?= =?utf-8?q?xO+3eZexB5+60cCcOWrFiKLKnHusjI2MU8VLPfFKcTAfkM2H3TOsqc3xL4kSD9mZo?= =?utf-8?q?5SSX8xiZvzV5nNgpR41s6weoWgX2GUDw+Kd34oF5ajjSc13CmEGvR4uqF1SQTAO3f?= =?utf-8?q?Bo9lhRTRhyoVOrPD9bEjuv47InFkDTr1D10jLjiIhP/nEPLu0OjMRQCMgVA/iIral?= =?utf-8?q?IYmgcsVIXGavsPSBBtUWJoBdzCBgB6H6GYC7sOazzk8kwgamuO0wrVEYwTUFFEgQ9?= =?utf-8?q?VsTqq4cwZTNd3b0ZmCccdzW2cgWjRJ3hPvCYHOkCeL6EvnPulgB3EKVQxx3BmOSLP?= =?utf-8?q?vL/aMa8r2q8omW1cMojZXRIV3YQYf+pgNxV1WOGOwhP/gpl2TzcvAoY+QSKwJXzld?= =?utf-8?q?UTBWQL/ADk/s/rpPDWYkCH2+0h2LQyUmIMVUp8BTc6B/eWrf+tyR9ZZwbiQU5am2r?= =?utf-8?q?o8L0WMKMFuTXmIhJk05prnBs/1JxCOO5RjNa70sX3stkplYBotSc7OhBt2lQ/oZWo?= =?utf-8?q?miteOrkZPiRXli1ftexeqG/oq4Rw2hRguAxQzn+3hVFgOyINLVBen6t4mlw1Jjx4u?= =?utf-8?q?ZlGAgEg6YTzkfbo6p32mSXcTwgMzOkv2RrNrC92LYUGp+IZIN9Z7FjB95HW47jw9U?= =?utf-8?q?5ZI2zdN+DceWkqwEdK5JoIME2eAYHUrTupcJs22t2uoikQs7Iv+30AO9+BkrvKfEL?= =?utf-8?q?GNJdxPlNFRLFYMYxwSsABHOuU+eo9NtC2ROJEf/zdWX336RvU1TX2RI/nCzQDVBCB?= =?utf-8?q?g5JZz3qdr3aD+9PLwp2epg8eQzIFD4H1eSOlbz/xzd3icYi0Wk+ebs9S/cUMSYqVX?= =?utf-8?q?JT4RNWHE/lmYl/60IaQbfHnqycBW0ZSg66EyWlP8Tn93dq338NpLxkJY0D8JfQaw+?= =?utf-8?q?RCo63z5snxr?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB9626.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(52116014)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?BfV3nA/gDbEYmeHOj5d5K9myvTMK?= =?utf-8?q?wFrptkYijl7UFhjf+0dygLAAvkPhjPwHEW6AS0na5N8oAPpd/3pzKdE7qIJpnRPrp?= =?utf-8?q?IHUugRiYahl2GQOFMlu7kIlkZq7LoR+mbOUA9HSMCI6h4+yxgElb5Zw7sEM/qZ3fW?= =?utf-8?q?P+3c8ZI3VIyG4YsN9pgmjduRrvLvDdfbolHpFJ0BGzzUQokTY+Brr1K+xnWpNHiUF?= =?utf-8?q?0Y+z3B4z8npx0ICABxqVJYiJX9Tvl+IfAKlNVwqpDSSj8lONoAro5waROlHBPtBSb?= =?utf-8?q?x2A6hfcqY63LmlikLobUFjP1MEPB+b4k0C9ULa5g5OC4QMK5vmoOpdoEINGEM1IUc?= =?utf-8?q?nsZ3Cse8poimBUjKjkn/Usu95Upl98MghdwkhrKavmAzfe1sc3lz9LvcOd5eDJGUr?= =?utf-8?q?+JXmkU/N5i2iW4ArD6PV3yZrAPs+H9F7z8W8jcnZuu1eqkXIbfMfdF2zGcXOXHzv8?= =?utf-8?q?uV4sG7Ie8YWPWVVRPp322NVaoBeFULvhsSts1/lxNdL7Xe9D51Joq2aa6nCA57jLn?= =?utf-8?q?9pmXWx1Zw1rrZOKSd7gvzyl00DUSKI9o1byR0qYU7JQovSPk4e4AW/MqhXtzc/lEG?= =?utf-8?q?N16k4HAa0BneD/dZyGNKBYtIlGChbcnnWrSS8Pq9DxMEwCRHgi0g/LkF1KYJTzTpn?= =?utf-8?q?LHJ2bGQ+cuNvEmIwMX3PQkxSrhIBmMRDX+5bhUHwkvKPpGVCzk7np0+laCPkBaZNc?= =?utf-8?q?sTQWw0qxl2e7T2Keu6ww++umWfVWGmAhNIex8rw3XoXQzFu3eHWd9xgZ6xo8cy29M?= =?utf-8?q?4Jx6pAv+e7W2wa35TpRTuoFqShTdy4lX37AB5SlNhXd7zox8fZR7yepv0A48eIoCs?= =?utf-8?q?YUXVYikpIi7x2KZfjspTIKmHTgum9OJXi084ffQsQcf2K6NWUPdvEMTYooIDs+zvW?= =?utf-8?q?+7vhslBexYfPlMCMHKbPyIk9eIVPBpGyVaoocESloXL9OpqeL0AB8ac46V3w1nuSz?= =?utf-8?q?T78N1n5oFwAH3Ntiq4PKyAESMocuUtmzjtROwnpP+Y2YOg3lp0wYLEfWaaO2mXGL6?= =?utf-8?q?EDc+C7TP+/381CE5i2wXy9zqKNmE1j+o6o0SoDlpyLplmSBBq730fxmyXX0Q7M++f?= =?utf-8?q?4d5f0vVbVPL4s2KPLPiS8ewpGkCRaqevfiBBZuAEHv3Ez0CUe3DOoODAnPZeHhb+r?= =?utf-8?q?Bao8GvneOsBx/1D+UK27QEP5mWeBVoy0Aj9QqfX60E+efcpXkeLINw9TowqdrwbsM?= =?utf-8?q?h0pxuZ1vTtUbwV8K2acACWNr9uc5+MLw3QZR+v5q1nB9PuiCcseDPTFxLFjHpD7Q5?= =?utf-8?q?AaS2pZFlC3ToweIxsIpzJIEAVnACRqlo0ePbObyu6X9z4k2724aYxVl0bDxmvt4y1?= =?utf-8?q?QiGRE8VbvWD4KhA0R7nsfQv+APIcWxPvo0WPxXhR8EATlR1GfaaYZiMoSPtG9n9Az?= =?utf-8?q?w6qGX2wHvjuP5JXvth/feeTnbggdO/gph7VyVDGsxaOzQcI0OnoY1mukj0r5/0FoH?= =?utf-8?q?074katJoj1y9pBZGpSWwTgz/lItVrHfaDb012KEzsJon8hsOxlvcJ8GQK8lY8huya?= =?utf-8?q?noJ2CFzDf0d8?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2c0614c-d9aa-4db0-e75e-08dd5c01af7e X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2025 16:20:46.6707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xSMfXmimBRdipcv/+XeTwQhi9sFL/fM5roK76NnGYHUAhq4bDWCcJKMZKHQFCZYeOn+y8Pg0Hm6S8Qbe8sTXkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB10039 According to code in drivers/pci/controller/dwc/pci-dra7xx.c dra7xx_pcie_cpu_addr_fixup() { return cpu_addr & DRA7XX_CPU_TO_BUS_ADDR; //0x0FFFFFFF } PCI parent bus trim high 4 bits address to 0. Correct ranges in target-module@51000000 to algin hardware behavior, which translate PCIe outbound address 0..0x0fff_ffff to 0x2000_0000..0x2fff_ffff. Set 'config' and 'addr_space' reg values to 0. Change parent bus address of downstream I/O and non-prefetchable memory to 0. Ensure no functional impact on the final address translation result. Prepare for the removal of the driver’s cpu_addr_fixup(). Signed-off-by: Frank Li --- arch/arm/boot/dts/ti/omap/dra7.dtsi | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/ti/omap/dra7.dtsi b/arch/arm/boot/dts/ti/omap/dra7.dtsi index b709703f6c0d4..9213fdd25330b 100644 --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi @@ -196,7 +196,7 @@ axi0: target-module@51000000 { #size-cells = <1>; #address-cells = <1>; ranges = <0x51000000 0x51000000 0x3000>, - <0x20000000 0x20000000 0x10000000>; + <0x00000000 0x20000000 0x10000000>; dma-ranges; /** * To enable PCI endpoint mode, disable the pcie1_rc @@ -205,14 +205,14 @@ axi0: target-module@51000000 { pcie1_rc: pcie@51000000 { reg = <0x51000000 0x2000>, <0x51002000 0x14c>, - <0x20001000 0x2000>; + <0x00001000 0x2000>; reg-names = "rc_dbics", "ti_conf", "config"; interrupts = <0 232 0x4>, <0 233 0x4>; #address-cells = <3>; #size-cells = <2>; device_type = "pci"; - ranges = <0x81000000 0 0x00000000 0x20003000 0 0x00010000>, - <0x82000000 0 0x20013000 0x20013000 0 0x0ffed000>; + ranges = <0x81000000 0 0x00000000 0x00003000 0 0x00010000>, + <0x82000000 0 0x20013000 0x00013000 0 0x0ffed000>; bus-range = <0x00 0xff>; #interrupt-cells = <1>; num-lanes = <1>; @@ -238,7 +238,7 @@ pcie1_ep: pcie_ep@51000000 { reg = <0x51000000 0x28>, <0x51002000 0x14c>, <0x51001000 0x28>, - <0x20001000 0x10000000>; + <0x00001000 0x10000000>; reg-names = "ep_dbics", "ti_conf", "ep_dbics2", "addr_space"; interrupts = <0 232 0x4>; num-lanes = <1>; @@ -270,20 +270,20 @@ axi1: target-module@51800000 { #size-cells = <1>; #address-cells = <1>; ranges = <0x51800000 0x51800000 0x3000>, - <0x30000000 0x30000000 0x10000000>; + <0x00000000 0x30000000 0x10000000>; dma-ranges; status = "disabled"; pcie2_rc: pcie@51800000 { reg = <0x51800000 0x2000>, <0x51802000 0x14c>, - <0x30001000 0x2000>; + <0x00001000 0x2000>; reg-names = "rc_dbics", "ti_conf", "config"; interrupts = <0 355 0x4>, <0 356 0x4>; #address-cells = <3>; #size-cells = <2>; device_type = "pci"; - ranges = <0x81000000 0 0x00000000 0x30003000 0 0x00010000>, - <0x82000000 0 0x30013000 0x30013000 0 0x0ffed000>; + ranges = <0x81000000 0 0x00000000 0x00003000 0 0x00010000>, + <0x82000000 0 0x30013000 0x00013000 0 0x0ffed000>; bus-range = <0x00 0xff>; #interrupt-cells = <1>; num-lanes = <1>;