From patchwork Thu Mar 13 15:38:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14015312 X-Patchwork-Delegate: kw@linux.com Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013066.outbound.protection.outlook.com [40.107.162.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 165EA26A0B4; Thu, 13 Mar 2025 15:39:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741880365; cv=fail; b=WFqR8N4oJ98LI+KXkgUy5OZ47gLOHhJAVnIkx0mFjdEPawb/w/6EySa27gQHCnAiL5mrnlROyPv3gK1XNSNBDf3uHEa6bInd3QrXXx0FbtAjz7Jq/d0R86m4l2LwC8kvGjRhLs/9ITb94/zQn3lmQ50BJaI203QaKrkfmjANU6o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741880365; c=relaxed/simple; bh=T6DcUiXsxiMNKGaSrQrQ6eumahfF/QN5HLNCR1UW6x4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kz/f1lfATeDlSOi1IVfOMwPRQOfEXZKdCoYU+UNFV/UCZC0hxjoY7pJTXjk2mUve5Xk+lFR1Ms02UEE8ogZue075Gn/gT3pZR4GkKodIbmRGqF+uA16PJUhy8W5Xq0dD4CbR0TSB6WXeXWaSN6jx88j/hz0kk5GTZqa1iuwbo48= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=Fuw6Zx2h; arc=fail smtp.client-ip=40.107.162.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="Fuw6Zx2h" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j8TtKyEObwESiM20P+Y41cPSHW2AbfyCN+cbi/DDiB+j3WkgXanXnNVM/buMsL1TBzUvX9vz7Jb1kecGXIcPkkgxPGXBQfxvung70busBPVZkIf0h8th2LejLXqh1k/tTGcSNUzFux6k4xRcAMnLqbPhDzAl3jtbl6aswMUSPTQ0UeKa3b2bc733aOddI2K7xDbCErh4u7HSWrG5hARTqhDxMg1YGL/tovObke58vWHz7Ejte/rFq4cdsTkpBeNc/vjBNk4UMNNFcJ0xt/3Z1+Rmw8hNSoiIFWYhdMkjB68rZPDBuITH0sHNr3ZH2Hb7loPlICaUmDsg1wfFgUym8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KfU0JrPr4MaKdkMfx6JTx2aF8h6E25TXVjReippGryg=; b=btdDdPRjLsLyZLYC0FEP+zA6GJD+Zv0IpWzWULN4zQfDGzYzOMGB8S26Lj8dCo9tSBxgbnMASvWadIhkXZ5e+tcF4WHlts1UMpvoSA3A1MFkdVMZl3v9frw9whKjQwA7hOMnY6L8GUi/1OpFX+2npJPW1KZVT/VoTGk7JYvYiWQxJP4T/NpVLzedemwPTmHlacdgpnKvuICZbY0Ct2Pz+wpM/Yk6itcp0ZcU2wPUUJNYvZo3T6jyz7+OVGpvu2xfoAsfp7X148FScbyuWPSL2JzCaDs25vumhCwneXvn2SUmeK09oxMrYZ4WV4//4X4itzTbRFAO7UdLV125ZCeZiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KfU0JrPr4MaKdkMfx6JTx2aF8h6E25TXVjReippGryg=; b=Fuw6Zx2htF/Wxpk2hjwfTLUKB3X+vAuw69FGDrUCzCaFHM37v5PXpnSWENkwD9AZY0aiuVytGvWZ7GSJbW7mEWK3XzKGRR5hIuwWXdR8twYrH4dLf08WMK2ofsYPjCkdU35pM3pZf2cSsV6TpzLzeDpUIJWDrECeM8D/tkEKnTfuwaj5IIObrlv2SRRC0rDLeGNgGGeunmclJjU1221Rny2WeZ0K2IdRK8MdU/s2AMxjj8ayQc7je7NBCvQasMWg7RPvs/PNMpwC1jt2SBCwomY2qGxQXhM0mL/OraAwpd9QX890NEyEba8zvDIPRD+c1500TjIx6oiRJxjO1d8uWg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DU4PR04MB10316.eurprd04.prod.outlook.com (2603:10a6:10:567::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.25; Thu, 13 Mar 2025 15:39:19 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%3]) with mapi id 15.20.8511.026; Thu, 13 Mar 2025 15:39:19 +0000 From: Frank Li Date: Thu, 13 Mar 2025 11:38:42 -0400 Subject: [PATCH v11 06/11] PCI: dwc: Use devicetree 'ranges' property to get rid of cpu_addr_fixup() callback Message-Id: <20250313-pci_fixup_addr-v11-6-01d2313502ab@nxp.com> References: <20250313-pci_fixup_addr-v11-0-01d2313502ab@nxp.com> In-Reply-To: <20250313-pci_fixup_addr-v11-0-01d2313502ab@nxp.com> To: Rob Herring , Saravana Kannan , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Bjorn Helgaas , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Niklas Cassel , Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1741880335; l=5187; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=T6DcUiXsxiMNKGaSrQrQ6eumahfF/QN5HLNCR1UW6x4=; b=KAaLP5HXS1v9w7jPmyGB2znddDj2l5e6QB452U3OSqHcx/5nOBT/WhUdTe2hKJEj7NpH8o9Vs +3iPyNj+Tv5A+D4/2l0X62OJdwtLT3ybmgmX/sxnJAX5RLldlIAwETD X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SA9PR13CA0038.namprd13.prod.outlook.com (2603:10b6:806:22::13) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DU4PR04MB10316:EE_ X-MS-Office365-Filtering-Correlation-Id: eef7b578-d426-4ec2-4d14-08dd62453804 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|376014|7416014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?AZVwg6oMsX1WKMB509GDZHuH97ni+bK?= =?utf-8?q?QTgdEkDHyMRpDbKQ6W6NzlX/J0NRyI2l4MtzMQaeko3HKHwPMDdStX2bPPhlUHT5c?= =?utf-8?q?eF6nOuqaOvviruaCkGu4CcbrpSyjKaFjeeaNByTLbFjqpAND6cQ5+Ss+fqZVjL8U7?= =?utf-8?q?YZqm9VbGyULW6xuUneHNNEijmHurXsdJCIQxuJPPAdzT9v1SVRfZ1amdzRGORkcum?= =?utf-8?q?uHVd3nCG8Nzw8B12JcFCuoCRP6ucKkbRllAFOqriaA9NF9dMO3tWIQE+EgKlSDWrX?= =?utf-8?q?brqSKW6UXx7j6slrmSuMLUhtEh/5itywE3FgS6skzarbYQjV2ghkLyi5QZRnmOr3V?= =?utf-8?q?J482gCt4OtKYs4Xt9SVrtfxXfPGoFnSSEaH8tYgHVPIiOXC0sgBQObUK+rDEvdx9L?= =?utf-8?q?/+2ZhEunntEfS0jiCqNq2atin5ror2MNY2aezIaTmpFOI6ngwnDDHJqvxhGhfvSdY?= =?utf-8?q?4oD6TZ74kcc1P7nfomuX0OSyaRfMtkaTws0vQPgQR0lBcXISuBdwAihNAtc4NRPFa?= =?utf-8?q?h4M/qhoJL414cujUfDdkzGYDuUwviqC8IOGxGsKODK/ZhcO512hRgfNVvuX6fjuRs?= =?utf-8?q?eEAMCuD9fa6N2YBuBqArhBL+iivxykdR05p9NIkLzRradUM42sMDWhzU08PB5Gk97?= =?utf-8?q?Q8MV1kfPGzCNyQbpzSlLPubFmUtA6Xo4rtLNC274f8YNqKijJMHmvXPRsmrVmXIX2?= =?utf-8?q?q8AFfWvaX2F7Yu20pcTRFWOLLCPsySOcBrl/bJwUNiit6PyiJHDjDWTDZVeIshOf3?= =?utf-8?q?ex1ZTYhOruzMZfZQQkKLef1uK/Z4piiKO0F+U2MUxXkLXnPa2YM79bjI3cJo0M68t?= =?utf-8?q?RanuaI/eUFSmelPEQCAsi39iUe6UzOf7cdLG34a7mjwMipmUNyMf1Tmr/xdQY+ZIJ?= =?utf-8?q?58QLYytpP0rMloBxOo5qutfjMiNiLgDZtgwK3+gkikUq434iO6GnztXJy7ZQXPuOn?= =?utf-8?q?xag0NfkSxyD/FcuQdxyw3kWphxqaxQ7gV8QbGNfyVHxGWchFxmQoqy91ipDJaKoT/?= =?utf-8?q?SV73UAzeXM+CEXbs6q8tZFpDsjICQrpoi79F9t1kcw6QRDpe+20MAcZN2iqKALaSl?= =?utf-8?q?iVux/d/pBVBbzUB0QhQTOJDz7XOmQXUXdZ3GjlH5UvRh8QqTKC3yDv4i1duoPRHxc?= =?utf-8?q?QHoxpwc19sLLf5Gzg7oz9HN9Rz+NIHOwnknk8LtNC6/YRcAaycH2d3lDf3FYQbsxz?= =?utf-8?q?cNUjAJsnjG7GZ2Cf6lytqODrddNhVQxkb5dC/QWPSa+xR8ovO1Bn2UiWWLrQSfZ6i?= =?utf-8?q?W8kbTnRtqYPVyPWjsfUZjum3jJvhIvRHaSlMGm2uPN7W2w6C2Dx654r4FwyDgW5NR?= =?utf-8?q?X7dbtOTrzlMcQoo5YKdymsf2i56GvU+3uxn4+IL4n2NaYVuVpq3iASHixTqThrzSb?= =?utf-8?q?7Dej6bh7FUaD8aXJdgEAO6xBFEvyLvn/Q=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(376014)(7416014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Zh1nsYruu8ZSsHOpLm8YVtNWiGkE?= =?utf-8?q?HpJB280r0g2jLXlk42lv/Ry8Xdd14X0Od6QEcqUenqnkcIIXaXbQjVzA86fYu+OyN?= =?utf-8?q?LaWxsr8qRnD2FINTnCnkdxEwX+WngWJgeu1yqe8NsOusZQTp8JFhYptcCw6pPhsEx?= =?utf-8?q?Jor0xj32TW4JnlgAnlYJWTeFeEZn7gkUQYMfQcmqvCuGVP6gYgUJsXYwCGrUcdmTc?= =?utf-8?q?OF9os9mUD1jvDVMWcLCR9fauH/fWasI+b/vpIlDNF8UoJvYtvLUh/NS4aX0DM2T9d?= =?utf-8?q?OW7Y4eAF9gXmEtx0XnoR/95NB68AZbsTV8c8aacPyLHo0xjT+tYBIZ6/qVM01psE8?= =?utf-8?q?GPOdSZ1vN9O0gvMwPvKxUey413EJDZlV/Ly2PEqDCGr/JeZrte8VnR1qp9MgdS8kL?= =?utf-8?q?f3uM1TIH3FC/ZumeAlQGdUBzLQQTFyoEO/sMTx6UVeQgD31t0z+laYzgdxLBKTTW1?= =?utf-8?q?8YF9NRPPdruMuLmG4cYsQzpGT8O3Hz7O5Uzc0E/C7bk4z+HfNOTzSKaiWrbaeMI1c?= =?utf-8?q?HKiF0t9LUjSxX4YjJna1SA22aTgnV8cZKqozsmIeDJUofLzrlImzpuOjY5bo+nZUF?= =?utf-8?q?hKtoN3j4jvDSb6kIIK4c+o4DLKgcMGp5d46PpMS1ZrCyepdPHv2lZuEtZ/orQszQL?= =?utf-8?q?mdWlHK4f/ELsQJAPh/8mYI1xBZ7uQt2H8Qsmtc041lgCNkt3/deDDD5bdAuJR0YIt?= =?utf-8?q?16pmcHGPuYTBZjH3G+ZW/rwg75OAVb6akWLm0r+Bq7usheT9TGYVPi3mkUP8SI3zS?= =?utf-8?q?T3S8/sWG9gMEkxgl+ajg+QpCER9b6hyC6IWMqD5X+1xYAqChfW7rKiosLFFCn0JE4?= =?utf-8?q?evskm3zsjByNKoNXVHfUJGL30xynj2UYlFE0df/CQL23GBgnzuBozJuHSyHp6+qYA?= =?utf-8?q?f2R4mWhwHOvCEhAqVK/TbCmYwcw7b5vQYSNAPv3SO/HpU7i2WovpsPffUOc77YT15?= =?utf-8?q?z+QOTGxY2iUv7wro9WKNV6w79U0i+EKnF6Ti6NVd0QtXkhK04YHzGbp2drmtR5FsV?= =?utf-8?q?9hW9rOKgWc3yNImCDjzKN0jLR1oXxFkJUQMUgjnbuAuUmqNkamT//msL06gecpLyL?= =?utf-8?q?1LY1qtG7A8loDWivHpRy3J6YcDLbLMcl7yAaT57p8hoR7BrSA3DmZo06Wj61xuiQQ?= =?utf-8?q?E9GZRTn7U4LTh1uQqmrwwlaK0ngpXi9Xfu0vOxyR5E5Pd/1+iBRm2CAtf7LFJnkOk?= =?utf-8?q?hKAJ4z3TJg9zMi1F6mOkWklUcBSNEnTw0QLK9yVo13xw59Smi2PpkhVr753STFtYV?= =?utf-8?q?Z1YqQcUqN+psHWyNO1NFujA3pfN++MPejapc3PV+6c1F67BDjUQw0fh8DKvk0YuVN?= =?utf-8?q?Kq+DGA9vmpKN7DJDjgoaD+wpHnbuD2zOyHNmjiecuQcHQ5qGoCDVM11yBYW0hk9wo?= =?utf-8?q?e0wzc4g59Q1CzalOyFKMYZ3D1UO8wC1sSEf7MBC7U9Z2Bd59vobqxLKAAKqx86ejd?= =?utf-8?q?z/+EcRJz+AXkQpVjbk9t4c5A51RxX1WCLHA6oBcZbLYuioCnVOPnfl+XyiOU5RL++?= =?utf-8?q?Q3dIA+rWQsRF?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eef7b578-d426-4ec2-4d14-08dd62453804 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2025 15:39:19.0134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UYQ1no4W+juig2inG4WdyAX0Fz3P7yyG1UyGGl0ExLm93OuAaUmbK23OREjykCTGsJcKqU4YbtPeLCKaFN+S1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB10316 The 'ranges' property at PCI controller parent bus can indicate address translation information. Most system's bus fabric use 1:1 map between input and output address. but some hardware like i.MX8QXP doesn't use 1:1 map. See below diagram: ┌─────────┐ ┌────────────┐ ┌─────┐ │ │ IA: 0x8ff8_0000 │ │ │ CPU ├───►│ ┌────►├─────────────────┐ │ PCI │ └─────┘ │ │ │ IA: 0x8ff0_0000 │ │ │ CPU Addr │ │ ┌─►├─────────────┐ │ │ Controller │ 0x7ff8_0000─┼───┘ │ │ │ │ │ │ │ │ │ │ │ │ │ PCI Addr 0x7ff0_0000─┼──────┘ │ │ └──► IOSpace ─┼────────────► │ │ │ │ │ 0 0x7000_0000─┼────────►├─────────┐ │ │ │ └─────────┘ │ └──────► CfgSpace ─┼────────────► BUS Fabric │ │ │ 0 │ │ │ └──────────► MemSpace ─┼────────────► IA: 0x8000_0000 │ │ 0x8000_0000 └────────────┘ bus@5f000000 { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <1>; ranges = <0x80000000 0x0 0x70000000 0x10000000>; pcie@5f010000 { compatible = "fsl,imx8q-pcie"; reg = <0x5f010000 0x10000>, <0x8ff00000 0x80000>; reg-names = "dbi", "config"; #address-cells = <3>; #size-cells = <2>; device_type = "pci"; bus-range = <0x00 0xff>; ranges = <0x81000000 0 0x00000000 0x8ff80000 0 0x00010000>, <0x82000000 0 0x80000000 0x80000000 0 0x0ff00000>; ... }; }; Term Intermediate address (IA) here means the address just before PCIe controller. After ATU use this IA instead CPU address, cpu_addr_fixup() can be removed. Use reg-name "config" to detect parent_bus_addr_offset. Suppose the offset is the same for all kinds of address translation. Just set parent_bus_offset, but doesn't use it, so no functional change intended yet. Signed-off-by: Frank Li --- change from v10 to v11 - update commit message's first paragraph because switch to use 'config' to get address translation. - move dw_pcie_init_parent_bus_offset() ahead of bridge->ops = ... change from v9 to v10 - call helper dw_pcie_init_parent_bus_offset() chagne from v8 to v9 - use resoure_entry parent_bus_offset to simple code logic - add check for use_parent_dt_ranges and cpu_addr_fixup to make sure only one set. Change from v7 to v8 - Add dev_warning_once at dw_pcie_iatu_detect() to reminder cpu_addr_fixup() user to correct their code - use 'use_parent_dt_ranges' control enable use dt parent bus node ranges. - rename dw_pcie_get_untranslate_addr to dw_pcie_get_parent_addr(). - of_property_read_reg() already have comments, so needn't add more. - return actual err code from function Change from v6 to v7 Add a resource_size_t parent_bus_addr local varible to fix 32bit build error. | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202410291546.kvgEWJv7-lkp@intel.com/ Chagne from v5 to v6 -add comments for of_property_read_reg(). Change from v4 to v5 - remove confused 0x5f00_0000 range in sample dts. - reorder address at above diagram. Change from v3 to v4 - none Change from v2 to v3 - %s/cpu_untranslate_addr/parent_bus_addr/g - update diagram. - improve commit message. Change from v1 to v2 - update because patch1 change get untranslate address method. - add using_dtbus_info in case break back compatibility for exited platform. --- drivers/pci/controller/dwc/pcie-designware-host.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index 52a441662cabe..482d8ff751526 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -474,6 +474,15 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) pp->io_base = pci_pio_to_address(win->res->start); } + /* + * visconti_pcie_cpu_addr_fixup() use pp->io_base, + * so have to call dw_pcie_init_parent_bus_offset() after init + * pp->io_base. + */ + ret = dw_pcie_init_parent_bus_offset(pci, "config", pp->cfg0_base); + if (ret) + return ret; + /* Set default bus ops */ bridge->ops = &dw_pcie_ops; bridge->child_ops = &dw_child_pcie_ops;