From patchwork Thu Mar 13 15:38:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14015314 X-Patchwork-Delegate: kw@linux.com Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013066.outbound.protection.outlook.com [40.107.162.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9746226A0DF; Thu, 13 Mar 2025 15:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.66 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741880369; cv=fail; b=cPAaeM5RS42CgojKd2F9E4HQ0L3yPlG1V1FmywfQk9FcEs3y2EgYrMnZQQ7HjcWELs5wORiCBmzivCXyjHmJjGirKZXmWg5lR4+ntoJv4gzS4Acf1gErL81ivSdq/km+KXiqXSYTyQbvBbIFFazKPUN2nxIm3LL6XnM9qho4o88= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741880369; c=relaxed/simple; bh=AqcDCqP6UFlZaHS0jNKu5fFmLQdamqvz43QCP/CWh/A=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WfaV0D7z59c7sCJTZRz2xeh2TD0+af3Df8ubVU+YUnmm5rZL2tTujp80uwDNsu/pJ154eWyhUCK5wmDQMcLXBvmQj5rW+upq8da4jFnHwtHyekW9PJ/YlKzcq2yAlXVgABQ2HWDwkttsMq4sKgoKv2IjquMh8x+QBWBsac90b+w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=YOBQjDUY; arc=fail smtp.client-ip=40.107.162.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="YOBQjDUY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v6EJlm70G2rE+r9LCgHd5OSpecmYNo+xipEB/TijQKKYr7WlR9DWccFq3ifV4IUK3vupNycQYFkSpieXAD8sx21He9s3N2afebGXs14llvvBcr8M2fms8yhs+VhKHU1Jo6knN1jmNVkxqX46b/nOGItH6BPNsCEWLXCBgG0LElXuyoeYuKR8JUfWJDi0QrIrucD3IiAyQXj5dk1G30SRfUrGGM0KTLl9nvQmNSaOc2gXdBlm+L2uaZpfFjWQ4/MEEgaTkUuzjVqr5XraK1/rBQrR89Cqa7Hx3zccp97Xpidwbk7WWNch+gJBjQoYdnGHZIjQTjL0GZRBt5ZvHUXnTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YFAKqG/OAiUEcauNBYo0XC6RY89asF13XTVlK2FKYW0=; b=ZzHfSZHR8yVDuha58DGVWkatkhxgaY1fWtGCmYjwVVOzootZJ2m4sAFvnFwi5wT/nYACD5Q7+66VVazqm21myZXoAPQbK+AHnh+BsyvaYkilxLJDA6jvx8j6PD4zjKhwP0w8K5BAguiIYADeiIHgsaWIvDeMrgNxIs/EA1S8T0slfeSOgK6r5DpEqZAGQKoUkxBMvSQfmRPGl6bh9XkdrrYIdQnUr4PB/FiSxqaWSA3H4nXxIy5NFTyRtuSWL3UvayTuoNrdFKBJHazKJbEOPxZhQ7HccQkGzAXbXhcPa/82YV8Tv7Hg3GV6/bEYxDwOkAmV7tPXVKidqMzfjJ1uFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YFAKqG/OAiUEcauNBYo0XC6RY89asF13XTVlK2FKYW0=; b=YOBQjDUYkOe2dAAKHHi6jKS/LTWqTJ/YT2DnmKospwvRmyAaj91R14ZsPmKLWJ0UJ0tzOoDWbhoJixyAQwlQYfIqIdP29jwzVd6tr/qiHyzYkasS8KLtU75lxRnsz7twRqXRa6k8w04fpOn2DJIcrxRcNV1fsP54iefHJvi77s0vxqYA6yXwjd9LQt39m323yfjCwWpIcHNPoY5z5vX+OjCqu2p1NikOAsV1homW2kdWriRjac1bsmkLG2G9If0GrEHImSUcVmpp4fOvv0gYgLwU1SRtMUcj+fKh9kLFXtvvusq7Z6vjaOv/Ef5V3s5zQXGn1csB0E7Nyvv0CHkfKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DU4PR04MB10316.eurprd04.prod.outlook.com (2603:10a6:10:567::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.25; Thu, 13 Mar 2025 15:39:25 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%3]) with mapi id 15.20.8511.026; Thu, 13 Mar 2025 15:39:25 +0000 From: Frank Li Date: Thu, 13 Mar 2025 11:38:44 -0400 Subject: [PATCH v11 08/11] PCI: dwc: ep: Ensure proper iteration over outbound map windows Message-Id: <20250313-pci_fixup_addr-v11-8-01d2313502ab@nxp.com> References: <20250313-pci_fixup_addr-v11-0-01d2313502ab@nxp.com> In-Reply-To: <20250313-pci_fixup_addr-v11-0-01d2313502ab@nxp.com> To: Rob Herring , Saravana Kannan , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Bjorn Helgaas , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Niklas Cassel , Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1741880335; l=1478; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=AqcDCqP6UFlZaHS0jNKu5fFmLQdamqvz43QCP/CWh/A=; b=V196LLvts0CZlPIzM4HbePyv0rXYwas/XT/yu0lERN46Zz45SEk6HMK2mg3OTNmV0XHzSsNzC zNvwIz1WAXgCm4aLRLd15Z0AeAAJFx75tQTBHMXq6YOSFS16vMmVtm6 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SA9PR13CA0038.namprd13.prod.outlook.com (2603:10b6:806:22::13) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DU4PR04MB10316:EE_ X-MS-Office365-Filtering-Correlation-Id: 6dd2fae1-16c9-42d7-bd6e-08dd62453be2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|366016|376014|7416014|1800799024|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?QMorVlrRzQ9aGb5yP7/gWeIwHPulvhI?= =?utf-8?q?GIatf5z6rdshggZ6E08jSg30sjH9Gubr8RRHUneoAGlYNkM+gpuR9iolA3ZBN543D?= =?utf-8?q?qdLr/zt5spmU6tS7CVbZGz3zLZ+WmJD2Cmr3FRukNu1zLH210TP1hNoIpiBZQbHeX?= =?utf-8?q?9jOPwvt7EpJaaNvw9xry6fO/Wl7dcB2cChQY+bG0YTD4xWESfgVxyUund9GdVr5oU?= =?utf-8?q?Ll/uw0Ak8YYX5ot1/Dhdd1T3XA0mrabOT5spnXgvuirRWvCEjI6CeDggMBe0RsrYI?= =?utf-8?q?R/UTg+4xEleiOZ/LNRxK2RtC0VSepixwXKM+qUHUhLO1j2SOg7nQ3QkPY96Zo1Fsm?= =?utf-8?q?cfDvyufsBzvVVTlmTSwBwCUsPTFzawPXOesWdGdM0IqmEzbvSijcM+jaKg0bi1IeX?= =?utf-8?q?Bw3U3m+oWWysL9vT7ShCX2+MDlT6Pt4xlYlC9t6W7PHLGDcyV5kjUysKwbmLbE1sy?= =?utf-8?q?6Rf4cOLN9FAIK+3N4GR4pj5WnIlyUUflu/0ar4ccM0janbCJWUOmIPZJ3LhwpmfzQ?= =?utf-8?q?Py9PB7ekmzxOc+BlI/GhOkTCAmpITbyKT1bsIBX4NeCBT6qmJ5epdeMqRofcZ0Ukp?= =?utf-8?q?2KMZQjoY8Ivetp/tOuVHS/QRg3e59rwODh/Vj8deCSG26cEOKGUM7YykjP1G4OW14?= =?utf-8?q?AmHmKaDhuSJucqg01BfakcGXM8LEgHmikiSNU/22hhOzLYOXctY+GDhulL0RNnNDw?= =?utf-8?q?xE6/EOlbATwok1/ojOo77z6blfxLQIgci9V30+twew0ph0mOLsMNQ7VnsMLLwHsRS?= =?utf-8?q?fCUVnrBu366H/M4tftOZXquByjIdPE6InQ0kF3DRx5Sc3l+d8YL+Dm4ErdbGhhaBK?= =?utf-8?q?sWpiKt6zJ8jaDKh8a0xZxT465fHEgO8LAjrwOyjpbfitnRpohI5Sq4VumelvFZi9B?= =?utf-8?q?N36OLFO8DTcB3h9oewolZx13oVacbpZXnTxnz+pJLmxA6KdxuHUHf2yCk4QMoP35W?= =?utf-8?q?Q0rQg0qS1/eFHuHvI2qjvJcgVdKJ+hgqiLyCak1rXWVcC5vHFY8Sqnftihm9kI52V?= =?utf-8?q?qPRvjzewHmF8jkbP+FQnw0ZvPizJTGHAU4tC6g4+Oi7qF3JbnEsaB3MFO5mLAiPGW?= =?utf-8?q?EgG1yYv6b2h1C5J7EocnGXHVBsIC6Y15M/AjYX4EzK+K/msKnz3O9TlxOO/EFTIk2?= =?utf-8?q?H9wbaqnXecdzGJAFBb5hWww7i4eKSOL7QNP49KTdAClNx8paGjYBvC1lvq0fbCZrj?= =?utf-8?q?ULHMeI76LLG9xzRgrdqN2uX0uBLqH8KWLMjTjVy/W5+vw1dnPiDqdMWrJmErjHOIJ?= =?utf-8?q?ZlNjJmMKDujL+9e1p7lVF+jAHI6AuRC4T17b92cygvPx9uca2X6v4gCKfKf/M0CdK?= =?utf-8?q?l7jst/Z8fbCAdAnAnGpwtk2l2PlgOHzIB8QeRBrtDJwoOpzI9ZI4VXvnkat5pIM7M?= =?utf-8?q?+LsXSrYtAtZ?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(366016)(376014)(7416014)(1800799024)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?MJeOv3HrJAgQ7lz6IcsHx1hfiZ6z?= =?utf-8?q?LqIDFs3BkudLd0UoQD4v2BsW7bGGP8YFSEWp54QhVM2SrAAgcsPLzNf2aR4bylNXW?= =?utf-8?q?yronBsXVhiJNzNoBMUgbX0c7/k3swW2SIxV7c1ES17NVotcSUDFhoikqxn+EpYaXE?= =?utf-8?q?TMlIBJNV/flhKpgHW5iHPFRZ1rH2vv9mArpub0CoMlLpp4eI2F++hlInsAYEvg9Fx?= =?utf-8?q?8SfQNd/65Qm59V0L92VTxdrhFkIXoegb/VrIsSroONNfswExH8VGxh6xjt7Rs0x74?= =?utf-8?q?hH+lg1+FejWkVqyuQL1Z/nTUX2JQ8QDggXHGU4fw3M3iRRb9JAujoEjnqsMGrW7uD?= =?utf-8?q?nBi0Ac7XnlKKvQVEn60FX/qwRZ8MQv0lREK5t/4RdA2qejsNIkC3fgOpTNNJXoccP?= =?utf-8?q?Ceaanxx4/djfow8VSVnocfYJ9NelI3zeFUMdj3d95we3YZeXEy/Wxt5SInuxBqtNJ?= =?utf-8?q?uEBWR9J35kWFxxsRBvHWJC9N4DAnxZq3jaFq/TULyBK6uP07Oap8BBHiu63udHUYe?= =?utf-8?q?LO9E/7sWWY9XHLwmD2ZTJQAlI+R4w6TFA/KRnh5lT4jUl05VpcxBr9qCli4EsboCP?= =?utf-8?q?XLhehARq1TBwoYS2sFpdE23pmOhKZryJ5p3YnuNw5OZ5OoMR8u9k7hDF4Og3pCpDt?= =?utf-8?q?B1flHQyj9/fdr1zouvLEQkDxUBTeWUGE867d3+R8/MMr4x8rAn01I0161FnlZpAto?= =?utf-8?q?rtRfhwZ1tftI5+tFCs6R02cKYRjFK3RySV8u5lAkSelMV00jRcepuD/kQn9AV5lJ1?= =?utf-8?q?tdH3E0wMLzbwsrmc35LmyGw8E16g7pQ27mtzWr7pQFsiCzgCOSIGbpMFfaXBGsghV?= =?utf-8?q?LhNIE2lVCizuWTrygwa8z88MrukKn6eTI5sq5/RUo6TqkG2KfALYyQ7g0cTBrsHyn?= =?utf-8?q?iV9K9Al6NmSYB3lC2shbvkGi0gVP6EDXoDwOqoWB3h3FSCyF+8SAgMmsG3fKTabIp?= =?utf-8?q?wUhQq2pIBbezmKnonG/xX9CKIR028SyBp0w7SvLk3ocw8behaWsJX6SeuXcVQPdJ0?= =?utf-8?q?c4WSmqv2z4OszMgKABzkzoCZp+yeL7SZMR1YagfcteQRLppZcgEglqwM3vZPTk9vL?= =?utf-8?q?o7dwXiB6cNVF7feAaO+sDYkaCFcAYIbMHjTDnSyezj4XfkBTlIDeW/9pcgHemb2st?= =?utf-8?q?z5KXb3o+gYP4cQWvjoAz/OgA+lLdYO0lnt+OOYxTbteU1sX4hu2vEzxjF35Ci3OVb?= =?utf-8?q?yk3TPjTPJ3FTVKq7T+e3B5zJNXBEv6ChoH73RIR5bFitA332hCG3BO8OMqY3wlIEH?= =?utf-8?q?Ft1+eIzwthE8VA0yKOvS28nI9vdcG8fiFqxwmXf/xik1DKvBsApYb3YLdgAv2FmOT?= =?utf-8?q?ZsZNYgDvfIxFMiw2FMvo3RTnd81Q8nXImQ4uZFNx/z2cMGBR/rh7PUCNT6M29d/Ab?= =?utf-8?q?l0FEu7sVIkCEZnN6zYuJ41AjYcvDjDjEDRPHvHufmTOCFQjDHgfTi1kvyOfwelAYA?= =?utf-8?q?IqmcNeAoLeQaBYJf2waTjC2Ff2R2//3wbWkwkhq4KdCr32U42XehSYCaLguVNw+V5?= =?utf-8?q?4ZXPmHO2+m9C?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dd2fae1-16c9-42d7-bd6e-08dd62453be2 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2025 15:39:25.4934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fSl68L5glxPttXgbNn9taZKfRMWZ61f+ucOMMHX0TcqskjjcuUO7LmMFxW0kQwLlRBFKcOfU9IafTSA0lJQ3nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR04MB10316 Most systems' PCIe outbound map windows have non-zero physical addresses, but the possibility of encountering zero increased after following commit ("PCI: dwc: Use parent_bus_offset"). 'ep->outbound_addr[n]', representing 'parent_bus_address', might be 0 on some hardware, which trims high address bits through bus fabric before sending to the PCIe controller. Replace the iteration logic with 'for_each_set_bit()' to ensure only allocated map windows are iterated when determining the ATU index from a given address. Signed-off-by: Frank Li --- change from v10 to v11 - change refer commit change from v9 to v10 - remove commit hash value change from v8 to v9 - new patch --- drivers/pci/controller/dwc/pcie-designware-ep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c index d69d76c150d92..4ecddab131b33 100644 --- a/drivers/pci/controller/dwc/pcie-designware-ep.c +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c @@ -282,7 +282,7 @@ static int dw_pcie_find_index(struct dw_pcie_ep *ep, phys_addr_t addr, u32 index; struct dw_pcie *pci = to_dw_pcie_from_ep(ep); - for (index = 0; index < pci->num_ob_windows; index++) { + for_each_set_bit(index, ep->ob_window_map, pci->num_ob_windows) { if (ep->outbound_addr[index] != addr) continue; *atu_index = index;